RE: Re: [DISCUSS] Replace stale bot with ping-pong workflow

2023-12-04 Thread Joo Hyuk Kim (Vince)
Coming from https://github.com/apache/pulsar/pull/21549. Agreed on Stale-Bot creating too much noise. Another suggestion : just disable commenting functionality. There is consensus where noise is the problem and not the having Stale label itself. All we need to do is remove field "stale-issue-me

RE: Re: [DISCUSS] Seek for maintainers of pulsar-manager

2023-07-23 Thread Joo Hyuk Kim
also start to look around and put in some work. Thanks, JooHyukKim (vince) [1] https://github.com/apache/pulsar-manager On 2023/07/23 07:44:05 Joo Hyuk Kim wrote: > > However, the tech stack is a bit old to take up and it seems we have > fewer contributors maintain this project. I

Re: [DISCUSS] Seek for maintainers of pulsar-manager

2023-07-23 Thread Joo Hyuk Kim
> However, the tech stack is a bit old to take up and it seems we have fewer contributors maintain this project. I tried to resolve some issues but encountered troubles in both lack of time and lack of collaborators. It really seems that the Pulsar-manager project lacks contributions and could be

Re: [ANNOUNCE] Zili Chen (tison) as new PMC member in Apache Pulsar

2023-07-21 Thread Joo Hyuk Kim
Totally earned it. Congrats! Thanks, JooHyukKim. 2023년 7월 22일 (토) 오후 1:00, SiNan Liu 님이 작성: > Congratulations > > Thanks, > sinan > > > Yu 于2023年7月22日周六 11:53写道: > > > Congrats! > > > > On Sat, Jul 22, 2023 at 9:53 AM ZhangJian He wrote: > > > > > Congratulations > > > > > > Thanks > > > Zhang

Re: [VOTE] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-11 Thread Joo Hyuk Kim
Hi community, Thank you all for your participation. We may close the vote with the following result. 1 of (+1 non-binding) - Zili Chen 3 of (+1 binding) - Yunze Xu - Mattison (Qiang Zhao) - Nicolò Boschi Best regards JooHyukKim (Vince) On Tue, Jul 11, 2023 at 7:04 PM Joo Hyuk Kim

Re: [VOTE] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-11 Thread Joo Hyuk Kim
On Tue, Jul 11, 2023 at 6:58 PM Joo Hyuk Kim wrote: > > As long as we don't introduce any breaking change and the new parameters > are covered by unit test > > Hello, thank you for your feedback. > I agree and will add following to PIP file. > "The refactored paramet

Re: [VOTE] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-11 Thread Joo Hyuk Kim
: > > > +1(binding) > > > > Best, > > Mattison > > > > On 2023/07/07 09:25:22 Joo Hyuk Kim wrote: > > > Hi community, > > > > > > This PIP has received a couple of approvals in github PR link [1] > > > So I thought it's ti

RE: Re: [VOTE] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-10 Thread Joo Hyuk Kim
Thanks, JooHyuk. On 2023/07/10 00:24:20 Zili Chen wrote: > +1 (non-binding) > > On 2023/07/07 09:25:22 Joo Hyuk Kim wrote: > > Hi community, > > > > This PIP has received a couple of approvals in github PR link [1] > > So I thought it's time to vote. > &

[VOTE] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-07 Thread Joo Hyuk Kim
Hi community, This PIP has received a couple of approvals in github PR link [1] So I thought it's time to vote. ## Motivation In the current Pulsar codebase, the logic to parse CLI arguments for measurement units like time and bytes is scattered across various CLI classes. Each value read has i

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
you clarify this part? > `brokerShutdownMaxNumberOfGracefulBundleUnloadPerMinute=60` is the same as > `brokerShutdownMaxNumberOfGracefulBundleUnloadPerSec=1` So, the "per-min" > config can be more granular. > > Heesung > > On Thu, Jul 6, 2023 at 10:04 PM Joo Hyuk Kim wrote: > > >

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
Hi, I agree that unloading per-sec might too fast, but we should also consider per-minute could be too slow for some. So we might as well add configurability for unload rate (in seconds).But I am concerend that we might end up having too many parameters 🤔 Thanks, JooHyukKim(vince) On Fri, Jul 7,

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
Thanks, 🙂 JooHyukKim (vince) On Fri, Jul 7, 2023 at 11:59 AM Joo Hyuk Kim wrote: > > When Pulsar undergoes a graceful shutdown, it unloads all topics, but > there is no limit on the rate of unloading > > Is it possible that following code might already cover what we need he

Re: [DISCUSS] Unload Rate Limiting during Graceful Shutdown of Pulsar

2023-07-06 Thread Joo Hyuk Kim
> When Pulsar undergoes a graceful shutdown, it unloads all topics, but there is no limit on the rate of unloading Is it possible that following code might already cover what we need here? https://github.com/apache/pulsar/blob/7636e8989f4d3fc24fce69a356d54e1c550945ed/pulsar-broker/src/main/java/o

RE: [DISCUSS] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-07-01 Thread Joo Hyuk Kim
/20691 Best, joo hyuk (vince) On 2023/06/30 07:20:11 Joo Hyuk Kim wrote: > Hi, community > > > I am proposing to refactor `Cmd*` classes’s measurement parsing logic. > > > ## Background > > > As it stands, the parsing logic for measurement units such as time and >

[DISCUSS] PIP-280 : Refactor CLI Argument Parsing Logic for Measurement Units using JCommander's custom converter

2023-06-30 Thread Joo Hyuk Kim
Hi, community I am proposing to refactor `Cmd*` classes’s measurement parsing logic. ## Background As it stands, the parsing logic for measurement units such as time and bytes in various CLI classes is implemented verbosely, contained in the Cmd converter themselves. Leading to a lack of code

Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools

2023-06-29 Thread Joo Hyuk Kim
e used. Spotless has an IDEA plugin > but it's for Gradle task only. > > Best, > tison. > > [1] https://plugins.jetbrains.com/plugin/13180-palantir-java-format > > > Joo Hyuk Kim 于2023年6月30日周五 10:38写道: > > > Sounds great. > > > > Another thing i

Re: [DISCUSS] Consistent code style (esp. ws/indent) and autotools

2023-06-29 Thread Joo Hyuk Kim
Sounds great. Another thing is about IDE. Pulsar site sort of directs contributors to use IntelliJ as shown in https://pulsar.apache.org/contribute/setup-ide/. It would be nice if there was IDE support (auto-format, or shortkey-base) and we can add it to the setup-ide guide also. Do you know any?

RE: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-29 Thread Joo Hyuk Kim
May I make a proposal : adding `remote` flag also? 🙂 #Concern : It seems like we are sort of allowing users to assume what the ones without `local` flag are (are called by the community). #Possible Benfit : Users will benefit from not having to think about what ` non-local` clusters are called.

[DISCUSS] Provide consistent concept around partitioned topic and topic partition/internal topic

2023-06-25 Thread Joo Hyuk Kim
ion of what composes "partitioned topic", then apply to pulsar-site, javadoc, and TopicName API accordingly. Let me know what you think # ISSUE https://github.com/apache/pulsar/issues/20622 Regards Joo Hyuk, Kim (Vince)

RE: [DISCUSS] PIP-277: Clusters list API return clusters with local flag

2023-06-24 Thread Joo Hyuk Kim
May I make a proposal : adding `remote` flag also? 🙂 #Concern : It seems like we are sort of allowing users to assume what the ones without `local` flag are (are called by the community). #Possible Benfit : Users will benefit from not having to think about what ` non-local` clusters are called.