Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-07 Thread PengHui Li
Thanks for the clarification I have left comments on the PR. PLAT. Thanks, Penghui On Sat, May 7, 2022 at 9:56 PM Enrico Olivelli wrote: > Peng Hui > > Il giorno ven 6 mag 2022 alle ore 12:54 PengHui Li > ha scritto: > > > > > The problem is that If I use multiple subscriptions then I am not

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-07 Thread Enrico Olivelli
Peng Hui Il giorno ven 6 mag 2022 alle ore 12:54 PengHui Li ha scritto: > > > The problem is that If I use multiple subscriptions then I am not > guaranteed that each message is delivered only to one consumer. > > It is a weird use case, but it is something that is possible according > to the JMS

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-07 Thread Enrico Olivelli
Lin Lin Il giorno ven 6 mag 2022 alle ore 16:51 Lin Lin ha scritto: > > The addition of this feature looks like a matter of consumer selection. > Should the consumer selection of each Dispatcher be abstracted into an > extensible interface? This would be useful and a great addition, but actuall

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-06 Thread Lin Lin
The addition of this feature looks like a matter of consumer selection. Should the consumer selection of each Dispatcher be abstracted into an extensible interface? Thanks Lin Lin

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-06 Thread PengHui Li
> The problem is that If I use multiple subscriptions then I am not guaranteed that each message is delivered only to one consumer. It is a weird use case, but it is something that is possible according to the JMS specs. I am mapping a JMS Queue with a Subscription, and everything works well, but

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-06 Thread Haiting Jiang
It looks like we can add something like `EntryDispatcher` before the EntryFilter. Mixing entry filtering and consumer selecting seems a little confusing. The `EntryDispatcher` could works as a consumer selector in `PersistentDispatcherMultipleConsumers`. It accepts an entry and a consumer li

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-06 Thread Enrico Olivelli
Il giorno ven 6 mag 2022 alle ore 01:50 PengHui Li ha scritto: > > > The Message goes through the EntryFilter that decides if the Entry > matches the requirements of the Consumer. > - if the message matches the consumer then it returns ACCEPT > - if the message does not match the consumer then it

Re: [DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-05 Thread PengHui Li
> The Message goes through the EntryFilter that decides if the Entry matches the requirements of the Consumer. - if the message matches the consumer then it returns ACCEPT - if the message does not match the consumer then it has to be rescheduled (RESCHEDULE) It looks like different consumers have

[DISCUSS] PIP-105 extension: per-consumer filtering

2022-05-05 Thread Enrico Olivelli
Hello, I am trying to use PIP-105 and I found out that we are missing a few little things to cover my user case. In my case I have two consumers who compete on the same SHARED subscription with a "message filter". The filter is passed as Consumer metadata. When you have two Consumers connected on