Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-07 Thread Zixuan Liu
+1 Thanks, Zixuan Yubiao Feng 于2023年10月7日周六 21:05写道: > > Hi Kecona > > Sorry, I think I did not clear what I wanted to say. And correct it: could > you add more detail to the Motivation, for example: I need the field > `ordering_key` to do something, but I can not get it from Publish Context. >

Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-07 Thread Yubiao Feng
Hi Kecona Sorry, I think I did not clear what I wanted to say. And correct it: could you add more detail to the Motivation, for example: I need the field `ordering_key` to do something, but I can not get it from Publish Context. Thanks Yubiao Feng On Sat, Oct 7, 2023 at 3:53 PM kecona wrote: >

Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-07 Thread kecona
Hi yubiao, The above message metadata is confusing to you. The message metadata refers to `org.apache.pulsar.common.api.proto.MessageMetadata`. This PIP has been updated, could you review it again? Thanks, Kecona kecona 于2023年10月7日周六 12:48写道: > Hi all, > > I wrote a PIP to make PublishContext

Re: [DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-06 Thread Yubiao Feng
Hi Kecona Since the Publish Context already has these methods to use: `producerName`, `sequenceId`, `originalProducerName`, `numberOfMessages`, `isMarkerMessage`, `isChunked`, `props`. Could you explain the detail of what field of message metadata needs to be used? It is better to add the detail

[DISCUSS] PIP-304: Make PublishContext provide the message metadata

2023-10-06 Thread kecona
Hi all, I wrote a PIP to make PublishContext provide the message metadata, see https://github.com/apache/pulsar/pull/21311. An implementation for this PIP: https://github.com/apache/pulsar/pull/21245(reverting) Please let me know your thoughts! Thanks, Kecona