[GitHub] [pulsar-client-node] massakam commented on pull request #182: fix: use pause and resume api to ensure orderly init listener->consumer

2021-12-06 Thread GitBox
massakam commented on pull request #182: URL: https://github.com/apache/pulsar-client-node/pull/182#issuecomment-986555301 @rickyes Sorry, [this comment](https://github.com/apache/pulsar-client-node/pull/182#issuecomment-986538154) is incorrect. It seems that `MessageListener` is not trig

[GitHub] [pulsar-client-node] massakam commented on pull request #182: fix: use pause and resume api to ensure orderly init listener->consumer

2021-12-06 Thread GitBox
massakam commented on pull request #182: URL: https://github.com/apache/pulsar-client-node/pull/182#issuecomment-986538154 @rickyes I think this bug becomes apparent if the `MessageListener` is triggered before the `subscribeCallback` is completed. -- This is an automated message from t

[GitHub] [pulsar-client-node] massakam commented on pull request #182: fix: use pause and resume api to ensure orderly init listener->consumer

2021-12-05 Thread GitBox
massakam commented on pull request #182: URL: https://github.com/apache/pulsar-client-node/pull/182#issuecomment-986434813 @rickyes This phenomenon does not always occur. It happens when `data->consumer` is accessed in the following part before it is initialized. https://github.com/apa

[GitHub] [pulsar-client-node] massakam commented on pull request #182: fix: use pause and resume api to ensure orderly init listener->consumer

2021-12-05 Thread GitBox
massakam commented on pull request #182: URL: https://github.com/apache/pulsar-client-node/pull/182#issuecomment-986382291 @rickyes Details are explained in #181. Merging this PR should fix the issue. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [pulsar-client-node] massakam commented on pull request #182: fix: use pause and resume api to ensure orderly init listener->consumer

2021-12-02 Thread GitBox
massakam commented on pull request #182: URL: https://github.com/apache/pulsar-client-node/pull/182#issuecomment-984501591 @lipeining Thank you for your contribution. The change looks good to me. But why is the destination branch `branch-1.3` instead of `master`? Do you want v1.3.x