Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-29 Thread Kirby Zhou
> On 一月 24, 2022, 11:20 a.m., Mateen Mansoori wrote: > > After applying your patch, Below files/folder are missing from ews/webaap > > > > log4j-kmsaudit.properties > > logback.xml > > META-INF/ > > mini-kms-acls-default.xml > > Kirby Zhou wrote: > Yes, but I have checked, nothing depends

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-29 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73816/ --- (Updated 一月 29, 2022, 9:30 a.m.) Review request for ranger, Dhaval Shah, Dinesh

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-26 Thread Mateen Mansoori
> On Jan. 24, 2022, 11:20 a.m., Mateen Mansoori wrote: > > After applying your patch, Below files/folder are missing from ews/webaap > > > > log4j-kmsaudit.properties > > logback.xml > > META-INF/ > > mini-kms-acls-default.xml > > Kirby Zhou wrote: > Yes, but I have checked, nothing depend

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-25 Thread Kirby Zhou
> On 一月 24, 2022, 11:20 a.m., Mateen Mansoori wrote: > > After applying your patch, Below files/folder are missing from ews/webaap > > > > log4j-kmsaudit.properties > > logback.xml > > META-INF/ > > mini-kms-acls-default.xml > > Kirby Zhou wrote: > Yes, but I have checked, nothing depends

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-25 Thread Kirby Zhou
> On 一月 24, 2022, 11:20 a.m., Mateen Mansoori wrote: > > After applying your patch, Below files/folder are missing from ews/webaap > > > > log4j-kmsaudit.properties > > logback.xml > > META-INF/ > > mini-kms-acls-default.xml Yes, but I have checked, nothing depends on them. * log4j-kmsaudit.

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-24 Thread Mateen Mansoori
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73816/#review223993 --- After applying your patch, Below files/folder are missing from ews

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-24 Thread Kirby Zhou
> On 一月 24, 2022, 9:52 a.m., Pradeep Agrawal wrote: > > Are you removing the web.xml permanently ? There 2 web.xml in git, the effective content are same. kms/src/main/resources/WEB-INF/web.xml kms/src/main/webapp/WEB-INF/web.xml ``` % diff kms//src/main/resources/WEB-INF/web.xml kms/src/ma

Re: Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-24 Thread Pradeep Agrawal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73816/#review223991 --- Are you removing the web.xml permanently ? - Pradeep Agrawal On

Review Request 73816: use range-kms.jar instead of .class, avoid rubbish

2022-01-23 Thread Kirby Zhou
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73816/ --- Review request for ranger. Bugs: RANGER-3595 https://issues.apache.org/jira