Re: Review Request: Person API should handle "-1" as a user id

http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java <https://reviews.apache.org/r/5055/#comment16871> Yup missed the "and" in that statement I can do that. - Ryan On 2012-05-07 20:59

Re: Review Request: Person API should handle "-1" as a user id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ --- (Updated 2012-05-07 20:59:08.081493) Review request for shindig. Summary -

Review Request: Person API should handle "-1" as a user id

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ --- Review request for shindig. Summary --- Section 2.1.1.1 of the Social Serve

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4976/ > --- > > (Updated 2012-05-04 16:29:28) > > > Review request for shin

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4976/ > ------- > > (Updated 2012-05-04 07:28:05) > > > Review request for shindig and Ryan Baxter. > > > Summary > --- > > Add code to handle EE extension for OpenSocial

Re: Review Request: Allow gadgets to properly manage/scroll the content area they have been afforded by the container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4973/#review7558 --- Ship it! LGTM - Ryan On 2012-05-03 14:54:20, Dan Dumont wrote: >

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

> On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js, > > line 170 > > <https://reviews.apache.org/r/4976/diff/2/?file=106085#file106085line170> > > > >

Re: Review Request: Add code to handle OpenSocial Embedded Experience data model context extension per http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model for OpenSocial 2.5

This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4976/ > --- > > (Updated 2012-05-02 23:24:37) > > > Review request for shindig and Ryan Baxter. > > > Summary > --- >

Re: Review Request: Add registerConextListener API for embedded experiences

eview7464 --- On 2012-05-01 20:11:15, Ryan Baxter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4898/ > --

Re: Review Request: Origination info for OAuthRequest exchange token request

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4949/#review7445 --- Ship it! LGTM - Ryan On 2012-05-01 17:57:22, BrianLillie wrote: >

Re: Review Request: Allow site element creation to be asynchronous in open-views features

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4951/#review7444 --- Ship it! It makes me cringe a little but I understand you are trying

Re: Review Request: Add registerConextListener API for embedded experiences

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ --- (Updated 2012-05-01 20:11:15.214794) Review request for shindig. Changes -

Re: Review Request: Add registerConextListener API for embedded experiences

---- On 2012-04-27 20:05:22, Ryan Baxter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4898/ > ---

Re: Review Request: Add registerConextListener API for embedded experiences

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ --- (Updated 2012-04-27 20:05:22.083583) Review request for shindig. Changes -

Re: Review Request: proxied-form-post: Write the response in a way that won't be unintentionally un-escaped by browsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4896/#review7310 --- Ship it! LGTM - Ryan On 2012-04-27 16:24:50, Dan Dumont wrote: >

Re: Review Request: proxied-form-post: Write the response in a way that won't be unintentionally un-escaped by browsers.

> On 2012-04-26 21:15:47, Ryan Baxter wrote: > > LGTM. Since our existing test cases didn't catch this can we add a test > > case for this? > > Dan Dumont wrote: > A jsunit test case wouldn't have caught this I don't think... It would > requir

Re: Review Request: proxied-form-post: Write the response in a way that won't be unintentionally un-escaped by browsers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4896/#review7281 --- LGTM. Since our existing test cases didn't catch this can we add a te

Review Request: Add registerConextListener API for embedded experiences

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4898/ --- Review request for shindig. Summary --- These changes are needed to align w

Re: Review Request: Update isStale method in HttpResponse to return true when max-age equals 0

gt; Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and > Brian Lillie. > > > Summary > --- > > Since max-age=0 means the response expires immediately when the response is > generated, and there is no need to compute TTL with possibly incorrect

Re: Review Request: Update EhCache configuration to use pooled resources for cache sizing

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4856/#review7188 --- http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/re

Re: Review Request: SHINDIG-1677 Fix the REST response for collection to wrap it with "list" field

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4760/#review7012 --- Ship it! LGTM just one small nit trunk/java/common/src/test/java/or

Re: Review Request: When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4789/#review7007 --- Committed revision 1327569 - Ryan On 2012-04-18 14:54:36, Ryan

Review Request: When the property gadgets.jsonProxyUrl.maxPostSize is missing from the container.js the default post size ends up being 0 instead of using the default value

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4789/ --- Review request for shindig and Dan Dumont. Summary --- If a container.js is

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

> On 2012-04-12 12:14:33, Ryan Baxter wrote: > > LGTM Adam! If no one else has any feedback I will commit this tomorrow. Committed revision 1326799 - Ryan --- This is an automatically generated e-mail. To reply, vis

Re: Review Request: Common Container should log detailed error messages when a gadget fails to navigate or preload

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4738/#review6949 --- Ship it! LGTM - Ryan On 2012-04-16 16:33:28, Stanton Sievers wrote

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

> On 2012-04-12 12:09:52, Ryan Baxter wrote: > > LGTM, have you signed up for Apache/s JIRA deployment? I want to assign > > the JIRA to you and have you upload the final patch to the JIRA granting > > the ASF license before I submit the code. I tried to look for you to

Re: Review Request: Path To JS Servlet Not Passed As Param For Gadgets Of Type URL

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4710/#review6890 --- Ship it! LGTM - Ryan On 2012-04-12 13:34:54, Dan Dumont wrote: >

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

e.org/r/4291/ > --- > > (Updated 2012-04-11 14:55:54) > > > Review request for shindig, Ryan Baxter and li xu. > > > Summary > --- > > Allows multiple gadgets to share a token by binding to an OAuth2Client with > sharedToken=true > > > This addresses b

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

apache.org/r/4680/ > --- > > (Updated 2012-04-12 01:47:45) > > > Review request for shindig, Ryan Baxter, Eric Woods, and Stanton Sievers. > > > Summary > --- > > This is the patch for https://reviews.apache.org/r/3764 as xuli is not > working on it. > @Ryan, I have

Review Request: AbstractLockedDomainService has a protected enabled variable as well as a public isEnabled method

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4698/ --- Review request for shindig, Stanton Sievers and Dan Dumont. Summary --- Abs

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

> On 2012-04-11 13:57:09, Ryan Baxter wrote: > > Forgot to say LGTM - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#r

Re: Review Request: Separate out the different open* APIs into their own features so they can easily be enabled/disabled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#review6845 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

Clarke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4291/ > --- > > (Updated 2012-04-10 13:39:26) > > &g

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

: > https://reviews.apache.org/r/4680/ > --- > > (Updated 2012-04-10 03:17:11) > > > Review request for shindig, Ryan Baxter, Eric Woods, and Stanton Sievers. > > > Summary > --- > > This is the patch for

Re: Review Request: Share OAuth2Token for a user across multiple gadgets

2012-04-09 20:02:38, Adam Clarke wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4291/ > --- > > (Updated 2012-04-09 20:02:38

Re: Review Request: Need to support query parameter for Social REST API (continue li's patch).

-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4680/ > --- > > (Updated 2012-04-09 06:54:36) > > > Review request for shindig, Ryan Baxter,

Re: Question about shindig(java version)

Hi Jiho, thanks for the question. In the future through you want to forward these types of questions to the Shindig Dev list, who I have added to the email thread. You can find a list of all our mailing lists here http://shindig.apache.org/mail-lists.html. Now to your question... I have not pers

Re: Review Request: Buggy behavior with gadgets tests in EndToEndTest.java

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4521/#review6427 --- Ship it! LGTM Evgeny, thanks! Since it is already in, please close t

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-21 01:28:55.978666) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/#review6118 ------- On 2012-03-20 19:45:08, Ryan Baxter wrote: > > --- > This is an au

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-20 19:45:08.315106) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-20 19:43:37.944522) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-20 19:42:02.955058) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

https://reviews.apache.org/r/4284/#review6104 ------- On 2012-03-20 00:24:09, Ryan Baxter wrote: > > --- > This is an automatically generated e-mail

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-20 00:24:09.605030) Review request for shindig. Changes -

Re: Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- (Updated 2012-03-19 18:52:24.861290) Review request for shindig. Changes -

Review Request: MakeRequestHandler and HttpRequestHandler do not use a real gadget when rewriting responses

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4284/ --- Review request for shindig. Summary --- When the MakeRequestHandler or Http

Re: Review Request: Fix for SHINDIG-1736

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4366/#review6070 --- Ship it! LGTM - Ryan On 2012-03-15 17:47:31, Doug Davies wrote: >

Re: Review Request: Cleanup NOTICE and LICENSE files

> On 2012-03-15 00:21:21, Ryan Baxter wrote: > > > > Ryan Baxter wrote: > Oops meant to add some context here before I published :) > > I am OK with these changes, Henry has asked the obvious changes. I am > not really that familiar with some of the im

Re: Review Request: Cleanup NOTICE and LICENSE files

> On 2012-03-15 00:21:21, Ryan Baxter wrote: > > Oops meant to add some context here before I published :) I am OK with these changes, Henry has asked the obvious changes. I am not really that familiar with some of the implications of these changes, so not sure how useful my

Re: Review Request: Cleanup NOTICE and LICENSE files

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3887/#review5976 --- http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/ap

Re: Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4321/#review5933 --- Ship it! LGTM - Ryan On 2012-03-13 20:12:36, Dan Dumont wrote: >

Re: Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

> On 2012-03-13 20:44:46, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js, > > line 312 > > <https://reviews.apache.org/r/4321/diff/2/?file=91789#file91789line312> >

Re: Review Request: gadgets.selection.getSelection() does not return current selection on initial loading of gadget

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5896 --- Ship it! LGTM echo Stanton's question - Ryan On 2012-03-13 18:36:3

Re: Review Request: Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4321/#review5893 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: osapi.container.util.warn causes errors when used in Internet Explorer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/#review5790 --- Ship it! LGTM - Ryan On 2012-03-08 17:30:51, Stanton Sievers wrote

Re: Review Request: Cleanup open view APIs

:58, Ryan Baxter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4077/ > --- > > (Updated 2012-02-28 22:

Re: Review Request: Cleanup open view APIs

------ On 2012-02-28 22:28:58, Ryan Baxter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4077/ > ---

Re: Review Request: Cleanup open view APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4077/ --- (Updated 2012-02-28 22:28:58.031719) Review request for shindig, Henry Saputra,

Re: Review Request: Pass more information into some lifecycle event listeners.

visit: > https://reviews.apache.org/r/4090/ > --- > > (Updated 2012-02-28 20:20:41) > > > Review request for shindig, Ryan Baxter and Stanton Sievers. > > > Summary > --- > > I recently had n

Review Request: Cleanup open view APIs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4077/ --- Review request for shindig, Henry Saputra, Dan Dumont, and Igor Belakovskiy. Sum

Re: Review Request: The RPC abritration code in the common container should allow you to pass in a list of allowed RPC services for that container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3938/ --- (Updated 2012-02-23 20:19:33.079998) Review request for shindig. Changes -

Re: Review Request: The RPC abritration code in the common container should allow you to pass in a list of allowed RPC services for that container

tomatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3938/#review5311 ------- On 2012-02-20 21:48:36, Ryan Baxter wrote: > > --- > This is an au

Re: Review Request: OAuth2 access tokens being removed from OAuth2Store when request returns any 4xx response

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3987/#review5255 --- Ship it! LGTM. This seems reasonable. I took a quick peak at the OA

Re: Review Request: Enable CheckStyle plugin during maven build

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/#review5240 --- Ship it! LGTM should help alot. - Ryan On 2012-02-20 14:14:35, Sta

Re: Review Request: core.log sets the _console var when the javascript is loaded in the page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3936/#review5224 --- Committed revision 1291469. - Ryan On 2012-02-16 21:42:09, Ryan

Re: Review Request: The RPC abritration code in the common container should allow you to pass in a list of allowed RPC services for that container

> pending) > > > > { > > "default" : { > > "gadgets" : { > > "http://www.google.com/ig/modules/horoscope.xml"; : { > > "features" : ["views", "tabs", "setprefs", "dynam

Re: Review Request: The RPC abritration code in the common container should allow you to pass in a list of allowed RPC services for that container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3938/ --- (Updated 2012-02-20 21:48:36.261908) Review request for shindig. Changes -

Re: Review Request: The RPC abritration code in the common container should allow you to pass in a list of allowed RPC services for that container

refs", "dynamic-height"], "type" : "blacklist" }, "rpc" : { "additionalEndpoints" : ["foobar"] } }, "*" : { "rpc" : { "additionalEndpoints"

Review Request: The RPC abritration code in the common container should allow you to pass in a list of allowed RPC services for that container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3938/ --- Review request for shindig. Summary --- If you enable RPC arbitration in a

Review Request: core.log sets the _console var when the javascript is loaded in the page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3936/ --- Review request for shindig. Summary --- In core.log the private _console va

Re: Review Request: Open-Views feature: views opened by gadgets do not always have their resultCallback called.

umont wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3885/ > --- > > (Updated 2012-02-13 22:24:49) > >

Re: Review Request: SHINDIG-1701 Change the action_container.js rpc registration to call the Container.rpcRegister instead directly call gadgets.rpc.register

gt; Review request for shindig, Ryan Baxter and Dan Dumont. > > > Summary > --- > > See jira https://issues.apache.org/jira/browse/SHINDIG-1701 > > > This addresses bug SHINDIG-1701. > https://issues.apache.org/jira/browse/SHINDIG-1701 > > > Dif

Re: Review Request: SHINDIG-1701 Change the action_container.js rpc registration to call the Container.rpcRegister instead directly call gadgets.rpc.register

wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3777/ > --- > > (Updated 2012-02-07 20:41:11) > > > Review request for shindig, Ryan Baxter and Dan Dumont

Re: Review Request: A patch that enables API for updating person data

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3544/#review4862 --- Ship it! Fix the whitespace and you are good to go! - Ryan On 2012

Re: Review Request: Need to support query parameter for Social REST API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3764/#review4854 --- /trunk/java/social-api/src/main/java/org/apache/shindig/social/openso

Re: Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/#review4699 --- Committed revision 1238135. - Ryan On 2012-01-30 15:29:59, Ryan

Re: Review Request: SHINDIG-1686 The gadgets.views.init does not check for the view name if it contains secondary view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3666/#review4691 --- Ship it! LGTM - Ryan On 2012-01-27 22:11:34, Henry Saputra wrote:

Re: Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

n. - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/#review4672 --- On 2012-01-30 15:29:59,

Re: Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/ --- (Updated 2012-01-30 15:29:59.387801) Review request for shindig. Changes -

Re: Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/ --- (Updated 2012-01-28 01:17:22.559949) Review request for shindig. Summary -

Review Request: gadgets.metadata request fails for gadgets that don't have a "default" view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3670/ --- Review request for shindig. Summary --- The request for gadgets.metadata fa

Re: Review Request: Publish global selection into the DataContext of a gadget (if available)

> On 2012-01-27 21:00:21, Ryan Baxter wrote: > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js, > > line 166 > > <https://reviews.apache.org/r/3668/diff/1/?file=71118#file71118line166> > &

Re: Review Request: Publish global selection into the DataContext of a gadget (if available)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3668/#review4658 --- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javas

Re: Review Request: SHINDIG-1678 The flash transport to support RPC for IE7 has problem with multiple gadgets in a single container

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3566/#review4617 --- Ship it! LGTM - Ryan On 2012-01-25 19:57:26, Henry Saputra wrote:

Re: Review Request: A patch that enables API for updating person data

> On 2012-01-20 16:35:55, Stanton Sievers wrote: > > Small nits on whitespace. > > > > I do have some bigger questions regarding the implementation and maybe > > these are more for the spec group. What's to stop one person from updating > > another person? The rest API says that the User-Id

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

lly generated e-mail. To reply, visit: > https://reviews.apache.org/r/3180/ > --- > > (Updated 2012-01-10 20:53:59) > > > Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse > Ciancett

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4265 --- Ship it! Removed extra white space and committed. Thanks Matt! Commi

Re: Review Request: Large refactoring of Shindig caching functionality

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3396/#review4241 --- Paul would it make sense to break this one review up into smaller revi

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4240 --- /trunk/content/samplecontainer/examples/commoncontainer/index.html

Re: Review Request: Add test gadget to the common container sample to test domain configuration

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3334/#review4239 --- Ship it! LGTM - Ryan On 2012-01-03 15:18:36, Stanton Sievers wrote

Re: Review Request: Changing equality checks against undefined to typeof checks against 'undefined'

> On 2012-01-03 08:45:27, Paul Lindner wrote: > > I'm okay with the patch as-is, but would prefer something like this which > > is a modified version of the closure library goog.isDef > > > > > > goog.isDef = function(val) { > > var undefined; > > return val !== undefined; > > }; > > > >

Re: Review Request: Revert SHINDIG-1669

eview4222 --- On 2012-01-06 02:10:55, Ryan Baxter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Review Request: Revert SHINDIG-1669

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3402/ --- Review request for shindig. Summary --- SHINDIG-1669 is not working as expe

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

> On 2011-12-20 14:00:30, Ryan Baxter wrote: > > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, > > line 207 > > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207> > > > > I believe jQuery provides a f

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

> On 2011-12-19 18:23:54, Dan Dumont wrote: > > So far I have 1 vote for splitting the update function into 2 parts (from > > Jesse), and 1 for leaving it as 1 function (from Henry, I think on the dev > > list). > > > > Are there any other opinions on t

Re: Review Request: CommonContainer token refresh changes for a better UX when tokens expire.

14 16:35:00) > > > Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse > Ciancetta, and Stanton Sievers. > > > Summary > --- > > Initial review of 1st change. Allowing common container to manage container > token refreshes. Also, refresh of g

Re: Review Request: Add support for Embedded Experience Gadgets in the CommonContainer test environment

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3165/#review4011 --- Matt there is some good cleanup here, thanks! I am just wondering whe

Re: Review Request: Navigating to URLs in the common container has no indication of success or failure

is is def something to consider for a future enhancement. - Ryan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3037/#review3779 --- On 2011-1

Re: Review Request: Update Open View APIs To Support Opening Of Views At Specific Locations

: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3053/ > --- > > (Updated 2011-12-07 16:53:27) > > > Re

<    2   3   4   5   6   7   8   9   >