[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2015-01-08 Thread caofangkun
Github user caofangkun closed the pull request at: https://github.com/apache/storm/pull/295 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-11-05 Thread ptgoetz
Github user ptgoetz commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61860848 -1 I agree with @HeartSaVioR that if we want an implementation of `ISpoutWaitStrategy` that takes into account the `streak` parameter, it should be a separate imp

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-11-04 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61767078 To make it clear, PR points to "increase/decrease" sleep time with streak. Fixed sleep time is configurable so it doesn't matter how long it is, optimal value shoul

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-11-04 Thread itaifrenkel
Github user itaifrenkel commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61766182 On the one hand - when the spout is a multilang bolt, 1ms drains ~10-5% of a CPU core on aws c3.large, so we increase it to 10ms. On the other hand, increasing the

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-11-04 Thread clockfly
Github user clockfly commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-61634029 To make the whole topology responsive, the spout need to stay active to pull data frequently from acker or system tick. When setting "topology.sleep.spout.wait.st

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-10-24 Thread HeartSaVioR
Github user HeartSaVioR commented on the pull request: https://github.com/apache/storm/pull/295#issuecomment-60460916 @caofangkun It's mk-threads in executor.clj. ``` (if (and (= curr-count (.get emitted-count)) active?) (do (.increment em

[GitHub] storm pull request: STORM-378,SleepSpoutWaitStrategy.emptyEmit sho...

2014-10-15 Thread caofangkun
GitHub user caofangkun opened a pull request: https://github.com/apache/storm/pull/295 STORM-378,SleepSpoutWaitStrategy.emptyEmit should use the variable strea... ...k You can merge this pull request into a Git repository by running: $ git pull https://github.com/caofangkun/apa