Re: [Discuss] Add inline help text with form fields in UI

2015-01-31 Thread Dakshika Jayathilaka
Sure.. This won't take much time to implement. ;) I'm currently working on application adding and deployment. Regards, *Dakshika Jayathilaka* Software Engineer WSO2, Inc. lean.enterprise.middleware 0771100911 On Sun, Feb 1, 2015 at 12:38 PM, Imesh Gunaratne wrote: > A great thought Dakshika!

Re: [Discuss] Add inline help text with form fields in UI

2015-01-31 Thread Imesh Gunaratne
A great thought Dakshika! This will improve the usability of the system dramatically. May be we can focus on this once the main UI features are done, WDYT? Thanks On Sun, Feb 1, 2015 at 11:24 AM, Dakshika Jayathilaka wrote: > Hi Devs, > > As we know stratos new UI contain JSON Schema based form

Re: [Discuss] [Issue] Topology Locks Are Not Created On Demand

2015-01-31 Thread Imesh Gunaratne
Hi Isuru, Thanks for your feedback, yes what you have pointed out is correct. However IMO locks are only there for synchronizing logic against multiple threads. There are not used for validating logic: try { acquireLock(); validateInputs(); executeLogic(); finally { releaseLock(); }

[Discuss] Add inline help text with form fields in UI

2015-01-31 Thread Dakshika Jayathilaka
Hi Devs, As we know stratos new UI contain JSON Schema based form generation logic. JSON schema is supported to have "description" filed for each JSON key. [1] Also some fields generated from JSON needs to have inline help text in order to improve the *User experience. *I can simply embed this wi

Re: [Discuss] [Issue] Topology Locks Are Not Created On Demand

2015-01-31 Thread Isuru Haththotuwa
Hi Imesh, On Sun, Feb 1, 2015 at 9:08 AM, Imesh Gunaratne wrote: > Hi Isuru, > > Let me re-clarify the above point again, IMO when a block of code is > trying to acquire a lock, the lock acquiring process should not fail due to > any reason. The best way to do this is to create lock objects on d

[jira] [Updated] (STRATOS-1169) Implement an Integration Test Server for Executing Automated Integration Tests

2015-01-31 Thread Imesh Gunaratne (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Imesh Gunaratne updated STRATOS-1169: - Fix Version/s: 4.1.0 RC1 > Implement an Integration Test Server for Executing Automated

[jira] [Created] (STRATOS-1169) Implement an Integration Test Server for Executing Automated Integration Tests

2015-01-31 Thread Imesh Gunaratne (JIRA)
Imesh Gunaratne created STRATOS-1169: Summary: Implement an Integration Test Server for Executing Automated Integration Tests Key: STRATOS-1169 URL: https://issues.apache.org/jira/browse/STRATOS-1169

[jira] [Resolved] (STRATOS-1168) Introduce Ability to Switch Messaging Transports and Add Support for AMQP

2015-01-31 Thread Imesh Gunaratne (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Imesh Gunaratne resolved STRATOS-1168. -- Resolution: Fixed Fix Version/s: 4.1.0 RC1 - Introduced above feature, messagin

[jira] [Created] (STRATOS-1168) Introduce Ability to Switch Messaging Transports and Add Support for AMQP

2015-01-31 Thread Imesh Gunaratne (JIRA)
Imesh Gunaratne created STRATOS-1168: Summary: Introduce Ability to Switch Messaging Transports and Add Support for AMQP Key: STRATOS-1168 URL: https://issues.apache.org/jira/browse/STRATOS-1168 P

Re: [Discuss] [Issue] Topology Locks Are Not Created On Demand

2015-01-31 Thread Imesh Gunaratne
Hi Isuru, Let me re-clarify the above point again, IMO when a block of code is trying to acquire a lock, the lock acquiring process should not fail due to any reason. The best way to do this is to create lock objects on demand. Lock object removal process works as it was before, when removing serv

Re: [Discuss] [Issue] Topology Locks Are Not Created On Demand

2015-01-31 Thread Imesh Gunaratne
Hi Isuru, With the latest codebase we can see how it has affected, now due to some reason lock objects are not getting created. As a result the lock acquire calls fail. IMO we need to create lock objects on demand and remove them when relevant topology objects get removed from the system. Thanks

Re: [Discuss] [Issue] Topology Locks Are Not Created On Demand

2015-01-31 Thread Isuru Haththotuwa
Hi Imesh, On Sun, Feb 1, 2015 at 12:06 AM, Imesh Gunaratne wrote: > Hi Devs, > > I see an issue with topology hierarchy locking behaviour. The problem is > that topology lock objects are created at the time services and clusters > are created. IMO this is error prone, now with the latest codebas

[Discuss] [Issue] Topology Locks Are Not Created On Demand

2015-01-31 Thread Imesh Gunaratne
Hi Devs, I see an issue with topology hierarchy locking behaviour. The problem is that topology lock objects are created at the time services and clusters are created. IMO this is error prone, now with the latest codebase I can see error logs saying "topology lock not found". Ideally locks should

[Discuss] Metadata Client Config File Path System Property

2015-01-31 Thread Imesh Gunaratne
Hi Udara, It looks like we have used upper case letters when defining following system property in stratos.sh file, none of the system properties use this convention: -DMETADATA_CLIENT_CONFIG_FILE="$CARBON_HOME /repository/conf/metadataservice.xml" \ Thanks -- Imesh Gunaratne Technical Lead,

[GitHub] stratos pull request: Changing default config file path in ThriftC...

2015-01-31 Thread SupunrWork
GitHub user SupunrWork opened a pull request: https://github.com/apache/stratos/pull/202 Changing default config file path in ThriftClientConfig.java Changed the file path from test config file to default config file path You can merge this pull request into a Git repository by ru

Re: Jenkins build is still unstable: Stratos-Master-Commit-Build #88

2015-01-31 Thread Imesh Gunaratne
Hi Supun, Seems like there is a test failure in the recent pull request you sent. Can you please fix it? Thanks On Sat, Jan 31, 2015 at 10:12 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See > > -- Imesh G

[GitHub] stratos pull request: Modification to Thrift-Client-Configuration

2015-01-31 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/200#discussion_r23890505 --- Diff: components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftClientConfigParser.java --- @@ -0,0 +1,113 @

[GitHub] stratos pull request: Modification to Thrift-Client-Configuration

2015-01-31 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/200#discussion_r23890488 --- Diff: components/org.apache.stratos.common/src/main/java/org/apache/stratos/common/statistics/publisher/ThriftClientConfig.java --- @@ -0,0 +1,88 @@ +

[Discuss] Messaging Now Supports Transports AMQP and MQTT

2015-01-31 Thread Imesh Gunaratne
Hi Devs, I have now introduced support for AMQP in messaging component together with MQTT. To do this I have generalized event publisher and subscriber creation process by introducing factory classes. The main reason for doing this change is that I wanted to implement an automated integration tes

Re: addCartridge operation checks for already deployed cartridges in two places

2015-01-31 Thread Imesh Gunaratne
Yes that's a good suggestion. If we could introduce a generic entity not found exception and catch it in API exception handler we could do it. However this might not be straight forward with Axis2 service stubs, we could give it a try. Thanks On Sat, Jan 31, 2015 at 10:23 PM, Sajith Kariyawasam

Re: addCartridge operation checks for already deployed cartridges in two places

2015-01-31 Thread Sajith Kariyawasam
Well, shouldn't it be like we catch the custom exception in StratosApi (in this case CartridgeAlreadyExistsException), and return the relevant response status code to the end user. Otherwise, we are not make use of those custom exceptions On Sat, Jan 31, 2015 at 9:39 PM, Imesh Gunaratne wrote: >

Re: Instances not spawned in OpenStack

2015-01-31 Thread Imesh Gunaratne
Yes I could see a design issue in the logic which tries to acquire locks in the Topology Manager. The problem is that it does not create lock objects on demand, rather locks are pre-created. As a result there is a possibility of raising following errors/warning if lock object is not found: [2015-0

Re: addCartridge operation checks for already deployed cartridges in two places

2015-01-31 Thread Imesh Gunaratne
IMO we need validations in both places. The reason being that in REST API if we do not check the availability of a resource before executing an operation it may raise a HTTP 500 to the end user as a result of the exception raised by the backend service. Thanks On Sat, Jan 31, 2015 at 5:52 PM, Saj

Re: NPE when deploying application

2015-01-31 Thread Imesh Gunaratne
We need to introduce validations to avoid these errors. Thanks On Sat, Jan 31, 2015 at 2:56 PM, Chamila De Alwis wrote: > Hi, > > I'm getting a NPE when deploying the application in the single-cartridge > sample in OpenStack. The reason is the mismatch of the network partition > names specified

[GitHub] stratos pull request: Modification to Thrift-Client-Configuration

2015-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] stratos pull request: Added new files to parse thrift-client-confi...

2015-01-31 Thread imesh
Github user imesh commented on the pull request: https://github.com/apache/stratos/pull/192#issuecomment-72323492 This pull request was closed since #200 was submitted with corrections. Thanks --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] stratos pull request: Added new files to parse thrift-client-confi...

2015-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] stratos pull request: Modification to Thrift-Client-Configuration

2015-01-31 Thread imesh
Github user imesh commented on the pull request: https://github.com/apache/stratos/pull/200#issuecomment-72323378 Thanks @SupunrWork for the pull request! It looks good! We have now merged this to master branch. --- If your project is set up for it, you can reply to this email and ha

[GitHub] stratos pull request: Modification to Thrift-Client-Configuration

2015-01-31 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/200#discussion_r23889745 --- Diff: products/stratos/conf/data-bridge/thrift-client-config.xml --- @@ -0,0 +1,23 @@ + + + + +test User +test pass +

[GitHub] stratos pull request: Fixing minor typo in the Single Cartridge Op...

2015-01-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Instances not spawned in OpenStack

2015-01-31 Thread Chamila De Alwis
Hi, When testing the single-cartridge sample for OpenStack, there were several occasions of instances not being spawned on the IaaS, without showing any errors on the logs. The log output contains "Application deployed successfully", however there are few warning messages related acquiring the loc

addCartridge operation checks for already deployed cartridges in two places

2015-01-31 Thread Sajith Kariyawasam
Hi Devs, I noted that in addCartridge operation, existing cartridge check is done twice. In StratosApiV41 --> CartridgeBean cartridgeBean = StratosApiV41Utils.getCartridgeForValidate(cartridgeType); Also in CloudcontrollerServiceImpl --> cloudControllerContext.getCartridge(cartridgeType) I thi

[jira] [Updated] (STRATOS-1156) Handling metadata imports & exports in Cartridges

2015-01-31 Thread Gayan Gunarathne (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gayan Gunarathne updated STRATOS-1156: -- Description: Added the "exportmetadata" and "importmetadata" keys to cartridge payload

[jira] [Updated] (STRATOS-1156) Handling metadata imports & exports in Cartridges

2015-01-31 Thread Gayan Gunarathne (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gayan Gunarathne updated STRATOS-1156: -- Issue Type: Task (was: Bug) > Handling metadata imports & exports in Cartridges > ---

[jira] [Updated] (STRATOS-1167) Update permission model in REST API

2015-01-31 Thread Manula Chathurika Thantriwatte (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manula Chathurika Thantriwatte updated STRATOS-1167: Fix Version/s: 4.1.0 RC1 > Update permission model in REST

[jira] [Updated] (STRATOS-1167) Update permission model in REST API

2015-01-31 Thread Manula Chathurika Thantriwatte (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manula Chathurika Thantriwatte updated STRATOS-1167: Component/s: REST API > Update permission model in REST AP

[jira] [Updated] (STRATOS-1167) Update permission model in REST API

2015-01-31 Thread Manula Chathurika Thantriwatte (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manula Chathurika Thantriwatte updated STRATOS-1167: Affects Version/s: 4.1.0 Alpha > Update permission model i

[jira] [Commented] (STRATOS-1167) Update permission model in REST API

2015-01-31 Thread Manula Chathurika Thantriwatte (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299753#comment-14299753 ] Manula Chathurika Thantriwatte commented on STRATOS-1167: - Commi

[jira] [Created] (STRATOS-1167) Update permission model in REST API

2015-01-31 Thread Manula Chathurika Thantriwatte (JIRA)
Manula Chathurika Thantriwatte created STRATOS-1167: --- Summary: Update permission model in REST API Key: STRATOS-1167 URL: https://issues.apache.org/jira/browse/STRATOS-1167 Project: S

[jira] [Created] (STRATOS-1166) Python Cartridge Agent doesn't detect member initialized status

2015-01-31 Thread Chamila de Alwis (JIRA)
Chamila de Alwis created STRATOS-1166: - Summary: Python Cartridge Agent doesn't detect member initialized status Key: STRATOS-1166 URL: https://issues.apache.org/jira/browse/STRATOS-1166 Project:

NPE when deploying application

2015-01-31 Thread Chamila De Alwis
Hi, I'm getting a NPE when deploying the application in the single-cartridge sample in OpenStack. The reason is the mismatch of the network partition names specified in the application deployment. Fixed and opened PR[1]. [2015-01-31 14:17:27,476] ERROR {org.apache.stratos.autoscaler.services.im

[GitHub] stratos pull request: Fixing minor typo in the Single Cartridge Op...

2015-01-31 Thread chamilad
GitHub user chamilad opened a pull request: https://github.com/apache/stratos/pull/201 Fixing minor typo in the Single Cartridge OpenStack sample application deployment This fixes the NPE thrown when running the Single Cartridge OpenStack sample. You can merge this pull request i

[jira] [Created] (STRATOS-1165) Load balancer throws a NPE when shutting down

2015-01-31 Thread Lahiru Sandaruwan (JIRA)
Lahiru Sandaruwan created STRATOS-1165: -- Summary: Load balancer throws a NPE when shutting down Key: STRATOS-1165 URL: https://issues.apache.org/jira/browse/STRATOS-1165 Project: Stratos

[GitHub] stratos pull request: Modification to Thrift-Client-Configuration

2015-01-31 Thread SupunrWork
GitHub user SupunrWork opened a pull request: https://github.com/apache/stratos/pull/200 Modification to Thrift-Client-Configuration Didn't change "user.dir" in ThriftClientConfig.java, since getCarbonHome() returned an null pointer exception. Added a different config file for unit