[GitHub] stratos pull request: Group validation for deployment policies def...

2015-11-29 Thread nirmal070125
Github user nirmal070125 commented on a diff in the pull request: https://github.com/apache/stratos/pull/371#discussion_r46102921 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -1551,14

[GitHub] stratos pull request: Initial GCE commit

2014-11-10 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/92#issuecomment-62513545 Hi Imesh, I expect @suriyapriya to close it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] stratos pull request: Apache cloudstack integration for Stratos

2014-10-28 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/97#issuecomment-60723928 I'd like to review this PR. Await my feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] stratos pull request: Initial GCE commit

2014-10-19 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/92#issuecomment-59654601 Thanks Suriya for the PR. I've merged it! Great work ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] stratos pull request: Fixed issues on docker testing

2014-10-11 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/90#issuecomment-58773746 Merged in 539dc6cf1f5d11ac0ad12b0bbeb13e965625f057 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] stratos pull request: Fixes for error in publishing artifact updat...

2014-10-11 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/87#issuecomment-58753105 Gayan, Could you please rebase and send a new PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] stratos pull request: Python implementation of the Cartridge Agent

2014-10-11 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/88#issuecomment-58748448 Merged this PR in series of commits 6d3855929fb1311fe1a0ae278cb340ac2f676188 - a6f4dfa303838c8ccb7aa7ca4da6dd07eace4292 --- If your project is set up for it, you

[GitHub] stratos pull request: populating member lists after restarting

2014-09-25 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/64#issuecomment-56846605 Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] stratos pull request: Adding the cartridge agent mqtt configuratio...

2014-09-24 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/59#issuecomment-56767177 Merged .. thanks Gayan. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] stratos pull request: Adding tenantId to policies and removing man...

2014-09-24 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/61#issuecomment-56767056 Merged. Thanks Shiro! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] stratos pull request: Docker integration user mgt

2014-09-24 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/38#issuecomment-56657410 This is merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] stratos pull request: Adding changes related to sed -i for mac osx

2014-09-24 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/54#issuecomment-56651324 Pushed this to the docker-integration branch. It'll get merged to master soon. Thanks for the patch! --- If your project is set up for it, you can

[GitHub] stratos pull request: Adding changes related to sed -i for mac osx

2014-09-24 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/54#issuecomment-56644808 Thanks Thushara for investigating further. I'll merge this patch. Thanks . --- If your project is set up for it, you can reply to this email and have your

[GitHub] stratos pull request: Docker integration user mgt

2014-09-23 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/38#issuecomment-56629499 Hi Lasindu, There's a merge conflict at ADCManagementServerComponent class. Please rebase and update the PR. Thanks. --- If your project is set up f

[GitHub] stratos pull request: Fixing Stratos-818 - Error log getting print...

2014-09-23 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/57#issuecomment-56628130 Rebased and merged. Thanks Lasindu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] stratos pull request: Adding changes related to sed -i for mac osx

2014-09-23 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/54#issuecomment-56626278 Hi Thushara, thanks for the PR, did you get a chance to test this in Ubuntu (Linux)? --- If your project is set up for it, you can reply to this email and

[GitHub] stratos pull request: Messaging model changes and MQTT integration

2014-09-23 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/50#issuecomment-56625991 I solved merge conflicts and integrated this PR. Thanks Gayan. However, later found that this PR has introduced a regression https://issues.apache.org/jira

[GitHub] stratos pull request: Mock REST endpoint changes for tenant isolat...

2014-09-14 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/32#issuecomment-1226 PR is merged. Thanks Shiro! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] stratos pull request: Mock REST endpoint changes for tenant isolat...

2014-09-12 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/32#issuecomment-55479983 Hi Shiro, Thanks for the PR. Just to get confirmed, this doesn't break real rest EP right? (I see few changes to beans hence the question.) --- If

[GitHub] stratos pull request: Allows to add a description for policy and p...

2014-09-08 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/24#issuecomment-54920474 Hi Shiro, Thanks for the patch. Can you please check whether the changes done for the AutoscalerService.wsdl is related to the patch? --- If your project

[GitHub] stratos pull request: Removed unused variables in init.sh in puppe...

2014-08-17 Thread nirmal070125
Github user nirmal070125 commented on the pull request: https://github.com/apache/stratos/pull/15#issuecomment-52447801 Hi Chamila, As Dakshika pointed out, this PR seems to have few issues, could you please submit a new PR? --- If your project is set up for it, you can