Re: [Discuss] Error Response JSON Message Construction

2015-02-09 Thread Imesh Gunaratne
Great work Sajith! Thanks for fixing it! On Mon, Feb 9, 2015 at 7:20 AM, Sajith Kariyawasam wrote: > I have fixed this [1] now in commit > 35a2c1d374b590ae5d9b1822533518ec87371364 > > [1] https://issues.apache.org/jira/browse/STRATOS-1181 > > On Fri, Feb 6, 2015 at 4:00 PM, Sajith Kariyawasam >

Re: [Discuss] Error Response JSON Message Construction

2015-02-08 Thread Sajith Kariyawasam
I have fixed this [1] now in commit 35a2c1d374b590ae5d9b1822533518ec87371364 [1] https://issues.apache.org/jira/browse/STRATOS-1181 On Fri, Feb 6, 2015 at 4:00 PM, Sajith Kariyawasam wrote: > Yes Gayan, > In the sample I have used, the errorMessage is the one which comes from > the back end. >

Re: [Discuss] Error Response JSON Message Construction

2015-02-06 Thread Sajith Kariyawasam
Yes Gayan, In the sample I have used, the errorMessage is the one which comes from the back end. There seems to be some issue in propagating the exception messages via service stubs, it doesn't log the proper error message. [This is discussed in "Error log does not contains much information" thread

Re: [Discuss] Error Response JSON Message Construction

2015-02-06 Thread Gayan Gunarathne
IMO we can add descriptive error message to the error as well. Thanks, Gayan On Fri, Feb 6, 2015 at 3:32 PM, Sajith Kariyawasam wrote: > I have done the necessary changes, and being tested locally. Will commit > once fully tested. > > Now the response messages are as follows, > > When there is

Re: [Discuss] Error Response JSON Message Construction

2015-02-06 Thread Sajith Kariyawasam
I have done the necessary changes, and being tested locally. Will commit once fully tested. Now the response messages are as follows, When there is an error : {"errorCode":400,"errorMessage":"CloudControllerServiceCartridgeNotFoundExceptionException"} When operation is successful : {"statusCo

Re: [Discuss] Error Response JSON Message Construction

2015-02-05 Thread Dakshika Jayathilaka
Hi All, Better if we can return meaningful success messages as wel. (Instead of just saying success). Thanks, Regards, *Dakshika Jayathilaka* Software Engineer WSO2, Inc. lean.enterprise.middleware 0771100911 On Thu, Feb 5, 2015 at 5:32 PM, Sajith Kariyawasam wrote: > Hi Imesh, > > yes its b

Re: [Discuss] Error Response JSON Message Construction

2015-02-05 Thread Sajith Kariyawasam
Hi Imesh, yes its better to fix this. I will do the fix Thanks, Sajith On Thu, Feb 5, 2015 at 4:57 PM, Imesh Gunaratne wrote: > Hi Devs, > > Currently we have error response JSON message construction logic in > following class: > > > https://github.com/apache/stratos/blob/master/components/o

[Discuss] Error Response JSON Message Construction

2015-02-05 Thread Imesh Gunaratne
Hi Devs, Currently we have error response JSON message construction logic in following class: https://github.com/apache/stratos/blob/master/components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/Utils.java Here we have used strings to do $subject without using