Re: [Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-22 Thread Imesh Gunaratne
+1 Yes we could expose more API methods in Mock IaaS to make those configurable dynamically. On Fri, May 22, 2015 at 3:22 PM, Reka Thirunavukkarasu wrote: > Hi Isuru, > > It will be good initiative for adding more samples. Can we keep the > mock-iaas.xml and deploy or undeploy or scaleup or scal

Re: [Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-22 Thread Reka Thirunavukkarasu
Hi Isuru, It will be good initiative for adding more samples. Can we keep the mock-iaas.xml and deploy or undeploy or scaleup or scaledown timeout configurable per sample wise? So that we can assert based on the timeout for deploy or undeploy or scaleup or scaledown scenarios where we can calculat

Re: [Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-21 Thread Isuru Haththotuwa
Hi Devs, Did the initial changes and tested locally. This provides the ability to easily write tests for scenarios which are hard to cover by unit tests, due to distributed nature, etc. The initial abstracted API is shown below, which is overriden for artifact specific implementation. However, I

Re: [Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-10 Thread Udara Liyanage
Hi, +1 for generic approach so we can automate any sample without much change. On Mon, May 11, 2015 at 11:55 AM, Isuru Haththotuwa wrote: > Hi Imesh, > > Thanks for the feedback. > > What I tried out is similar to what is there currently; I added a script > for each operation and have it param

Re: [Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-10 Thread Isuru Haththotuwa
Hi Imesh, Thanks for the feedback. What I tried out is similar to what is there currently; I added a script for each operation and have it parameterized to call the relevant file. For an example, in the samples/cartridges-groups directory, there will be scripts for common operations; deploy, und

Re: [Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-10 Thread Imesh Gunaratne
Hi Isuru, +1 for improving the Integration Test Framework with utility methods. Currently we directly invoke the deploy.sh script and it internally deploy cartridges, cartridge groups, policies, etc. How are we planning to do this with the new approach? It would be better if you could send the re

[Discuss] Extending Integration Tests to Support Complex Unit Tests

2015-05-10 Thread Isuru Haththotuwa
Hi Devs, I had a look to see how we can improve the code coverage with unit testing. There are a few challenges for this in Stratos: 1. Operations are not local to a single component - One component calls other to do verifications, etc. Example: deploying a service group; Autoscaler will