[GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread pubudu538
Github user pubudu538 closed the pull request at: https://github.com/apache/stratos/pull/362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread Lahiru Sandaruwan
Hi Pubudu, I have merged the pull request. Thanks. On Wed, May 27, 2015 at 7:17 PM, Rajkumar Rajaratnam wrote: > Thanks a lot Pubudu! > > I reviewed it - it is a cleaner solution now. > > > On Wed, May 27, 2015 at 6:33 PM, Pubudu Gunatilaka > wrote: > >> I changed the files and committed to t

Re: [GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread Rajkumar Rajaratnam
Thanks a lot Pubudu! I reviewed it - it is a cleaner solution now. On Wed, May 27, 2015 at 6:33 PM, Pubudu Gunatilaka wrote: > I changed the files and committed to the same branch. Please review and > merge. > > Thank you! > > On Wed, May 27, 2015 at 4:53 PM, Pubudu Gunatilaka > wrote: > >> T

Re: [GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread Pubudu Gunatilaka
I changed the files and committed to the same branch. Please review and merge. Thank you! On Wed, May 27, 2015 at 4:53 PM, Pubudu Gunatilaka wrote: > The requirement here was to get deployment policies and applications > policies. I will change this to be done at Stratos Manager so that there >

Re: [GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread Pubudu Gunatilaka
The requirement here was to get deployment policies and applications policies. I will change this to be done at Stratos Manager so that there won't be any calls from CC to AS. Thank you! On Wed, May 27, 2015 at 4:40 PM, R-Rajkumar wrote: > Github user R-Rajkumar commented on a diff in the pull

[GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread R-Rajkumar
Github user R-Rajkumar commented on a diff in the pull request: https://github.com/apache/stratos/pull/362#discussion_r31122756 --- Diff: components/org.apache.stratos.cloud.controller/src/main/java/org/apache/stratos/cloud/controller/services/impl/CloudControllerServiceImpl.java ---

Re: [GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread Rajkumar Rajaratnam
Hi Pubudu, Are you calling AS service from CC? We shouldn't do that. The communication should be from AS to CC, not CC to AS. Thanks. On Wed, May 27, 2015 at 4:33 PM, pubudu538 wrote: > GitHub user pubudu538 opened a pull request: > > https://github.com/apache/stratos/pull/362 > > Fixe

[GitHub] stratos pull request: Fixed issues in network partition remove

2015-05-27 Thread pubudu538
GitHub user pubudu538 opened a pull request: https://github.com/apache/stratos/pull/362 Fixed issues in network partition remove Fixed removing network partition when used in deployment policy and application policy validate partition id in network partition changed samples