[GitHub] stratos pull request: Service group validation

2015-05-10 Thread Vishanth
Github user Vishanth commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r30012264 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java --- @@ -441,7 +441,7 @@ public

Re: [GitHub] stratos pull request: Service group validation

2015-05-10 Thread Gayan Gunarathne
On Sat, May 9, 2015 at 10:22 PM, imesh wrote: > Github user imesh commented on a diff in the pull request: > > https://github.com/apache/stratos/pull/296#discussion_r29994291 > > --- Diff: > components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/Str

[GitHub] stratos pull request: Service group validation

2015-05-09 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29994326 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ pub

[GitHub] stratos pull request: Service group validation

2015-05-09 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29994312 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -1188,12 +1180,12 @@ p

[GitHub] stratos pull request: Service group validation

2015-05-09 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29994291 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java --- @@ -441,7 +441,7 @@ public Res

[GitHub] stratos pull request: Service group validation

2015-05-08 Thread Vishanth
Github user Vishanth commented on the pull request: https://github.com/apache/stratos/pull/296#issuecomment-100128106 Hi @imesh, I have made the suggested changes and committed into this PR. Please review again and merge. Regards. --- If your project is set up for it, you can repl

[GitHub] stratos pull request: Service group validation

2015-05-07 Thread Vishanth
Github user Vishanth commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29916979 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@

[GitHub] stratos pull request: Service group validation

2015-05-07 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29845816 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ pub

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread Vishanth
Github user Vishanth commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29827227 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -1188,12 +1180,12 @

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread Vishanth
Github user Vishanth commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29826974 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread lahirus
Github user lahirus commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29763506 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ p

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760927 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -3200,4 +3196,110 @@ p

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760749 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -3200,4 +3196,110 @@ p

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760561 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -1188,12 +1180,12 @@ p

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760431 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ pub

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760316 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ pub

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760203 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ pub

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29760074 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41Utils.java --- @@ -980,50 +981,41 @@ pub

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread imesh
Github user imesh commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29759953 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java --- @@ -453,6 +453,18 @@ public Re

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread Vishanth
Github user Vishanth commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29754947 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java --- @@ -453,6 +453,15 @@ public

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread swgkg
Github user swgkg commented on a diff in the pull request: https://github.com/apache/stratos/pull/296#discussion_r29754432 --- Diff: components/org.apache.stratos.rest.endpoint/src/main/java/org/apache/stratos/rest/endpoint/api/StratosApiV41.java --- @@ -453,6 +453,15 @@ public Re

[GitHub] stratos pull request: Service group validation

2015-05-06 Thread Vishanth
GitHub user Vishanth opened a pull request: https://github.com/apache/stratos/pull/296 Service group validation Added service group validation for checking - duplicate cartridges in the same level - duplicate groups in the same level - cyclic behaviour of groups