Re: API methods for tenants

2015-04-21 Thread Anuruddha Liyanarachchi
Hi, This is done with PR [1]. Please review and merge the pull request. [1] https://github.com/apache/stratos/pull/287 On Tue, Apr 21, 2015 at 12:54 PM, Chamila De Alwis wrote: > Hi Anuruddha, > > I think it's better to cleanup the API class and move them util methods to > Utils class. > > > R

Re: API methods for tenants

2015-04-21 Thread Chamila De Alwis
Hi Anuruddha, I think it's better to cleanup the API class and move them util methods to Utils class. Regards, Chamila de Alwis Software Engineer | WSO2 | +94772207163 Blog: code.chamiladealwis.com On Tue, Apr 21, 2015 at 12:22 PM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi D

Re: API methods for tenants

2015-04-21 Thread Vishanth Balasubramaniam
+1 for moving all those non API methods to Utils class. Regards, Vishanth On Tue, Apr 21, 2015 at 1:29 PM, Imesh Gunaratne wrote: > I do not think there is a reason, +1 for moving them to the > StratosApiV41Utils class. > > Thanks > > On Tue, Apr 21, 2015 at 12:22 PM, Anuruddha Liyanarachchi <

Re: API methods for tenants

2015-04-21 Thread Manula Thantriwatte
Hi Anuruddha, No, at the time we have implemented them we haven't put them to Util class. +1 to re-factor them and add it to Util class. Thanks ! On Tue, Apr 21, 2015 at 2:52 PM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi Devs, > > I have noticed that all the implementation for

Re: API methods for tenants

2015-04-21 Thread Imesh Gunaratne
I do not think there is a reason, +1 for moving them to the StratosApiV41Utils class. Thanks On Tue, Apr 21, 2015 at 12:22 PM, Anuruddha Liyanarachchi < anurudd...@wso2.com> wrote: > Hi Devs, > > I have noticed that all the implementation for Tenant Related API methods > are in the StratosApiV41

API methods for tenants

2015-04-21 Thread Anuruddha Liyanarachchi
Hi Devs, I have noticed that all the implementation for Tenant Related API methods are in the StratosApiV41 class it self. Is there a specific reason that these methods are not added to StratosApiV41Utils class. -- *Thanks and Regards,* Anuruddha Lanka Liyanarachchi Software Engineer - WSO2 Mobi