Re: Creating Topology Locks if the Lock is not Found

2015-04-21 Thread Isuru Haththotuwa
Committed the fix in 1bf3acf00e7a96f57dbce331efbad8f95861aa42. On Tue, Apr 21, 2015 at 8:35 AM, Imesh Gunaratne wrote: > On Sun, Apr 19, 2015 at 5:33 PM, Isuru Haththotuwa > wrote: > >> >> What we can do is to pass an additional flag to getters in [1] to >> indicate force lock re-creation if no

Re: Creating Topology Locks if the Lock is not Found

2015-04-20 Thread Imesh Gunaratne
On Sun, Apr 19, 2015 at 5:33 PM, Isuru Haththotuwa wrote: > > What we can do is to pass an additional flag to getters in [1] to indicate > force lock re-creation if not found. For an example, [2]. For unlock > operations, this flag should be set to false. If the lock is not found, we > currently

Creating Topology Locks if the Lock is not Found

2015-04-19 Thread Isuru Haththotuwa
Hi Devs, We currently do $subject. I observed that we do this when we are acquiring a lock and also releasing a lock (unlocking). IMHO we should not add a new lock object when we are releasing a lock if the lock is not found. If the lock has been already removed from the relevant map, that is an e