Re: Deleting non-existing application returns "Application deleted successfully"

2015-01-05 Thread Shiroshica Kulatilake
On Mon, Jan 5, 2015 at 4:33 PM, Rajkumar Rajaratnam wrote: > Hi, > > Yeah should be 404. Fixed it. > +1 > > Thanks. > > On Mon, Jan 5, 2015 at 3:17 PM, Udara Liyanage wrote: > >> Hi, >> >> Client should get a 404 in this case. >> >> On Mon, Jan 5, 2015 at 3:15 PM, Shiroshica Kulatilake >> wrot

Re: Deleting non-existing application returns "Application deleted successfully"

2015-01-05 Thread Rajkumar Rajaratnam
Hi, Yeah should be 404. Fixed it. Thanks. On Mon, Jan 5, 2015 at 3:17 PM, Udara Liyanage wrote: > Hi, > > Client should get a 404 in this case. > > On Mon, Jan 5, 2015 at 3:15 PM, Shiroshica Kulatilake > wrote: > >> Exception or error ? >> >> On Mon, Jan 5, 2015 at 3:11 PM, Rajkumar Rajaratna

Re: Deleting non-existing application returns "Application deleted successfully"

2015-01-05 Thread Udara Liyanage
Hi, Client should get a 404 in this case. On Mon, Jan 5, 2015 at 3:15 PM, Shiroshica Kulatilake wrote: > Exception or error ? > > On Mon, Jan 5, 2015 at 3:11 PM, Rajkumar Rajaratnam > wrote: > >> Hi Devs, >> >> $Subject in master branch. Should throw and propagate an exception to the >> caller

Re: Deleting non-existing application returns "Application deleted successfully"

2015-01-05 Thread Rajkumar Rajaratnam
Hi, While fixing $Subject, noticed that we are doing two map operations in some of the functions in AutoscalerContext. For example, public ApplicationContext getApplicationContext(String applicationId) { if(applicationContextMap.containsKey(applicationId)) { return applicationContextM

Re: Deleting non-existing application returns "Application deleted successfully"

2015-01-05 Thread Shiroshica Kulatilake
Exception or error ? On Mon, Jan 5, 2015 at 3:11 PM, Rajkumar Rajaratnam wrote: > Hi Devs, > > $Subject in master branch. Should throw and propagate an exception to the > caller. > > I will fix it. > > Thanks. > > -- > Rajkumar Rajaratnam > Committer & PMC Member, Apache Stratos > Software Engin

Deleting non-existing application returns "Application deleted successfully"

2015-01-05 Thread Rajkumar Rajaratnam
Hi Devs, $Subject in master branch. Should throw and propagate an exception to the caller. I will fix it. Thanks. -- Rajkumar Rajaratnam Committer & PMC Member, Apache Stratos Software Engineer, WSO2 Mobile : +94777568639 Blog : rajkumarr.com