Re: Keeping Duplicate config files

2014-08-20 Thread Nirmal Fernando
Does this solve the problem? Isn't the problem we're trying to solve is that people forget to edit the changes in both the places that particular file been used? Even if we use 1 file, still the person who changes that file need to update the installer scripts to add this new change. On Wed, Aug

Re: Keeping Duplicate config files

2014-08-20 Thread Reka Thirunavukkarasu
+1 for Lahiru' suggestion. In that way it will be more consistent. Whoever touches the configuration file in the product, just need to make sure whether the referred XML tags is properly updated in the stratos installer. Thanks, Reka On Wed, Aug 20, 2014 at 12:14 PM, Akila Ravihansa Perera wrot

Re: Keeping Duplicate config files

2014-08-20 Thread chris snow
Stratos running inside docker [1] does not use the stratos installer. At the moment, the docker build copies the config files from tools and uses sed to set the values at runtime. I didn't realise product also contained the config files. I would prefer to just have the config files in product and

Re: Keeping Duplicate config files

2014-08-19 Thread Akila Ravihansa Perera
IMO, we shouldn't replicate config files in stratos-installer. I agree with Lahiru's suggestion. We can keep the XML files in product modules and write to those files by looking up XML tags. We need to get rid of those place holders. On Wed, Aug 20, 2014 at 12:07 PM, Sajith Kariyawasam wrote: > >

Re: Keeping Duplicate config files

2014-08-19 Thread Sajith Kariyawasam
On Wed, Aug 20, 2014 at 12:01 PM, Sajith Kariyawasam wrote: > How about if we keep the config files inside product distribution, and we > write a script in stratos-installer to copy / replace config files from > original location (product distribution) to stratos-installer 's config > directory?

Re: Keeping Duplicate config files

2014-08-19 Thread Sajith Kariyawasam
How about if we keep the config files inside product distribution, and we write a script in stratos-installer to copy / replace config files from original location (product distribution) to stratos-installer 's config directory? On Wed, Aug 20, 2014 at 11:46 AM, Nirmal Fernando wrote: > I think

Re: Keeping Duplicate config files

2014-08-19 Thread Shiroshica Kulatilake
If one set has placeholders then they are ideally not duplicates right ? For exact duplicates would having a git post-commit hook be a solution ? On Wed, Aug 20, 2014 at 11:46 AM, Nirmal Fernando wrote: > I think we have to maintain it in two places otherwise if the file isn't > there in the p

Re: Keeping Duplicate config files

2014-08-19 Thread Nirmal Fernando
I think we have to maintain it in two places otherwise if the file isn't there in the product distribution, product would fail to start and also since we're using place holders in the config files inside the installer, some of those could cause failures when parsing the XML. On Wed, Aug 20, 2014

Re: Keeping Duplicate config files

2014-08-19 Thread Dinesh Bandara
On Wed, Aug 20, 2014 at 11:00 AM, Gayan Gunarathne wrote: > Do we recommend to use the Stratos product build itself without using the > Stratos installer? > yes. If we configure and start stratos manually, that process will not use configuration files which are inside stratos installer. > > If w

Re: Keeping Duplicate config files

2014-08-19 Thread Nirmal Fernando
On Wed, Aug 20, 2014 at 11:00 AM, Gayan Gunarathne wrote: > Do we recommend to use the Stratos product build itself without using the > Stratos installer? > Yes, Gayan, we do. > > If we recommed to use the Stratos installer every time,IMO we can maintain > the config in separately in stratus in

Re: Keeping Duplicate config files

2014-08-19 Thread Gayan Gunarathne
Do we recommend to use the Stratos product build itself without using the Stratos installer? If we recommed to use the Stratos installer every time,IMO we can maintain the config in separately in stratus installer and in setup time we can add them appropriately. Thanks, Gayan On Wed, Aug 20, 20

Re: Keeping Duplicate config files

2014-08-19 Thread Lahiru Sandaruwan
On Wed, Aug 20, 2014 at 10:34 AM, Udara Liyanage wrote: > Hi, > > We have duplicates some product configurations files, one inside product > and one in stratos-installer. At the boot time (when setup.sh is executed) > config files inside products will be replaced by the config files inside > stra

Keeping Duplicate config files

2014-08-19 Thread Udara Liyanage
Hi, We have duplicates some product configurations files, one inside product and one in stratos-installer. At the boot time (when setup.sh is executed) config files inside products will be replaced by the config files inside stratos-installer. Maintaining duplicate config files become an overhead