Re: MQTT client library for Stratos messaging component.

2014-09-25 Thread Nirmal Fernando
I'll remove it Gayan. Thanks. On Thu, Sep 25, 2014 at 9:52 AM, Gayan Gunarathne wrote: > Yeah Nirmal, Seems it mistakenly added.I think we can remove this. > > Thanks, > Gayan > > On Thu, Sep 25, 2014 at 9:26 AM, Nirmal Fernando > wrote: > >> Hi Gayan, >> >> I think we have mistakenly added a g

Re: MQTT client library for Stratos messaging component.

2014-09-24 Thread Gayan Gunarathne
Yeah Nirmal, Seems it mistakenly added.I think we can remove this. Thanks, Gayan On Thu, Sep 25, 2014 at 9:26 AM, Nirmal Fernando wrote: > Hi Gayan, > > I think we have mistakenly added a git sub module > https://github.com/apache/stratos/tree/docker-integration/tools/cartridge_agent > ? Could

Re: MQTT client library for Stratos messaging component.

2014-09-24 Thread Nirmal Fernando
Hi Gayan, I think we have mistakenly added a git sub module https://github.com/apache/stratos/tree/docker-integration/tools/cartridge_agent ? Could you please check? On Wed, Sep 24, 2014 at 4:22 PM, Gayan Gunarathne wrote: > This is resolved. > > Pull request : https://github.com/apache/strato

Re: MQTT client library for Stratos messaging component.

2014-09-24 Thread Gayan Gunarathne
This is resolved. Pull request : https://github.com/apache/stratos/pull/58 Commit ID : d789aa66ca55b9fda0662865fce818c390a4f043 I also updated the JIRA(STRATOS-820 ) Thanks, Gayan On Wed, Sep 24, 2014 at 10:50 AM, Nirmal Fernando wrote: > Lo

Re: MQTT client library for Stratos messaging component.

2014-09-23 Thread Nirmal Fernando
Logged a jira https://issues.apache.org/jira/browse/STRATOS-820 On Wed, Sep 24, 2014 at 10:28 AM, Nirmal Fernando wrote: > Hi Gayan, > > With this PR, I am seen following error at Stratos back-end. I am running > locally built stratos with an activemq. What am I missing? > > [2014-09-24 10:23:56

Re: MQTT client library for Stratos messaging component.

2014-09-23 Thread Nirmal Fernando
Hi Gayan, With this PR, I am seen following error at Stratos back-end. I am running locally built stratos with an activemq. What am I missing? [2014-09-24 10:23:56,924] INFO {org.apache.stratos.manager.publisher.InstanceNotificationPublisher} - Publishing Instance Cleanup Event: [cluster] test2.

Re: MQTT client library for Stratos messaging component.

2014-09-23 Thread Manula Chathurika Thantriwatte
Hi Gayan, +1 for re-format code with new coding standards. I think you can use IntelliJ IDEA reformat code option format the code. On Tue, Sep 23, 2014 at 12:43 PM, Gayan Gunarathne wrote: > Hi Chamila, > > Thanks for sharing this.But this is not resolve the current code > formatting issue as t

Re: MQTT client library for Stratos messaging component.

2014-09-23 Thread Gayan Gunarathne
Hi Chamila, Thanks for sharing this.But this is not resolve the current code formatting issue as those two comparing files has two different formats.Those diff changes happen not only with the white spaces. As a long term solutions to this,shall we re-format our whole java code base into new codi

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Chamila De Alwis
Hi Gayan, May be following tips would help to separate your existing changes in to formatting and business logic without reformatting. [1] deals with removing white space from the changes, but additionally [2], git add -p, allows selecting the sections that need to be staged for a particular commi

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Gayan Gunarathne
What is the code format template are we following previously? This is to revert the code with the previous code format. Thanks, Gayan On Mon, Sep 22, 2014 at 5:03 PM, Isuru Haththotuwa wrote: > > > On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera wrote: > >> Hi Gayan, >> >> IMHO, the formatting s

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Isuru Haththotuwa
On Mon, Sep 22, 2014 at 4:45 PM, Isuru Perera wrote: > Hi Gayan, > > IMHO, the formatting should be done with a different commit. > +1 > The problem is that you have done logic changes along with formatting. I > can't figure out what you changed in the code to support MQTT. > > As a practice, I

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Isuru Perera
Hi Gayan, IMHO, the formatting should be done with a different commit. The problem is that you have done logic changes along with formatting. I can't figure out what you changed in the code to support MQTT. As a practice, I usually try to keep the diff minimum when doing code changes and do forma

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Gayan Gunarathne
Hi Isuru, Yeah.It is formatted according to the discussion[1].In the GIT source comparing window it may show white spaces due to this.Is n't? Please find the following code as it is formatted as the discussion[1]. https://github.com/gayangunarathne/stratos/blob/msgtopichierachchy-1/components/or

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Isuru Perera
Your PR seems to be messed up due to white space changes :( Did you format classes? On Mon, Sep 22, 2014 at 2:39 PM, Gayan Gunarathne wrote: > Hi All, > > I have changed the Stratos messaging model to support MQTT. > > Please find the pull request for this. > > https://github.com/apache/stratos

Re: MQTT client library for Stratos messaging component.

2014-09-22 Thread Gayan Gunarathne
Hi All, I have changed the Stratos messaging model to support MQTT. Please find the pull request for this. https://github.com/apache/stratos/pull/47 Also I have updated the relevant JIRA(STRATOS-791) as well. Thanks, Gayan On Thu, Sep 11, 2014 at 12:58 PM, Gayan Gunarathne wrote: > Hi All

MQTT client library for Stratos messaging component.

2014-09-11 Thread Gayan Gunarathne
Hi All, Based on the discussion[1] and our initial research, we are going to use the following client library for the Stratos MQTT based message component. http://www.eclipse.org/paho/ We have done initial research[2] of the functionality of that library with both java[3] and python[4]. Please