Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-19 Thread Imesh Gunaratne
ev@stratos.apache.org > *Subject:* RE: QUESTION: onApplicationSignUpRemovedEvent in python > cartridge agent compares serivceName with application Id > > > > Thanks Imesh, > > > > I still see an issue in the respective > ApplicationSignUpMes

RE: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-19 Thread Martin Eppel (meppel)
forgot to attach the diff From: Martin Eppel (meppel) Sent: Thursday, February 19, 2015 2:23 PM To: dev@stratos.apache.org Subject: RE: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id Thanks Imesh, I still see an issue in the

RE: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-19 Thread Martin Eppel (meppel)
commit ddd6a1bd6d875d55bf8ca7a98b45160b6185bd6e), please see attached diff file and review, Thanks Martin From: Imesh Gunaratne [mailto:im...@apache.org] Sent: Wednesday, February 18, 2015 7:46 PM To: dev Subject: Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application

Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-18 Thread Imesh Gunaratne
o:gay...@wso2.com] > *Sent:* Tuesday, February 17, 2015 8:53 PM > *To:* dev@stratos.apache.org > *Subject:* Re: QUESTION: onApplicationSignUpRemovedEvent in python > cartridge agent compares serivceName with application Id > > > > Hi Martin, > > > > Thanks for identify tha

RE: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-18 Thread Martin Eppel (meppel)
in python cartridge agent compares serivceName with application Id Hi Martin, Thanks for identify that.It needs to be compare application ID. I have fixed that now. Hi Imesh, That part is didn't test since we have some issue with PCA git repo cloning at that time. But I guess now we ca

Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-17 Thread Gayan Gunarathne
Hi Martin, Thanks for identify that.It needs to be compare application ID. I have fixed that now. Hi Imesh, That part is didn't test since we have some issue with PCA git repo cloning at that time. But I guess now we can do the end to end testing on this. Thanks, Gayan On Wed, Feb 18, 2015 at

RE: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-17 Thread Martin Eppel (meppel)
Thanks Imesh, Will implement the same for the JCA Martin From: Imesh Gunaratne [mailto:im...@apache.org] Sent: Tuesday, February 17, 2015 7:50 PM To: dev; Gayan Gunarathne Subject: Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

Re: QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-17 Thread Imesh Gunaratne
Hi Martin, Thanks for identifying this, yes it seems like a bug. Gayan did we test this? IMO we need to compare the Application ID sent in the Application SignUp Removal event against the Application ID in the payload, then if the tenant's Git repository is already cloned we need to remove it. T

QUESTION: onApplicationSignUpRemovedEvent in python cartridge agent compares serivceName with application Id

2015-02-17 Thread Martin Eppel (meppel)
In extensionhandler.py we compare in "on_application_signup_removal_event" method service_name with applicationId, is this a bug or intentional ? See snippet: def on_application_signup_removal_event(self, application_signup_removal_event): self.log.info( "Tenant unsubscribed