Re: DISCUSS: usage of flags in stratos cli 4.1

2015-03-14 Thread Imesh Gunaratne
lto:im...@apache.org] > *Sent:* Wednesday, March 11, 2015 6:13 PM > > *To:* dev > *Subject:* Re: DISCUSS: usage of flags in stratos cli 4.1 > > > > Hi Martin, > > > > Thanks for the response. Still "cmdOptions" does not sound (at least to > me) as they

RE: DISCUSS: usage of flags in stratos cli 4.1

2015-03-11 Thread Martin Eppel (meppel)
: Wednesday, March 11, 2015 6:13 PM To: dev Subject: Re: DISCUSS: usage of flags in stratos cli 4.1 Hi Martin, Thanks for the response. Still "cmdOptions" does not sound (at least to me) as they are passed by the shell when running the CLI in none interactive mode. For a new developer i

Re: DISCUSS: usage of flags in stratos cli 4.1

2015-03-11 Thread Imesh Gunaratne
> LoggerFactory.getLogger(AddAutoscalingPolicyCommand.class); > > > > private final Options options; > > > > … > > *From:* Imesh Gunaratne [mailto:im...@apache.org] > *Sent:* Tuesday, March 10, 2015 1:08 PM > *To:* dev > *Subject:* Re: DISCUSS: usage

RE: DISCUSS: usage of flags in stratos cli 4.1

2015-03-10 Thread Martin Eppel (meppel)
logger = LoggerFactory.getLogger(AddAutoscalingPolicyCommand.class); private final Options options; … From: Imesh Gunaratne [mailto:im...@apache.org] Sent: Tuesday, March 10, 2015 1:08 PM To: dev Subject: Re: DISCUSS: usage of flags in stratos cli 4.1 Hi Martin, I reviewed your fix and it looks

Re: DISCUSS: usage of flags in stratos cli 4.1

2015-03-10 Thread Imesh Gunaratne
Hi Martin, I reviewed your fix and it looks good. The change you have done to include the options passed by the command line when running the CLI straightaway from the shell is correct. I would like to propose one change: you have named the new argument as "already_parsed_opts": int execute(T co

RE: DISCUSS: usage of flags in stratos cli 4.1

2015-03-09 Thread Martin Eppel (meppel)
I pushed the bug fix in commit 06deaadc63a9756e7701f5173ba00847aec24c4a - please review. Although it seems that currently we are not using any commands with the flag only option it might still prove to be useful in case it will be needed. If you see an issue or concern please feel free to revert