Re: Stick to one practice while logging

Wiki looks good. Should we also have to mention to include "Licensed to the Apache Software Foundation..." comment under "Adding Java doc comments in the IDE" section [1]? [1] - https://cwiki.apache.org/confluence/display/STRATOS/Coding+Standards+and+Best+Practices#CodingStandardsandBestPractices

Re: Stick to one practice while logging

Thanks, Shavindri! Regards, Mariangela *--* Mariangela Hills Senior Technical Writer *WSO2, Inc.* On Wed, Feb 25, 2015 at 11:00 AM, Lahiru Sandaruwan wrote: > Thanks Shavindri. Looks good. > > Thanks. > > On Wed, Feb 25, 2015 at 10:54 AM, Shavindri Dissanayake < > shavin...@wso2.com> wrot

Re: Stick to one practice while logging

Thanks Shavindri. Looks good. Thanks. On Wed, Feb 25, 2015 at 10:54 AM, Shavindri Dissanayake wrote: > Hi Team, > > The suggested content has been documented [1] under Logging. > > [1] > https://cwiki.apache.org/confluence/display/STRATOS/Coding+Standards+and+Best+Practices > [2] https://issues

Re: Stick to one practice while logging

Hi Team, The suggested content has been documented [1] under Logging. [1] https://cwiki.apache.org/confluence/display/STRATOS/Coding+Standards+and+Best+Practices [2] https://issues.apache.org/jira/browse/STRATOS-1212 Thanks & Regards Shavindri Dissanayake Technical Writer LinkedIn Profile

Re: Stick to one practice while logging

+1 Regards, Mariangela *--* Mariangela Hills Senior Technical Writer *WSO2, Inc.*lean.enterprise.middleware. m: +94 773 500185 w: http://wso2.com On Mon, Feb 23, 2015 at 11:37 AM, Lahiru Sandaruwan wrote: > > > On Mon, Feb 23, 2015 at 11:32 AM, Isuru Perera wrote

Re: Stick to one practice while logging

+1 On Mon, Feb 23, 2015 at 7:27 AM, Lahiru Sandaruwan wrote: > Hi all, > > There are lot of different approaches of logging in Stratos code. May be > we can follow same format so that code looks clean and understandable. This > is to decide which way we should follow. > > *1. Separation of objec

Re: Stick to one practice while logging

On Mon, Feb 23, 2015 at 11:50 AM, Chamila De Alwis wrote: > Hi, > > +1 for all these changes. This might be crucial in the usability aspect of > the product. Another irregularity I've seen is the generic nature of a log > entry. If a debug/info entry is there indicating a certain operation is to

Re: Stick to one practice while logging

Hi, +1 for all these changes. This might be crucial in the usability aspect of the product. Another irregularity I've seen is the generic nature of a log entry. If a debug/info entry is there indicating a certain operation is to be done, it should indicate that the operation is *about* to be done

Re: Stick to one practice while logging

On Mon, Feb 23, 2015 at 11:32 AM, Isuru Perera wrote: > Hi, > > I agree with every point except for skipping isInfoEnabled(). I believe we > must use these guard conditions. Some might decide to run Stratos with only > Error/Warn level logs. We might avoid guard conditions for error/fatal > level

Re: Stick to one practice while logging

Hi, I agree with every point except for skipping isInfoEnabled(). I believe we must use these guard conditions. Some might decide to run Stratos with only Error/Warn level logs. We might avoid guard conditions for error/fatal level logs. And use String.format. Always avoid concatenation. String.f

Re: Stick to one practice while logging

+1 Lahiru. Also if you are logging an object, make sure you are overriding toString() method of the class. Otherwise the log is nothing but a garbage. Just got this log on master branch. *Rule executed for: org.apache.stratos.autoscaler.context.partition.ClusterLevelPartitionContext@42c0a4d8* Cl

Stick to one practice while logging

Hi all, There are lot of different approaches of logging in Stratos code. May be we can follow same format so that code looks clean and understandable. This is to decide which way we should follow. *1. Separation of objects* We are using square brackets in most of the places. I think that is a g