RE: key/alias is hardcoded TopologyBuilder

2014-10-06 Thread Martin Eppel (meppel)
+1, absolutely, this a reminiscent from my original POC From: isu...@wso2.com [mailto:isu...@wso2.com] On Behalf Of Isuru Haththotuwa Sent: Sunday, October 05, 2014 9:47 PM To: Reka Thirunavukkarasu Cc: Udara Liyanage; dev; Martin Eppel (meppel) Subject: Re: key/alias is hardcoded TopologyBuilder

Re: key/alias is hardcoded TopologyBuilder

2014-10-05 Thread Isuru Haththotuwa
On Mon, Oct 6, 2014 at 10:10 AM, Reka Thirunavukkarasu wrote: > Hi Udara, > > AFAIK, this is obsolete code segment as of what we are doing now.. > > @Martin/IsuruH/Udara > Shall we remove the code segment that we are not using from grouping > branch? Since we are having sonar integrated, it would

Re: key/alias is hardcoded TopologyBuilder

2014-10-05 Thread Reka Thirunavukkarasu
Hi Udara, AFAIK, this is obsolete code segment as of what we are doing now.. @Martin/IsuruH/Udara Shall we remove the code segment that we are not using from grouping branch? Since we are having sonar integrated, it would be good to execute sonar in our grouping branch too. If we remove the unuse

key/alias is hardcoded TopologyBuilder

2014-10-05 Thread Udara Liyanage
Hi Martin, Noticed that key is hard coded in Topologybuilder.java for some reason or may be some testing purpose. Should n't this be messConfigApp.getAlias(). If so, I can make the change and commit. Could someone confirm whether it is done with purpose or not? 1. try { 2. 3.