Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Johan Corveleyn
On Tue, Jun 8, 2021 at 3:24 PM Stefan Sperling wrote: > > On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan Corveleyn wrote: > > Okay, I focused on the first revision causing the annotate to differ, > > and with some debug logging: > > - p went up to 139 > > - length[0]=1942, length[1]=1817 > > > >

Re: JavaHL: SVNClient.copy throws not very helpful exception

2021-06-08 Thread Karl Fogel
On 08 Jun 2021, Thomas Singer wrote: Hi, A user wanted to copy a working copy to an URL and it fails with following exception: org.apache.subversion.javahl.ClientException: Wrong or unexpected property value svn: Commit failed (details follow): svn: Invalid property value at org.apache.subver

Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Nathan Hartman
On Tue, Jun 8, 2021 at 5:55 AM Stefan Sperling wrote: > > On Tue, Jun 08, 2021 at 01:45:00AM -0400, Nathan Hartman wrote: > > In order to do some testing, I needed some test data that reproduces > > the issue; since stsp can't share the customer's 100MB XML file, and > > we'd probably want other i

Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Stefan Sperling
On Tue, Jun 08, 2021 at 02:57:34PM +0200, Johan Corveleyn wrote: > Okay, I focused on the first revision causing the annotate to differ, > and with some debug logging: > - p went up to 139 > - length[0]=1942, length[1]=1817 > > Now, 1942 lines on the left and 1817 on the right doesn't seem all > t

Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Johan Corveleyn
On Sun, Jun 6, 2021 at 4:57 PM Stefan Sperling wrote: > > On Sat, Jun 05, 2021 at 08:56:24PM +0200, Johan Corveleyn wrote: > > Hmm, I tried this patch with my "annotate large XML file with deep > > history test", but the result isn't the same as with 1.14. I'd have to > > investigate a bit more to

Re: [PATCH] limit diff effort to fix performance issue

2021-06-08 Thread Stefan Sperling
On Tue, Jun 08, 2021 at 01:45:00AM -0400, Nathan Hartman wrote: > In order to do some testing, I needed some test data that reproduces > the issue; since stsp can't share the customer's 100MB XML file, and > we'd probably want other inputs or sizes anyway, I wrote a program > that attempts to gener

JavaHL: SVNClient.copy throws not very helpful exception

2021-06-08 Thread Thomas Singer
Hi, A user wanted to copy a working copy to an URL and it fails with following exception: org.apache.subversion.javahl.ClientException: Wrong or unexpected property value svn: Commit failed (details follow): svn: Invalid property value at org.apache.subversion.javahl.SVNClient.copy(