[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15594279#comment-15594279 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user asfgit closed the pull request

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-tephra/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[jira] [Created] (TEPHRA-195) Store transaction state in HBase

2016-10-20 Thread James Taylor (JIRA)
James Taylor created TEPHRA-195: --- Summary: Store transaction state in HBase Key: TEPHRA-195 URL: https://issues.apache.org/jira/browse/TEPHRA-195 Project: Tephra Issue Type: Improvement

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84390716 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class Transaction

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593458#comment-15593458 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user poornachandra commented on the

[GitHub] incubator-tephra issue #18: [TEPHRA-194] Make startShort() throw IllegalArgu...

2016-10-20 Thread poornachandra
Github user poornachandra commented on the issue: https://github.com/apache/incubator-tephra/pull/18 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593455#comment-15593455 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user anew commented on the issue:

[GitHub] incubator-tephra issue #18: [TEPHRA-194] Make startShort() throw IllegalArgu...

2016-10-20 Thread anew
Github user anew commented on the issue: https://github.com/apache/incubator-tephra/pull/18 @poornachandra I have addressed your comments, please take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84386647 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceThriftClient.java --- @@ -112,7 +113,20 @@ public Transact

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84399721 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class Transaction

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593434#comment-15593434 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user anew commented on a diff in the

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593282#comment-15593282 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user anew commented on a diff in the

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84392263 --- Diff: tephra-core/src/main/java/org/apache/tephra/distributed/TransactionServiceThriftClient.java --- @@ -112,7 +113,20 @@ public Transaction start

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593263#comment-15593263 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user anew commented on a diff in the

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84391234 --- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java --- @@ -124,4 +127,39 @@ protected TransactionSystemClient getCli

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread anew
Github user anew commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84390730 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class Transaction

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593255#comment-15593255 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user anew commented on a diff in the

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593256#comment-15593256 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user anew commented on a diff in the

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593224#comment-15593224 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user poornachandra commented on a di

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84387667 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class Tr

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593222#comment-15593222 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user poornachandra commented on a di

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593223#comment-15593223 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user poornachandra commented on a di

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84388540 --- Diff: tephra-core/src/test/java/org/apache/tephra/ThriftTransactionSystemTest.java --- @@ -124,4 +127,39 @@ protected TransactionSystemClie

[GitHub] incubator-tephra pull request #18: [TEPHRA-194] Make startShort() throw Ille...

2016-10-20 Thread poornachandra
Github user poornachandra commented on a diff in the pull request: https://github.com/apache/incubator-tephra/pull/18#discussion_r84387594 --- Diff: tephra-core/src/test/java/org/apache/tephra/TransactionSystemTest.java --- @@ -33,25 +33,33 @@ */ public abstract class Tr

[jira] [Commented] (TEPHRA-194) Transaction client should not retry startShort() if an invalid timeout is given

2016-10-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TEPHRA-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15593225#comment-15593225 ] ASF GitHub Bot commented on TEPHRA-194: --- Github user poornachandra commented on a di

Re: What's our policy for Thrift changes?

2016-10-20 Thread James Taylor
Hi Andreas, I don't think semantic versioning slows down development. It's just a convention so that your consumers know more of what to expect. Were you thinking of letting consumers know in some other way when wire compatibility breaks? Just release note it (easy to miss)? Or just not letting the