[GitHub] thrift pull request: Update t_cocoa_generator.cc

2014-07-22 Thread kaizhuQin
Github user kaizhuQin commented on the pull request: https://github.com/apache/thrift/pull/162#issuecomment-49815860 Thank you ~ @bufferoverflow But, I still can not finish, How to upgrade automake to the version>1.12 in Centos? I have try many methods , but it do not w

[jira] [Comment Edited] (THRIFT-2621) Add basic default hash code method to python

2014-07-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14071002#comment-14071002 ] Jens Geyer edited comment on THRIFT-2621 at 7/22/14 10:01 PM: -

[jira] [Updated] (THRIFT-2621) Add basic default hash code method to python

2014-07-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-2621: --- Attachment: THRIFT-2621_Add_basic_default_hash_code_method_to_python.patch This is more what I had i

[jira] [Commented] (THRIFT-2626) Apache Thrift needs a simple Style Guide for each language

2014-07-22 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070978#comment-14070978 ] Randy Abernethy commented on THRIFT-2626: - lib/$lang/READEME.md sounds like a gre

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-22 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070919#comment-14070919 ] Jens Geyer commented on THRIFT-2632: {quote} validateForRead() will be called in the

[jira] [Commented] (THRIFT-2626) Apache Thrift needs a simple Style Guide for each language

2014-07-22 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070918#comment-14070918 ] Roger Meier commented on THRIFT-2626: - yes, add very simple rules is worth to do. e.

[GitHub] thrift pull request: Always use bit field or BitSet for isSetXXX

2014-07-22 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/161#issuecomment-49801301 I have issues with the test suite ran by *make check*, could you take care on this? /lib/java/gen-javabean/thrift/test/OneOfEachBeans.java:440: error: cann

Build failed in Jenkins: Thrift-Compiler-Windows #1296

2014-07-22 Thread Apache Jenkins Server
See Changes: [roger] THRIFT-2633 remove 'this is a dummy struct' structs from generated erlang -- Started by an SCM change Building remotely on ubuntu3 (Ubuntu ubuntu) in workspace

Build failed in Jenkins: Thrift #1227

2014-07-22 Thread Apache Jenkins Server
See Changes: [roger] THRIFT-2633 remove 'this is a dummy struct' structs from generated erlang -- [...truncated 95 lines...] compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_gv_generato

[jira] [Commented] (THRIFT-2633) remove 'this is a dummy struct' structs from generated erlang

2014-07-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070860#comment-14070860 ] Hudson commented on THRIFT-2633: FAILURE: Integrated in Thrift #1227 (See [https://build

[GitHub] thrift pull request: Update t_cocoa_generator.cc

2014-07-22 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/162#issuecomment-49795953 @kaizhuQin you need automake > 1.12 and run *sh bootstrap.sh && ./configure* @mfrawley sorry not only pull requests... please check this http://thrift.apac

[jira] [Commented] (THRIFT-2633) remove 'this is a dummy struct' structs from generated erlang

2014-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070827#comment-14070827 ] ASF GitHub Bot commented on THRIFT-2633: Github user talentdeficit closed the pul

[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build

2014-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070825#comment-14070825 ] ASF GitHub Bot commented on THRIFT-1357: Github user talentdeficit closed the pul

[jira] [Commented] (THRIFT-2627) erlang backend doesn't support corecursive structs

2014-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070828#comment-14070828 ] ASF GitHub Bot commented on THRIFT-2627: Github user talentdeficit closed the pul

Re: [VOTE][RESULT] Release Apache Thrift 0.9.2

2014-07-22 Thread Jens Geyer
Hi all, TL;DR: +1 for both variants. Long version: The bad news is that I still experience problems with MinGW on Windows, due to a bug that makes it impossible to build a working bison > 2.4 from the sources. Unfortunately I have to do that, the MinGW repo offers version 2.4.2.1 only. As the

[GitHub] thrift pull request: THRIFT-2633 remove 'this is a dummy struct' s...

2014-07-22 Thread talentdeficit
Github user talentdeficit closed the pull request at: https://github.com/apache/thrift/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-2627:erlang backend doesn't support co...

2014-07-22 Thread talentdeficit
Github user talentdeficit closed the pull request at: https://github.com/apache/thrift/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] thrift pull request: THRIFT-1357:Erlang Dependency breaks build

2014-07-22 Thread talentdeficit
Github user talentdeficit closed the pull request at: https://github.com/apache/thrift/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[jira] [Resolved] (THRIFT-2633) remove 'this is a dummy struct' structs from generated erlang

2014-07-22 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2633. - Resolution: Fixed Assignee: Roger Meier committed! thanks -roger > remove 'this is a dumm

[GitHub] thrift pull request: THRIFT-2633 remove 'this is a dummy struct' s...

2014-07-22 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/160#issuecomment-49794216 please close this, I've just committed. -roger --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[jira] [Commented] (THRIFT-1357) Erlang Dependency breaks build

2014-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-1357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070813#comment-14070813 ] ASF GitHub Bot commented on THRIFT-1357: Github user bufferoverflow commented on

[jira] [Commented] (THRIFT-2627) erlang backend doesn't support corecursive structs

2014-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070812#comment-14070812 ] ASF GitHub Bot commented on THRIFT-2627: Github user bufferoverflow commented on

[GitHub] thrift pull request: THRIFT-1357:Erlang Dependency breaks build

2014-07-22 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/157#issuecomment-49794410 please close, it's committed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] thrift pull request: THRIFT-2627:erlang backend doesn't support co...

2014-07-22 Thread bufferoverflow
Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/158#issuecomment-49794334 please close this pull request, it's merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-2633) remove 'this is a dummy struct' structs from generated erlang

2014-07-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070810#comment-14070810 ] ASF GitHub Bot commented on THRIFT-2633: Github user bufferoverflow commented on

[jira] [Resolved] (THRIFT-2231) Support tornado-3.x (Python)

2014-07-22 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2231. - Resolution: Fixed tcpserver is already used, feel free to reopen this and provide a patch for g

[jira] [Commented] (THRIFT-2631) c_glib: Support service inheritance in clients

2014-07-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070796#comment-14070796 ] Hudson commented on THRIFT-2631: FAILURE: Integrated in Thrift #1226 (See [https://build

[jira] [Resolved] (THRIFT-2631) c_glib: Support service inheritance in clients

2014-07-22 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-2631. - Resolution: Fixed Assignee: Roger Meier Thanks Simon! committed ;-r > c_glib: Support s

Build failed in Jenkins: Thrift #1226

2014-07-22 Thread Apache Jenkins Server
See Changes: [roger] THRIFT-2631 c_glib: Support service inheritance in clients -- [...truncated 95 lines...] compiler/cpp/Makefile.am:34: warning: source file 'src/generate/t_gv_generator.cc' is in a su

Build failed in Jenkins: Thrift-Compiler-Windows #1295

2014-07-22 Thread Apache Jenkins Server
See Changes: [roger] THRIFT-2631 c_glib: Support service inheritance in clients -- [...truncated 421 lines...] lib/c_glib/Makefile.am:35: but option 'subdir-objects' is disabled lib/c_gli

Re: [VOTE][RESULT] Release Apache Thrift 0.9.2

2014-07-22 Thread Roger Meier
Quoting Henrique Mendonça : Hey, I think I would actually prefer releasing the rc0 than the current master. I was talking to Roger and he seems to be OK with the minor issue that lib D won't build with 1.11 We could leave the fixes after rc0 and the dependency to 1.12 to 1.0 and get this rollin

[jira] [Commented] (THRIFT-2621) Add basic default hash code method to python

2014-07-22 Thread Kishor Patil (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14070414#comment-14070414 ] Kishor Patil commented on THRIFT-2621: -- [~jensg] When you get a chance, Can you plea

[GitHub] thrift pull request: Update t_cocoa_generator.cc

2014-07-22 Thread kaizhuQin
Github user kaizhuQin commented on the pull request: https://github.com/apache/thrift/pull/162#issuecomment-49754438 when i install in Centos run `./configure --with-boost=/usr/local` there is a error `config.status: error: cannot find input file: 'Makefile.in'` is ther

[jira] [Resolved] (THRIFT-1442) TNonblockingServer: Refactor to allow multiple IO Threads

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-1442. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 > TN

[jira] [Reopened] (THRIFT-1442) TNonblockingServer: Refactor to allow multiple IO Threads

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça reopened THRIFT-1442: --- > TNonblockingServer: Refactor to allow multiple IO Threads > --

[jira] [Closed] (THRIFT-1544) Create correct Ruby namespace directories

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça closed THRIFT-1544. - > Create correct Ruby namespace directories > - > >

[jira] [Resolved] (THRIFT-1544) Create correct Ruby namespace directories

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-1544. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 > Cr

[jira] [Reopened] (THRIFT-1544) Create correct Ruby namespace directories

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça reopened THRIFT-1544: --- > Create correct Ruby namespace directories > -

[jira] [Resolved] (THRIFT-2058) Add reconnect support to node.js library

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-2058. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 > Ad

[jira] [Reopened] (THRIFT-2058) Add reconnect support to node.js library

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça reopened THRIFT-2058: --- > Add reconnect support to node.js library > >

[jira] [Resolved] (THRIFT-2045) C++ compiler warning and build cleanup

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-2045. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 > C+

[jira] [Resolved] (THRIFT-2165) Thrift Compiler fails at input files with UTF-8 BOM

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-2165. --- Resolution: Fixed Fix Version/s: (was: 1.0) 0.9.2 > Th

[jira] [Reopened] (THRIFT-2069) TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça reopened THRIFT-2069: --- > TPipeServer creates overlapped pipes, then uses synchronous I/O on them with > TPipe

[jira] [Reopened] (THRIFT-2045) C++ compiler warning and build cleanup

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça reopened THRIFT-2045: --- > C++ compiler warning and build cleanup > -- > >

[jira] [Reopened] (THRIFT-2165) Thrift Compiler fails at input files with UTF-8 BOM

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça reopened THRIFT-2165: --- > Thrift Compiler fails at input files with UTF-8 BOM >

[jira] [Updated] (THRIFT-2069) TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2069: -- Affects Version/s: (was: 1.0) 0.9.1 > TPipeServer creates o

[jira] [Updated] (THRIFT-2069) TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2069: -- Fix Version/s: 0.9.2 > TPipeServer creates overlapped pipes, then uses synchronous I/O

[jira] [Resolved] (THRIFT-2069) TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-2069. --- Resolution: Fixed > TPipeServer creates overlapped pipes, then uses synchronous I/O

[jira] [Updated] (THRIFT-2069) TPipeServer creates overlapped pipes, then uses synchronous I/O on them with TPipe

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2069: -- Fix Version/s: (was: 1.0) > TPipeServer creates overlapped pipes, then uses synchr

[jira] [Resolved] (THRIFT-2622) Expecting > 4 bytes, found only 2

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça resolved THRIFT-2622. --- Resolution: Duplicate It looks like a duplicate, could you check if it works after a

[jira] [Updated] (THRIFT-2622) Expecting > 4 bytes, found only 2

2014-07-22 Thread JIRA
[ https://issues.apache.org/jira/browse/THRIFT-2622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrique Mendonça updated THRIFT-2622: -- Component/s: Node.js - Library > Expecting > 4 bytes, found only 2 > -

Re: [VOTE][RESULT] Release Apache Thrift 0.9.2

2014-07-22 Thread Henrique Mendonça
Hey, I think I would actually prefer releasing the rc0 than the current master. I was talking to Roger and he seems to be OK with the minor issue that lib D won't build with 1.11 We could leave the fixes after rc0 and the dependency to 1.12 to 1.0 and get this rolling right now. What do you guys th

[jira] [Commented] (THRIFT-2632) PHP: add "validate" option to generate read/write validation code

2014-07-22 Thread Stig Bakken (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069936#comment-14069936 ] Stig Bakken commented on THRIFT-2632: - Hi Jens, Thanks for the feedback! 1. validat