[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2872:
Description:
I have a TNonblockingServer running with 1 worker thread and 10 IO thread.
If there was a big
2a sounds good to me, since it is consistent. That could be important
for projects that ship thrift files intended for users who want to
build their own clients, for example.
Another discussion could be to catch the same types of issues for
field and enum names. But that is... another discussion :
[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2872:
Description:
I have a TNonblockingServer running with 1 worker thread and 10 IO thread.
If there was a big
[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2872:
Attachment: 0001-Fix-dead-lock-when-all-tasks-are-expired.patch
> ThreadManager deadlock for task expiratio
[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2872:
Attachment: (was: 0002-Fix-dead-lock-when-all-tasks-are-expired.patch)
> ThreadManager deadlock for tas
[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2872:
Description:
I have a TNonblockingServer running with 1 worker thread and 10 IO thread.
If there was a big
[
https://issues.apache.org/jira/browse/THRIFT-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2872:
Attachment: 0002-Fix-dead-lock-when-all-tasks-are-expired.patch
> ThreadManager deadlock for task expiratio
Qiao Mu created THRIFT-2872:
---
Summary: ThreadManager deadlock for task expiration
Key: THRIFT-2872
URL: https://issues.apache.org/jira/browse/THRIFT-2872
Project: Thrift
Issue Type: Bug
C
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232409#comment-14232409
]
ASF GitHub Bot commented on THRIFT-2844:
Github user cameronr closed the pull req
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232408#comment-14232408
]
ASF GitHub Bot commented on THRIFT-2844:
Github user cameronr commented on the pu
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232412#comment-14232412
]
ASF GitHub Bot commented on THRIFT-2844:
Github user cameronr closed the pull req
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232411#comment-14232411
]
ASF GitHub Bot commented on THRIFT-2844:
Github user cameronr commented on the pu
Github user cameronr commented on the pull request:
https://github.com/apache/thrift/pull/287#issuecomment-65335299
merged as part of 878483759c55365ef5da07ad8915e9a8e4af88d9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user cameronr closed the pull request at:
https://github.com/apache/thrift/pull/287
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user cameronr commented on the pull request:
https://github.com/apache/thrift/pull/251#issuecomment-65335108
oh, i'm stupid :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user cameronr closed the pull request at:
https://github.com/apache/thrift/pull/251
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2580:
---
Comment: was deleted
(was: Implemented "good enough" v4 UUID algorithm according to [RFC
4122|http:/
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232304#comment-14232304
]
Jens Geyer edited comment on THRIFT-2580 at 12/2/14 11:46 PM:
-
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2580:
---
Attachment: (was:
THRIFT-2580-COM-ability-for-generated-Delphi-interfa.patch)
> better COM-abili
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232304#comment-14232304
]
Jens Geyer commented on THRIFT-2580:
Implemented "good enough" v4 UUID algorithm acco
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2580:
---
Description:
Consists of two major points:
* reintegrate UUID generation code to add IIDs to genera
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2580:
---
Summary: better COM-ability for generated Delphi interfaces (was: optional
COM-ability for generated
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2580:
---
Fix Version/s: (was: 1.0)
0.9.3
> optional COM-ability for generated Delphi in
[
https://issues.apache.org/jira/browse/THRIFT-2580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2580:
---
Attachment: THRIFT-2580-COM-ability-for-generated-Delphi-interfa.patch
> optional COM-ability for gen
[
https://issues.apache.org/jira/browse/THRIFT-2868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-2868:
--
Assignee: Jens Geyer
> Enhance error handling in the Go client
>
[
https://issues.apache.org/jira/browse/THRIFT-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232105#comment-14232105
]
Hudson commented on THRIFT-2871:
SUCCESS: Integrated in Thrift #1384 (See
[https://build
So most people agree: no aliases (shame ;) )
Soo... I see two potential changes as a result of this discussion:
1. Add i8 for consistency
2. Add dictionary of reserved keywords and validate all type and
variable names against it
a. one global dictionary containing merge of keywords of all
[
https://issues.apache.org/jira/browse/THRIFT-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-2869:
--
Assignee: Jens Geyer
> JSON: run schema validation from tests
> --
[
https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232093#comment-14232093
]
Sergey commented on THRIFT-2789:
Patch that Qiao uploaded will fix the problem. My origin
[
https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232089#comment-14232089
]
Jens Geyer commented on THRIFT-2789:
@[~drigh], what do you think?
> TNonblockingSe
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232088#comment-14232088
]
ASF GitHub Bot commented on THRIFT-2844:
Github user cvlchinet commented on the p
Github user cvlchinet commented on the pull request:
https://github.com/apache/thrift/pull/251#issuecomment-65298557
Usually you should be the one, with closing rights.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If y
[
https://issues.apache.org/jira/browse/THRIFT-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14232084#comment-14232084
]
ASF GitHub Bot commented on THRIFT-2871:
Github user asfgit closed the pull reque
[
https://issues.apache.org/jira/browse/THRIFT-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer reassigned THRIFT-2871:
--
Assignee: Jens Geyer
> Missing semicolon in thrift.js
> --
>
>
[
https://issues.apache.org/jira/browse/THRIFT-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-2871:
---
Priority: Trivial (was: Minor)
> Missing semicolon in thrift.js
> --
>
>
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/300
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/THRIFT-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-2871.
Resolution: Fixed
Committed.
> Missing semicolon in thrift.js
> --
>
>
'long' on most 32-bit platforms is 32-bit. 'long' on Max
and Linux 64-bit is 64-bits, but 'long' on Win64 is 32-bits.
True. Another point against it.
Hi,
Out of curiosity, what kinds of errors did you see from this?
http://stackoverflow.com/questions/27216939/apache-thrift-c-typedef-issue
Not me personally, but I remember having seen a similar question a few weeks
ago. For some reason people seem to like their ints more than i32. It's not
[
https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231951#comment-14231951
]
Jake Farrell commented on THRIFT-2855:
--
yes, NOTICE needs to stay in the root level
[
https://issues.apache.org/jira/browse/THRIFT-2855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231930#comment-14231930
]
Jens Geyer commented on THRIFT-2855:
[NOTICE is special|http://www.apache.org/license
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231816#comment-14231816
]
Cameron Ring commented on THRIFT-2844:
--
awesome, thanks so much!
> Nodejs support b
Chi Vinh Le created THRIFT-2871:
---
Summary: Missing semicolon in thrift.js
Key: THRIFT-2871
URL: https://issues.apache.org/jira/browse/THRIFT-2871
Project: Thrift
Issue Type: Bug
Compo
GitHub user cvlchinet opened a pull request:
https://github.com/apache/thrift/pull/300
nodejs: Missing semicolon in thrift.js
JSHint complains about missing semicolon. Might break older browser
compatibility.
You can merge this pull request into a Git repository by running:
$
[
https://issues.apache.org/jira/browse/THRIFT-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231617#comment-14231617
]
Konrad Grochowski commented on THRIFT-2870:
---
I'll try to look into it later. I'
[
https://issues.apache.org/jira/browse/THRIFT-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Falsig updated THRIFT-2870:
-
Description:
I'm using Thrift for serializing objects (in C++) into JSON strings, which I
then s
[
https://issues.apache.org/jira/browse/THRIFT-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Falsig updated THRIFT-2870:
-
Attachment: use-classic-locale-for-cpp-json_4.patch
I've tried putting together a quick patch (ag
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231569#comment-14231569
]
Chi Vinh Le commented on THRIFT-2844:
-
Thanks to both of you :-)
> Nodejs support br
Simon Falsig created THRIFT-2870:
Summary: C++ TJSONProtocol using locale dependent formatting
Key: THRIFT-2870
URL: https://issues.apache.org/jira/browse/THRIFT-2870
Project: Thrift
Issue Ty
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231527#comment-14231527
]
Hudson commented on THRIFT-2844:
SUCCESS: Integrated in Thrift #1383 (See
[https://build
s/is a service/is a better service/ ;-)
On Tue, Dec 2, 2014 at 3:01 PM, Stig Bakken wrote:
> @Konrad: My point about errors came to mind because I had just been
> working on the JSON generator, where type names are strings. I guess
> it won't apply if the aliases are only present at parse time.
>
@Konrad: My point about errors came to mind because I had just been
working on the JSON generator, where type names are strings. I guess
it won't apply if the aliases are only present at parse time.
However, these vague type definitions from C / Java have been the
cause of a lot of portability hea
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy resolved THRIFT-2844.
-
Resolution: Fixed
committed
> Nodejs support broken when running under Browserify
>
[
https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
saber hattay updated THRIFT-2800:
-
Attachment: ErrorMake.txt
Hello,
My last message was wrong, I have the same matter like the las
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy updated THRIFT-2844:
Attachment: 0001-browserify-update-for-ArrayBuffer.patch
responseType added back (also some
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Randy Abernethy updated THRIFT-2844:
Attachment: (was: 0001-browserify-update-for-ArrayBuffer.patch)
> Nodejs support broken
[
https://issues.apache.org/jira/browse/THRIFT-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231438#comment-14231438
]
Randy Abernethy commented on THRIFT-2844:
-
Hey Cam,
Thanks for the Browserify ed
[
https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231305#comment-14231305
]
Qiao Mu edited comment on THRIFT-2789 at 12/2/14 12:21 PM:
---
Fin
[
https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Qiao Mu updated THRIFT-2789:
Attachment: 0001-Close-connection-when-failed-to-notify-IO-thread.patch
> TNonblockingServer leaks socket F
[
https://issues.apache.org/jira/browse/THRIFT-2789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231305#comment-14231305
]
Qiao Mu commented on THRIFT-2789:
-
Finally I reproduced the issue and fixed it. Sergey wa
[
https://issues.apache.org/jira/browse/THRIFT-2800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
saber hattay updated THRIFT-2800:
-
Attachment: bootstrapShResult.jpg
ConfigureResult.jpg
MakeResult.j
[
https://issues.apache.org/jira/browse/THRIFT-2869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231173#comment-14231173
]
ASF GitHub Bot commented on THRIFT-2869:
GitHub user stigsb opened a pull request
GitHub user stigsb opened a pull request:
https://github.com/apache/thrift/pull/299
Run JSON schema validator from test
This patch makes "make check" test the JSON generator by running a schema
validator on generated files.
Jira: THRIFT-2869
You can merge this pull request int
Stig Bakken created THRIFT-2869:
---
Summary: JSON: run schema validation from tests
Key: THRIFT-2869
URL: https://issues.apache.org/jira/browse/THRIFT-2869
Project: Thrift
Issue Type: Improvement
64 matches
Mail list logo