[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift

2014-12-15 Thread henrique
Github user henrique commented on the pull request: https://github.com/apache/thrift/pull/318#issuecomment-67094076 Great Jake, it looks like it shouldn't be hard to integrate your rb and py cmakelists onto this. I think theses guys are using very good common practices for cmake, f

[GitHub] thrift pull request: Thrift 2850 CMake for Apache Thrift

2014-12-15 Thread jfarrell
Github user jfarrell commented on the pull request: https://github.com/apache/thrift/pull/318#issuecomment-67069087 I started similar work at [1] with a slightly different approach. I dont think that we should reference any autoconf from within cmake or try and work around it, but rat

[jira] [Created] (THRIFT-2893) CMake build fails with boost thread or std thread

2014-12-15 Thread Nobuaki Sukegawa (JIRA)
Nobuaki Sukegawa created THRIFT-2893: Summary: CMake build fails with boost thread or std thread Key: THRIFT-2893 URL: https://issues.apache.org/jira/browse/THRIFT-2893 Project: Thrift Is

[jira] [Commented] (THRIFT-2887) --with-openssl configure flag is ignored

2014-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246868#comment-14246868 ] ASF GitHub Bot commented on THRIFT-2887: Github user jparise commented on the pul

[jira] [Commented] (THRIFT-2887) --with-openssl configure flag is ignored

2014-12-15 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246869#comment-14246869 ] ASF GitHub Bot commented on THRIFT-2887: Github user jparise closed the pull requ

[GitHub] thrift pull request: THRIFT-2887 Respect --with-openssl when build...

2014-12-15 Thread jparise
Github user jparise commented on the pull request: https://github.com/apache/thrift/pull/316#issuecomment-67031649 Merged as a195a2574ef9729da9be65283d29b87e39e8ebcb. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] thrift pull request: THRIFT-2887 Respect --with-openssl when build...

2014-12-15 Thread jparise
Github user jparise closed the pull request at: https://github.com/apache/thrift/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena