[
https://issues.apache.org/jira/browse/THRIFT-1857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504449#comment-14504449
]
ASF GitHub Bot commented on THRIFT-1857:
GitHub user jeroenvlek opened a pull req
GitHub user jeroenvlek opened a pull request:
https://github.com/apache/thrift/pull/455
THRIFT-1857: Added some missing leading periods for the ttypes import
This should fix the ttypes import.
You can merge this pull request into a Git repository by running:
$ git pull https://
[
https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504345#comment-14504345
]
James E. King, III commented on THRIFT-2850:
I have a set of changes that I u
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504106#comment-14504106
]
xiaopeng.he commented on THRIFT-3101:
-
But this cannot avoid the dirty data, such as
[
https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503735#comment-14503735
]
ASF GitHub Bot commented on THRIFT-2640:
Github user jeremy-w commented on the pu
Github user jeremy-w commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94577409
Where possible without changing the protocol bits that are pinned by
codegen, it would be good to address integer width/signedness change issues or
add the appropriate u
[
https://issues.apache.org/jira/browse/THRIFT-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503726#comment-14503726
]
James E. King, III commented on THRIFT-2571:
Proceesing with "static only", I
[
https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503725#comment-14503725
]
ASF GitHub Bot commented on THRIFT-2640:
Github user jeremy-w commented on the pu
Github user jeremy-w commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94576314
In that case, the remaining warnings I'm seeing are mostly implicit sign
conversions and implicit precision loss (integer width narrowing), with a
smattering of "ARC wou
[
https://issues.apache.org/jira/browse/THRIFT-2571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503696#comment-14503696
]
James E. King, III commented on THRIFT-2571:
libevent generates a file called
[
https://issues.apache.org/jira/browse/THRIFT-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503651#comment-14503651
]
Hudson commented on THRIFT-3106:
SUCCESS: Integrated in Thrift #1515 (See
[https://build
[
https://issues.apache.org/jira/browse/THRIFT-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503643#comment-14503643
]
Roger Meier commented on THRIFT-2958:
-
Do you have a patch or test case to reproduce?
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer closed THRIFT-3101.
--
Resolution: Won't Fix
The behaviour (or limitation) you describe is by design. Thrift doesn't allow
{{
Github user Jens-G commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94569429
> > I would like to hear someone elses opinion before I'm going to merge
> A squash-merge is fine by me.
Gtreat, but that wasn't really the question ;-) What I
[
https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503632#comment-14503632
]
ASF GitHub Bot commented on THRIFT-2640:
Github user Jens-G commented on the pull
Github user jeremy-w commented on the pull request:
https://github.com/apache/thrift/pull/442#issuecomment-94568290
A squash-merge is fine by me.
I am happy @creker made many small commits as part of the pull request,
because it is much easier to review. After squash-merging,
[
https://issues.apache.org/jira/browse/THRIFT-2640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503619#comment-14503619
]
ASF GitHub Bot commented on THRIFT-2640:
Github user jeremy-w commented on the pu
[
https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ben Craig closed THRIFT-2119.
-
Resolution: Won't Fix
See other comments. VS2005 is old enough that we don't feel the need to
prioritiz
[
https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503602#comment-14503602
]
Ben Craig commented on THRIFT-2119:
---
I am fine dropping this as well. I will close.
N
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3101:
---
Component/s: Java - Library
> Thrift cannot support the collection whose element is null
> --
[
https://issues.apache.org/jira/browse/THRIFT-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503597#comment-14503597
]
Hudson commented on THRIFT-3103:
SUCCESS: Integrated in Thrift #1514 (See
[https://build
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503596#comment-14503596
]
Hudson commented on THRIFT-3090:
SUCCESS: Integrated in Thrift #1514 (See
[https://build
[
https://issues.apache.org/jira/browse/THRIFT-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503586#comment-14503586
]
Roger Meier commented on THRIFT-2119:
-
I would say VS2005 is gone and we can close th
[
https://issues.apache.org/jira/browse/THRIFT-3106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3106.
-
Resolution: Fixed
Fix Version/s: 0.9.3
Assignee: Pascal Bach
thanks Pascal!
> CM
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/454
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/THRIFT-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3103.
-
Resolution: Fixed
committed
> cmake is missing RPATH on MacOSX
> ---
The simplicity of the multiplexing implementation is attractive, I agree.
It also allows for a lot of flexibility. For now, we can simply use short
service names. In the future, I'm sure we could build something that maps
service names to unique ordinals or short strings.
There's also THRIFT-66
Hint: There is a TProtocolDecorator implementation for all languages
implementing multiplex.
-Ursprüngliche Nachricht-
From: David Shoemaker
Sent: Monday, April 20, 2015 7:49 PM
To: dev@thrift.apache.org
Subject: Re: method names sent as strings
Ben,
That is a clever idea! I'm a l
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roger Meier resolved THRIFT-3090.
-
Resolution: Fixed
committed
> cmake build is broken on MacOSX
> ---
[
https://issues.apache.org/jira/browse/THRIFT-2958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503413#comment-14503413
]
Richard Dawe commented on THRIFT-2958:
--
http://www.madore.org/~david/computers/conne
[
https://issues.apache.org/jira/browse/THRIFT-3090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503378#comment-14503378
]
Marco Molteni commented on THRIFT-3090:
---
ping :-)
> cmake build is broken on MacOS
[
https://issues.apache.org/jira/browse/THRIFT-3103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503377#comment-14503377
]
Marco Molteni commented on THRIFT-3103:
---
ping :-)
> cmake is missing RPATH on MacO
Ben,
That is a clever idea! I'm a little hesitant to take that approach, because
we'd have to implement it for each language that we use, and the ordinals
would have to be in code for each of these languages. I'll explore how we
might encode that data in the IDL somehow so that each language
imple
Thanks for your reply, Randy! Responses inline below.
On Sun, Apr 19, 2015 at 4:05 PM, Randy Abernethy
wrote:
>
>
>
> I can’t speak to the original motivations, but one view on the methods
> front might be that method ordinals would be a little more prone to
> collisions than method names in scen
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502980#comment-14502980
]
xiaopeng.he commented on THRIFT-3101:
-
I had attach a file, please check. Thanks!
>
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502978#comment-14502978
]
xiaopeng.he commented on THRIFT-3101:
-
I had attach a file, please check. Thanks!
>
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaopeng.he updated THRIFT-3101:
Attachment: thrift-test.zip
> Thrift cannot support the collection whose element is null
>
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502979#comment-14502979
]
xiaopeng.he commented on THRIFT-3101:
-
I had attach a file, please check. Thanks!
>
[
https://issues.apache.org/jira/browse/THRIFT-3101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
xiaopeng.he updated THRIFT-3101:
Comment: was deleted
(was: I had attach a file, please check. Thanks!)
> Thrift cannot support the
David,
If you method ordinals today, without changing the generator, and without
even changing Apache Thrift source, you can hack it at the protocol level.
Inherit from your protocol of choice, and then override readMessageBegin
and writeMessageBegin, and you can translate from the code generat
[
https://issues.apache.org/jira/browse/THRIFT-2817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14502461#comment-14502461
]
ASF GitHub Bot commented on THRIFT-2817:
Github user bivas commented on the pull
Github user bivas commented on the pull request:
https://github.com/apache/thrift/pull/273#issuecomment-94379082
@Jens-G unfortunately, no. Was pointing this out so maybe @wingedkiwi can
have a quick look (and maybe a fix) on this issue.
---
If your project is set up for it, you can
42 matches
Mail list logo
