[jira] [Closed] (THRIFT-3216) Build Failures on OSX 10.10.3

2015-07-01 Thread danem (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] danem closed THRIFT-3216. - Resolution: Fixed Found out that I was missing flag to specify c++11 > Build Failures on OSX 10.10.3 > -

[jira] [Updated] (THRIFT-3216) Build Failures on OSX 10.10.3

2015-07-01 Thread danem (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] danem updated THRIFT-3216: -- Description: I cannot successfully build a project using Thrift or build Thrift itself from source. When try

[jira] [Created] (THRIFT-3217) Provide a little endian variant of the binary protocol in C++

2015-07-01 Thread Ben Craig (JIRA)
Ben Craig created THRIFT-3217: - Summary: Provide a little endian variant of the binary protocol in C++ Key: THRIFT-3217 URL: https://issues.apache.org/jira/browse/THRIFT-3217 Project: Thrift Iss

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611264#comment-14611264 ] ASF GitHub Bot commented on THRIFT-2850: GitHub user ben-craig reopened a pull re

[GitHub] thrift pull request: THRIFT-2850: Fix some Windows CMake issues

2015-07-01 Thread ben-craig
GitHub user ben-craig reopened a pull request: https://github.com/apache/thrift/pull/534 THRIFT-2850: Fix some Windows CMake issues Some issues that are fixed here: * Removed some files from the build that do nothing except for cause warnings on Windows (VirtualProfiling.cpp and

[jira] [Commented] (THRIFT-2850) CMake for Apache Thrift

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611263#comment-14611263 ] ASF GitHub Bot commented on THRIFT-2850: Github user ben-craig closed the pull re

[GitHub] thrift pull request: THRIFT-2850: Fix some Windows CMake issues

2015-07-01 Thread ben-craig
Github user ben-craig closed the pull request at: https://github.com/apache/thrift/pull/534 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[jira] [Commented] (THRIFT-3214) Add Erlang option for using maps instead of dicts

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611068#comment-14611068 ] ASF GitHub Bot commented on THRIFT-3214: Github user thecodeboss commented on a d

[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-07-01 Thread thecodeboss
Github user thecodeboss commented on a diff in the pull request: https://github.com/apache/thrift/pull/535#discussion_r33730165 --- Diff: compiler/cpp/src/generate/t_erl_generator.cc --- @@ -55,6 +55,7 @@ class t_erl_generator : public t_generator { out_dir_base_ = "gen-erl

[jira] [Commented] (THRIFT-3214) Add Erlang option for using maps instead of dicts

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611058#comment-14611058 ] ASF GitHub Bot commented on THRIFT-3214: Github user jparise commented on a diff

[GitHub] thrift pull request: THRIFT-3214 Add Erlang option for using maps ...

2015-07-01 Thread jparise
Github user jparise commented on a diff in the pull request: https://github.com/apache/thrift/pull/535#discussion_r33729457 --- Diff: compiler/cpp/src/generate/t_erl_generator.cc --- @@ -55,6 +55,7 @@ class t_erl_generator : public t_generator { out_dir_base_ = "gen-erl";

[jira] [Created] (THRIFT-3216) Build Failures on OSX 10.10.3

2015-07-01 Thread danem (JIRA)
danem created THRIFT-3216: - Summary: Build Failures on OSX 10.10.3 Key: THRIFT-3216 URL: https://issues.apache.org/jira/browse/THRIFT-3216 Project: Thrift Issue Type: Bug Components: C++ -

[jira] [Commented] (THRIFT-3214) Add Erlang option for using maps instead of dicts

2015-07-01 Thread Michael Oliver (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14611041#comment-14611041 ] Michael Oliver commented on THRIFT-3214: Thanks for the comments, I have moved th

[jira] [Comment Edited] (THRIFT-3214) Add Erlang option for using maps instead of dicts

2015-07-01 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610949#comment-14610949 ] Jens Geyer edited comment on THRIFT-3214 at 7/1/15 8:24 PM: T

[jira] [Commented] (THRIFT-3214) Add Erlang option for using maps instead of dicts

2015-07-01 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610949#comment-14610949 ] Jens Geyer commented on THRIFT-3214: Could ypou move the test into {{/lib/erl/test}}

[jira] [Commented] (THRIFT-3211) Add make cross support for php TCompactProtocol

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610511#comment-14610511 ] ASF GitHub Bot commented on THRIFT-3211: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-3211: add php client compact protocol ...

2015-07-01 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/532#issuecomment-117724639 The "make cross" travis job is passing now, however another job failed for reasons I cannot tell, so I merged with master to see if this was something that someone else

[jira] [Commented] (THRIFT-3211) Add make cross support for php TCompactProtocol

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610343#comment-14610343 ] ASF GitHub Bot commented on THRIFT-3211: Github user jeking3 commented on a diff

[GitHub] thrift pull request: THRIFT-3211: add php client compact protocol ...

2015-07-01 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/532#discussion_r33682913 --- Diff: test/tests.json --- @@ -332,7 +332,9 @@ "ip" ], "protocols": [ -"binary" +"binary", +

[jira] [Commented] (THRIFT-3211) Add make cross support for php TCompactProtocol

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610295#comment-14610295 ] ASF GitHub Bot commented on THRIFT-3211: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-3211: add php client compact protocol ...

2015-07-01 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/532#issuecomment-117689123 Given the rather large set of known failing tests, we should have Jira items tracking each language to language test failure. I'm concerned these are somewhat accepted

[jira] [Commented] (THRIFT-3213) make cross should indicate when it skips a known failing test

2015-07-01 Thread Nobuaki Sukegawa (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610256#comment-14610256 ] Nobuaki Sukegawa commented on THRIFT-3213: -- {quote} Ideally I would like to see

[GitHub] thrift pull request: THRIFT-3215 Replaces "throw new" in TJSONProt...

2015-07-01 Thread cmhe
GitHub user cmhe opened a pull request: https://github.com/apache/thrift/pull/536 THRIFT-3215 Replaces "throw new" in TJSONProtocol with a normal "throw" Sponsored-by: Roger Meier Signed-off-by: Claudius Heine You can merge this pull request into a Git repository by running:

[jira] [Commented] (THRIFT-3215) TJSONProtocol '(c++) uses "throw new" to throw exceptions instead of "throw"

2015-07-01 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14610047#comment-14610047 ] ASF GitHub Bot commented on THRIFT-3215: GitHub user cmhe opened a pull request:

[jira] [Created] (THRIFT-3215) TJSONProtocol '(c++) uses "throw new" to throw exceptions instead of "throw"

2015-07-01 Thread Claudius Heine (JIRA)
Claudius Heine created THRIFT-3215: -- Summary: TJSONProtocol '(c++) uses "throw new" to throw exceptions instead of "throw" Key: THRIFT-3215 URL: https://issues.apache.org/jira/browse/THRIFT-3215 Proj

AW: [jira] [Created] (THRIFT-3213) make cross is not testing every possible combination

2015-07-01 Thread Jens Geyer
Why is that a blocker? Von: James E. King, III (JIRA) Gesendet: 30.06.2015 22:41 An: dev@thrift.apache.org Betreff: [jira] [Created] (THRIFT-3213) make cross is not testing every possible combination James E. King, III created THRIFT-3213: