Github user phongphan commented on the pull request:
https://github.com/apache/thrift/pull/658#issuecomment-149763148
Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965857#comment-14965857
]
Hudson commented on THRIFT-3393:
SUCCESS: Integrated in Thrift #1694 (See
[https://build
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3393.
Resolution: Fixed
Fix Version/s: 1.0
Committed.
> Introduce i8 to provide consistent set of
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965793#comment-14965793
]
ASF GitHub Bot commented on THRIFT-3393:
Github user asfgit closed the pull reque
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965728#comment-14965728
]
Jens Geyer commented on THRIFT-3393:
I updated the PR accordingly. I ended up with ma
[
https://issues.apache.org/jira/browse/THRIFT-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965708#comment-14965708
]
Hudson commented on THRIFT-3396:
SUCCESS: Integrated in Thrift #1693 (See
[https://build
[
https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965668#comment-14965668
]
Roger Meier commented on THRIFT-3385:
-
I would say that's it...
> warning: format ‘%
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965660#comment-14965660
]
ASF GitHub Bot commented on THRIFT-3393:
Github user Jens-G commented on a diff i
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42545542
--- Diff: test/ThriftTest.thrift ---
@@ -86,7 +86,7 @@ struct Xtruct
struct Xtruct2
{
- 1: byte byte_thing,
+ 1: i8 byte_thing,
[
https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965655#comment-14965655
]
Jens Geyer commented on THRIFT-3385:
Not sure, but could it be related to the fact th
[
https://issues.apache.org/jira/browse/THRIFT-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer resolved THRIFT-3396.
Resolution: Fixed
Fix Version/s: 1.0
Committed, thanks!
> DART: UTF-8 sent by PHP as JSON i
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/658
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
[
https://issues.apache.org/jira/browse/THRIFT-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-3396:
---
Assignee: Phongphan Phuttha
> DART: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol
> --
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/658#discussion_r42543775
--- Diff: lib/dart/lib/src/protocol/t_json_protocol.dart ---
@@ -321,12 +327,36 @@ class TJsonProtocol extends TProtocol {
continue;
}
[
https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965631#comment-14965631
]
Roger Meier commented on THRIFT-3385:
-
I cannot reproduce that by using gcc 4.9.2 on
[
https://issues.apache.org/jira/browse/THRIFT-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965627#comment-14965627
]
Jens Geyer commented on THRIFT-3396:
GitHub user phongphan opened a pull request:
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965625#comment-14965625
]
Konrad Grochowski commented on THRIFT-3393:
---
+1
> Introduce i8 to provide con
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42542836
--- Diff: test/ThriftTest.thrift ---
@@ -86,7 +86,7 @@ struct Xtruct
struct Xtruct2
{
- 1: byte byte_thing,
+ 1: i8 byte_thing,
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965623#comment-14965623
]
ASF GitHub Bot commented on THRIFT-3393:
Github user hcorg commented on a diff in
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965624#comment-14965624
]
ASF GitHub Bot commented on THRIFT-3393:
Github user hcorg commented on a diff in
Github user hcorg commented on a diff in the pull request:
https://github.com/apache/thrift/pull/656#discussion_r42542828
--- Diff: compiler/cpp/src/thriftl.ll ---
@@ -155,7 +155,8 @@ literal_begin (['\"])
"include"{ return tok_include; }
"void"
[
https://issues.apache.org/jira/browse/THRIFT-3393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965590#comment-14965590
]
Roger Meier commented on THRIFT-3393:
-
+1, great stuff Jens!
> Introduce i8 to provi
[
https://issues.apache.org/jira/browse/THRIFT-3396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14965406#comment-14965406
]
ASF GitHub Bot commented on THRIFT-3396:
Github user phongphan commented on the p
Github user phongphan commented on the pull request:
https://github.com/apache/thrift/pull/658#issuecomment-149635862
Hi @nsuke,
Thanks, created at
[THRIFT-3396](https://issues.apache.org/jira/browse/THRIFT-3396).
---
If your project is set up for it, you can reply to this email
Phongphan Phuttha created THRIFT-3396:
-
Summary: DART: UTF-8 sent by PHP as JSON is not understood by
TJsonProtocol
Key: THRIFT-3396
URL: https://issues.apache.org/jira/browse/THRIFT-3396
Project:
Github user nsuke commented on the pull request:
https://github.com/apache/thrift/pull/658#issuecomment-149628493
Hello @phongphan , thanks for the patch, would you mind creating a JIRA
ticket for this ?
http://thrift.apache.org/docs/HowToContribute
---
If your project is set up
GitHub user phongphan opened a pull request:
https://github.com/apache/thrift/pull/658
DART: Allow decode JSON escaped unicode string.
Hi
This patch allow Dart's json protocol to be able to comsume escaped unicode
string (\u). To make the `readString` test runnable, I h
28 matches
Mail list logo
