[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009811#comment-15009811 ] Hudson commented on THRIFT-3385: SUCCESS: Integrated in Thrift #1733 (See [https://build

[jira] [Resolved] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3385. Resolution: Fixed Assignee: Jens Geyer Fix Version/s: 1.0 Committted my [patch|^TH

[jira] [Commented] (THRIFT-3388) hash doesn't work on set/list

[ https://issues.apache.org/jira/browse/THRIFT-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009792#comment-15009792 ] Jens Geyer commented on THRIFT-3388: I really would like to give you a more satisfyin

[jira] [Commented] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009779#comment-15009779 ] Jens Geyer commented on THRIFT-3362: No. Again, all other tests run fine. It's only t

[jira] [Updated] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3385: --- Attachment: THRIFT-3385-warning-format-lu-expects-long-unsigned-.patch > warning: format ‘%lu’ expect

[jira] [Commented] (THRIFT-3388) hash doesn't work on set/list

[ https://issues.apache.org/jira/browse/THRIFT-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009696#comment-15009696 ] Tejal Desai commented on THRIFT-3388: - Thank you! Same question as [~jsirois] > has

[jira] [Commented] (THRIFT-3388) hash doesn't work on set/list

[ https://issues.apache.org/jira/browse/THRIFT-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009627#comment-15009627 ] Hudson commented on THRIFT-3388: SUCCESS: Integrated in Thrift #1732 (See [https://build

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009607#comment-15009607 ] Jens Geyer commented on THRIFT-3385: I tend to agree with that approach. Very much, a

[jira] [Comment Edited] (THRIFT-3405) Go THttpClient misuses http.Client objects

[ https://issues.apache.org/jira/browse/THRIFT-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009603#comment-15009603 ] Jens Geyer edited comment on THRIFT-3405 at 11/17/15 9:47 PM: -

[jira] [Resolved] (THRIFT-3405) Go THttpClient misuses http.Client objects

[ https://issues.apache.org/jira/browse/THRIFT-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3405. Resolution: Fixed Assignee: Justin Larrabee Fix Version/s: 1.0 Committed, thanbs!

[jira] [Commented] (THRIFT-3388) hash doesn't work on set/list

[ https://issues.apache.org/jira/browse/THRIFT-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009596#comment-15009596 ] John Sirois commented on THRIFT-3388: - Thank you [~jensg]! Does 1.0 have a vague ti

[jira] [Commented] (THRIFT-3228) Fix TAutoOverlapThread may reference released memory

[ https://issues.apache.org/jira/browse/THRIFT-3228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009578#comment-15009578 ] James E. King, III commented on THRIFT-3228: Couldn't a boost::mutex be used

[jira] [Commented] (THRIFT-3238) Fix TNamedPipeServer can be interrupted by faulty client

[ https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009556#comment-15009556 ] James E. King, III commented on THRIFT-3238: Can you describe the observable

[jira] [Resolved] (THRIFT-3388) hash doesn't work on set/list

[ https://issues.apache.org/jira/browse/THRIFT-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-3388. Resolution: Fixed Assignee: Jens Geyer Fix Version/s: 1.0 Committed the patch above

[jira] [Updated] (THRIFT-3388) hash doesn't work on set/list

[ https://issues.apache.org/jira/browse/THRIFT-3388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3388: --- Attachment: THRIFT-3388-hash-doesn-t-work-on-set-list.patch > hash doesn't work on set/list > ---

[jira] [Commented] (THRIFT-3405) Go THttpClient misuses http.Client objects

[ https://issues.apache.org/jira/browse/THRIFT-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009294#comment-15009294 ] ASF GitHub Bot commented on THRIFT-3405: Github user justonia commented on the pu

[GitHub] thrift pull request: THRIFT-3405

Github user justonia commented on the pull request: https://github.com/apache/thrift/pull/701#issuecomment-157474702 The CI failure does not seem related to my changes... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (THRIFT-3405) Go THttpClient misuses http.Client objects

[ https://issues.apache.org/jira/browse/THRIFT-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009202#comment-15009202 ] ASF GitHub Bot commented on THRIFT-3405: Github user justonia commented on the pu

[GitHub] thrift pull request: THRIFT-3405

Github user justonia commented on the pull request: https://github.com/apache/thrift/pull/701#issuecomment-157462815 I also forgot to mention that all changes are additive and do not change the existing public API. --- If your project is set up for it, you can reply to this email and

[jira] [Commented] (THRIFT-3405) Go THttpClient misuses http.Client objects

[ https://issues.apache.org/jira/browse/THRIFT-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009195#comment-15009195 ] ASF GitHub Bot commented on THRIFT-3405: GitHub user justonia opened a pull reque

[GitHub] thrift pull request: THRIFT-3405

GitHub user justonia opened a pull request: https://github.com/apache/thrift/pull/701 THRIFT-3405 Implementation for THttpClient as referenced by: https://issues.apache.org/jira/browse/THRIFT-3405 Some lines within the RemainingBytes() method were changed as a resul

[jira] [Commented] (THRIFT-3418) Use of ciphers in ssl.wrap_socket() breaks python 2.6 compatibility

[ https://issues.apache.org/jira/browse/THRIFT-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15009174#comment-15009174 ] Uri Laserson commented on THRIFT-3418: -- Gotcha. I think lots of Hadoop deployments

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008921#comment-15008921 ] ASF GitHub Bot commented on THRIFT-3385: Github user hcorg commented on a diff in

[GitHub] thrift pull request: THRIFT-3385 warning: format ‘%lu’ expects...

Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/688#discussion_r45079568 --- Diff: test/cpp/src/TestClient.cpp --- @@ -488,7 +488,7 @@ int main(int argc, char** argv) { testClient.testBinary(bin_result, string(bin_data, 256

[jira] [Updated] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3385: --- Priority: Minor (was: Major) > warning: format ‘%lu’ expects ‘long unsigned int’, bu

[jira] [Commented] (THRIFT-3362) make check fails for C++ at the SecurityTest

[ https://issues.apache.org/jira/browse/THRIFT-3362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008828#comment-15008828 ] James E. King, III commented on THRIFT-3362: Perhaps the test port should be

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

Github user MartinHaimberger commented on the pull request: https://github.com/apache/thrift/pull/690#issuecomment-157402412 @jeking3 i will also implement the TSSLSocketInterruptTest --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008821#comment-15008821 ] ASF GitHub Bot commented on THRIFT-3385: Github user jeking3 commented on a diff

[GitHub] thrift pull request: THRIFT-3385 warning: format ‘%lu’ expects...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/688#discussion_r45072155 --- Diff: test/cpp/src/TestClient.cpp --- @@ -488,7 +488,7 @@ int main(int argc, char** argv) { testClient.testBinary(bin_result, string(bin_data, 2

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

Github user MartinHaimberger commented on a diff in the pull request: https://github.com/apache/thrift/pull/690#discussion_r45071978 --- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp --- @@ -659,6 +659,10 @@ shared_ptr TServerSocket::createSocket(THRIFT_SOCKET clientSocket)

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/690#issuecomment-157401129 I think the only concern I would have relative to this is that I don't see a test that exercises the new code. There are tests that exercise all of the interrupt code p

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/690#discussion_r45071550 --- Diff: lib/cpp/src/thrift/transport/TServerSocket.cpp --- @@ -659,6 +659,10 @@ shared_ptr TServerSocket::createSocket(THRIFT_SOCKET clientSocket) {

[GitHub] thrift pull request: C++ transport: implement interruptable TSSLSo...

Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/690#discussion_r45070910 --- Diff: lib/cpp/src/thrift/transport/TSSLServerSocket.cpp --- @@ -48,7 +48,12 @@ TSSLServerSocket::TSSLServerSocket(int port, } boost::shared