[jira] [Commented] (THRIFT-3173) Exceptions should set the inherited message field

2015-11-18 Thread Vincent P (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013103#comment-15013103 ] Vincent P commented on THRIFT-3173: --- What about : - implementing `getMessage` with the

[jira] [Commented] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

2015-11-18 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012862#comment-15012862 ] Adam Beberg commented on THRIFT-3429: - Ah, I misunderstood you as talking about the e

[jira] [Comment Edited] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

2015-11-18 Thread Justin Larrabee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012753#comment-15012753 ] Justin Larrabee edited comment on THRIFT-3429 at 11/19/15 4:17 AM:

[jira] [Commented] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

2015-11-18 Thread Justin Larrabee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012753#comment-15012753 ] Justin Larrabee commented on THRIFT-3429: - I am sorry but you are incorrect about

[jira] [Commented] (THRIFT-2410) JavaMe: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol

2015-11-18 Thread Phongphan Phuttha (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012621#comment-15012621 ] Phongphan Phuttha commented on THRIFT-2410: --- Hi I've created a pull request he

[jira] [Commented] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

2015-11-18 Thread Adam Beberg (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15012328#comment-15012328 ] Adam Beberg commented on THRIFT-3429: - The current behavior is correct in keeping the

Re: [jira] [Commented] (THRIFT-2413) Python: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol

2015-11-18 Thread Roger Meier
Jens, Yes, i feel the same ... it's a nightmare! There is just one way, we need to fix it, at least where we can... Thank YOU so much for keeping this ball rolling! -roger PS: apropos, worth to see: http://www.darwinsnightmare.com/ Quoting "Jens Geyer (JIRA)" : [ https://issues.apache.org/

[GitHub] thrift pull request: In go THttpClient, explicitly read response b...

2015-11-18 Thread justonia
GitHub user justonia opened a pull request: https://github.com/apache/thrift/pull/703 In go THttpClient, explicitly read response body to completion when closing Fixes: https://issues.apache.org/jira/browse/THRIFT-3430 You can merge this pull request into a Git repository by running

[jira] [Commented] (THRIFT-3430) Go THttpClient does not read HTTP response body to completion when closing

2015-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011613#comment-15011613 ] ASF GitHub Bot commented on THRIFT-3430: GitHub user justonia opened a pull reque

[jira] [Created] (THRIFT-3430) Go THttpClient does not read HTTP response body to completion when closing

2015-11-18 Thread Justin Larrabee (JIRA)
Justin Larrabee created THRIFT-3430: --- Summary: Go THttpClient does not read HTTP response body to completion when closing Key: THRIFT-3430 URL: https://issues.apache.org/jira/browse/THRIFT-3430 Proj

[jira] [Updated] (THRIFT-3430) Go THttpClient does not read HTTP response body to completion when closing

2015-11-18 Thread Justin Larrabee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Larrabee updated THRIFT-3430: Priority: Minor (was: Major) > Go THttpClient does not read HTTP response body to completi

[jira] [Updated] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

2015-11-18 Thread Justin Larrabee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Larrabee updated THRIFT-3429: Description: Currently the THttpTransport holds onto the HTTP response body until the owner

[jira] [Updated] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body after Flush

2015-11-18 Thread Justin Larrabee (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justin Larrabee updated THRIFT-3429: Summary: Go THttpClient option to fully read/close HTTP response body after Flush (was: Go

[jira] [Created] (THRIFT-3429) Go THttpClient option to fully read/close HTTP response body

2015-11-18 Thread Justin Larrabee (JIRA)
Justin Larrabee created THRIFT-3429: --- Summary: Go THttpClient option to fully read/close HTTP response body Key: THRIFT-3429 URL: https://issues.apache.org/jira/browse/THRIFT-3429 Project: Thrift

[jira] [Commented] (THRIFT-2413) Python: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol

2015-11-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011535#comment-15011535 ] Jens Geyer commented on THRIFT-2413: Sometimes I just want to cry. i mean, we have 20

[jira] [Commented] (THRIFT-2413) Python: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol

2015-11-18 Thread Phongphan Phuttha (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011528#comment-15011528 ] Phongphan Phuttha commented on THRIFT-2413: --- Probably from a non-ascii characte

[GitHub] thrift pull request: JavaMe: UTF-8 sent by PHP as JSON is not unde...

2015-11-18 Thread phongphan
GitHub user phongphan opened a pull request: https://github.com/apache/thrift/pull/702 JavaMe: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol Hi This should fix THRIFT-2410. The patch is build against Java 1.3. The library doesn't appear to have tests and I

[jira] [Commented] (THRIFT-2413) Python: UTF-8 sent by PHP as JSON is not understood by TJsonProtocol

2015-11-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15011434#comment-15011434 ] Jens Geyer commented on THRIFT-2413: Not sure if it belongs here, but I get this: {c

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

2015-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010932#comment-15010932 ] ASF GitHub Bot commented on THRIFT-3385: Github user hcorg commented on a diff in

[GitHub] thrift pull request: THRIFT-3385 warning: format ‘%lu’ expects...

2015-11-18 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/688#discussion_r45195544 --- Diff: test/cpp/src/TestClient.cpp --- @@ -488,7 +488,7 @@ int main(int argc, char** argv) { testClient.testBinary(bin_result, string(bin_data, 256

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

2015-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010929#comment-15010929 ] ASF GitHub Bot commented on THRIFT-3385: Github user jeking3 commented on a diff

[GitHub] thrift pull request: THRIFT-3385 warning: format ‘%lu’ expects...

2015-11-18 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/688#discussion_r45195379 --- Diff: test/cpp/src/TestClient.cpp --- @@ -488,7 +488,7 @@ int main(int argc, char** argv) { testClient.testBinary(bin_result, string(bin_data, 2

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

2015-11-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010850#comment-15010850 ] ASF GitHub Bot commented on THRIFT-3385: Github user henrique commented on a diff

[GitHub] thrift pull request: THRIFT-3385 warning: format ‘%lu’ expects...

2015-11-18 Thread henrique
Github user henrique commented on a diff in the pull request: https://github.com/apache/thrift/pull/688#discussion_r45190854 --- Diff: test/cpp/src/TestClient.cpp --- @@ -488,7 +488,7 @@ int main(int argc, char** argv) { testClient.testBinary(bin_result, string(bin_data,