[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021691#comment-15021691 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45577791 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1105,10 +1113,17 @@ void TNonblockingServer::listenSocket(THRIFT_SOCKET s) { serverSoc

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021684#comment-15021684 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45577368 --- Diff: lib/cpp/test/TFileTransportTest.cpp --- @@ -91,19 +99,35 @@ class FsyncLog { class TempFile { public: TempFile(const char* directory,

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45577051 --- Diff: lib/cpp/test/OpenSSLManualInitTest.cpp --- @@ -67,6 +67,22 @@ void test_openssl_availability() { openssl_cleanup(); } --- End dif

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021677#comment-15021677 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021674#comment-15021674 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45576978 --- Diff: lib/cpp/src/thrift/windows/GetTimeOfDay.cpp --- @@ -23,17 +23,28 @@ // win32 #include +#if defined(__MINGW32__) + #include

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021673#comment-15021673 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45576872 --- Diff: lib/cpp/test/SecurityTest.cpp --- @@ -108,8 +108,13 @@ struct SecurityFixture : public TestPortFixture pServerSocketFactory.rese

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021670#comment-15021670 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45576807 --- Diff: lib/cpp/test/CMakeLists.txt --- @@ -25,6 +25,10 @@ include_directories(SYSTEM "${Boost_INCLUDE_DIRS}") #Make sure gen-cpp files can be included

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021667#comment-15021667 ] ASF GitHub Bot commented on THRIFT-3437: Github user nsuke commented on a diff in

[GitHub] thrift pull request: THRIFT-3437 - Fixed MinGW-w64 build && boost/...

2015-11-22 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/628#discussion_r45576725 --- Diff: lib/cpp/test/qt/TQTcpServerTest.cpp --- @@ -1,18 +1,23 @@ #define BOOST_TEST_MODULE TQTcpServerTest #include -#include + +#ifnd

[jira] [Issue Comment Deleted] (THRIFT-2143) Generated Ruby client doesn't handle enums

2015-11-22 Thread Carl Hall (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carl Hall updated THRIFT-2143: -- Comment: was deleted (was: Turns out that I get this error when I build a project using the {{0.9.3}}

[jira] [Commented] (THRIFT-2143) Generated Ruby client doesn't handle enums

2015-11-22 Thread Carl Hall (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021302#comment-15021302 ] Carl Hall commented on THRIFT-2143: --- Turns out that I get this error when I build a pro

[jira] [Commented] (THRIFT-3431) Avoid "schemes" HashMap lookups during struct reads/writes

2015-11-22 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021182#comment-15021182 ] Hudson commented on THRIFT-3431: SUCCESS: Integrated in Thrift #1737 (See [https://build

[jira] [Resolved] (THRIFT-3431) Avoid "schemes" HashMap lookups during struct reads/writes

2015-11-22 Thread Roger Meier (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Meier resolved THRIFT-3431. - Resolution: Fixed committed > Avoid "schemes" HashMap lookups during struct reads/writes > -

[jira] [Commented] (THRIFT-3431) Avoid "schemes" HashMap lookups during struct reads/writes

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021170#comment-15021170 ] ASF GitHub Bot commented on THRIFT-3431: Github user asfgit closed the pull reque

[GitHub] thrift pull request: THRIFT-3431 Avoid an unnecessary HashMap look...

2015-11-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/704 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15021119#comment-15021119 ] ASF GitHub Bot commented on THRIFT-3437: Github user becrux commented on the pull

[GitHub] thrift pull request: Fixed MinGW-w64 build && boost/functional con...

2015-11-22 Thread becrux
Github user becrux commented on the pull request: https://github.com/apache/thrift/pull/628#issuecomment-158787586 Thanks for the suggestion, @nsuke. I've created the following issue on JIRA: https://issues.apache.org/jira/browse/THRIFT-3437 Unfortunately, I w

[jira] [Created] (THRIFT-3437) Mingw-w64 build fail

2015-11-22 Thread Antonio Di Monaco (JIRA)
Antonio Di Monaco created THRIFT-3437: - Summary: Mingw-w64 build fail Key: THRIFT-3437 URL: https://issues.apache.org/jira/browse/THRIFT-3437 Project: Thrift Issue Type: Bug Com