[jira] [Commented] (THRIFT-3567) GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106224#comment-15106224 ] Chandler May commented on THRIFT-3567: -- Github branch updated with test based on GWe

[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...

Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/795#issuecomment-172728554 Your commitment to testing is admirable! Looks good to me for merge. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[jira] [Commented] (THRIFT-1313) c_glib compact support

[ https://issues.apache.org/jira/browse/THRIFT-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106193#comment-15106193 ] ASF GitHub Bot commented on THRIFT-1313: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-1313 implement compact protocol for c_...

Github user cjmay commented on the pull request: https://github.com/apache/thrift/pull/795#issuecomment-172706228 Thanks for the feedback! I added the c_glib compact protocol to test/tests.json and cross tests now pass. --- If your project is set up for it, you can reply to this ema

[jira] [Commented] (THRIFT-1313) c_glib compact support

[ https://issues.apache.org/jira/browse/THRIFT-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106116#comment-15106116 ] ASF GitHub Bot commented on THRIFT-1313: Github user cjmay commented on the pull

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105875#comment-15105875 ] Peter Butler commented on THRIFT-3555: -- BTW did you revert that patch out? If I now

[jira] [Commented] (THRIFT-3567) GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105837#comment-15105837 ] Chandler May commented on THRIFT-3567: -- Actually, GWeakNotify looks like the tool to

[jira] [Commented] (THRIFT-3567) GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105827#comment-15105827 ] Chandler May commented on THRIFT-3567: -- Empirically, after running make cross,(*) g

[jira] [Commented] (THRIFT-3545) Container type literals do not compile

[ https://issues.apache.org/jira/browse/THRIFT-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105788#comment-15105788 ] ASF GitHub Bot commented on THRIFT-3545: Github user kdubb commented on the pull

[GitHub] thrift pull request: THRIFT-3545 Cocoa: Container type literals do...

Github user kdubb commented on the pull request: https://github.com/apache/thrift/pull/790#issuecomment-172646482 I am fairly sure that #797 fixes the line breaks and semi-colons in the proper way. So, just check it with your code to make sure. As far as performance of ARC I w

[jira] [Commented] (THRIFT-3567) GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105785#comment-15105785 ] Jens Geyer commented on THRIFT-3567: How can we test that? > GLib-GObject-CRITICAL *

[jira] [Issue Comment Deleted] (THRIFT-3567) GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3567: --- Comment: was deleted (was: How can we test that?) > GLib-GObject-CRITICAL **: g_object_unref: assert

[jira] [Created] (THRIFT-3569) c_glib binary protocol does not check number of bytes read by transport

Chandler May created THRIFT-3569: Summary: c_glib binary protocol does not check number of bytes read by transport Key: THRIFT-3569 URL: https://issues.apache.org/jira/browse/THRIFT-3569 Project: Thri

[jira] [Commented] (THRIFT-3568) THeader server crashes on readSlow

[ https://issues.apache.org/jira/browse/THRIFT-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105740#comment-15105740 ] ASF GitHub Bot commented on THRIFT-3568: Github user bufferoverflow commented on

[GitHub] thrift pull request: THRIFT-3568 THeader server crashes on readSlo...

Github user bufferoverflow commented on the pull request: https://github.com/apache/thrift/pull/807#issuecomment-172632943 @andrewcox similar issues at fb with this code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Updated] (THRIFT-3567) GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3567: --- Summary: GLib-GObject-CRITICAL **: g_object_unref: assertion 'G_IS_OBJECT (object)' failed (was: obj

[GitHub] thrift pull request: THRIFT-3568 THeader server crashes on readSlo...

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/807 THRIFT-3568 THeader server crashes on readSlow You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3568 Alternatively you can rev

[jira] [Commented] (THRIFT-3568) THeader server crashes on readSlow

[ https://issues.apache.org/jira/browse/THRIFT-3568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105691#comment-15105691 ] ASF GitHub Bot commented on THRIFT-3568: GitHub user nsuke opened a pull request:

[jira] [Created] (THRIFT-3568) THeader server crashes on readSlow

Aki Sukegawa created THRIFT-3568: Summary: THeader server crashes on readSlow Key: THRIFT-3568 URL: https://issues.apache.org/jira/browse/THRIFT-3568 Project: Thrift Issue Type: Bug

[jira] [Resolved] (THRIFT-3564) C++/Qt: potential core dump in TQTcpServer in case an exception occurs in TAsyncProcessor::process()

[ https://issues.apache.org/jira/browse/THRIFT-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3564. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > C++/Qt: potential core dump in TQTcp

[jira] [Resolved] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

[ https://issues.apache.org/jira/browse/THRIFT-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3561. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > C++/Qt: make use of Q_DISABLE_COPY()

[jira] [Resolved] (THRIFT-3562) Removed unused TAsyncProcessor::getAsyncServer()

[ https://issues.apache.org/jira/browse/THRIFT-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3562. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > Removed unused TAsyncProcessor::getA

[jira] [Resolved] (THRIFT-3566) C++/Qt: TQTcpServerTest::test_communicate() is never executed

[ https://issues.apache.org/jira/browse/THRIFT-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3566. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > C++/Qt: TQTcpServerTest::test_commun

[jira] [Resolved] (THRIFT-3565) C++: T[Async]Processor::getEventHandler() should be declared as const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3565. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > C++: T[Async]Processor::getEventHand

[jira] [Resolved] (THRIFT-3439) Run make cross using Python3 when available

[ https://issues.apache.org/jira/browse/THRIFT-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3439. -- Resolution: Fixed committed > Run make cross using Python3 when available > --

[jira] [Resolved] (THRIFT-3544) Make cross test fail when server process died unexpectedly

[ https://issues.apache.org/jira/browse/THRIFT-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3544. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > Make cross test fail when server pro

[jira] [Resolved] (THRIFT-3563) C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE as it isn't consequently used for all references to Qt types.

[ https://issues.apache.org/jira/browse/THRIFT-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa resolved THRIFT-3563. -- Resolution: Fixed Fix Version/s: 0.9.4 committed > C++/Qt: removed usage of macro QT_PR

[jira] [Commented] (THRIFT-3566) C++/Qt: TQTcpServerTest::test_communicate() is never executed

[ https://issues.apache.org/jira/browse/THRIFT-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105641#comment-15105641 ] ASF GitHub Bot commented on THRIFT-3566: Github user nsuke commented on the pull

[GitHub] thrift pull request: THRIFT-3566: fixed TQTcpServerTest - it was n...

Github user nsuke commented on the pull request: https://github.com/apache/thrift/pull/804#issuecomment-172620051 @szenker thanks for the patches. Please close this one and #802 as they are merged. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] thrift pull request: THRIFT-3563: C++/Qt: removed usage of macro Q...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/801 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (THRIFT-3544) Make cross test fail when server process died unexpectedly

[ https://issues.apache.org/jira/browse/THRIFT-3544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105632#comment-15105632 ] ASF GitHub Bot commented on THRIFT-3544: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3563) C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE as it isn't consequently used for all references to Qt types.

[ https://issues.apache.org/jira/browse/THRIFT-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105635#comment-15105635 ] ASF GitHub Bot commented on THRIFT-3563: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3565) C++: T[Async]Processor::getEventHandler() should be declared as const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105636#comment-15105636 ] ASF GitHub Bot commented on THRIFT-3565: Github user asfgit closed the pull reque

[GitHub] thrift pull request: THRIFT-3561: C++/Qt: make use of Q_DISABLE_CO...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/799 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3565: C++: declared T{Async}Processor:...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/803 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3439 Run make cross using Python3 when...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/792 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (THRIFT-3439) Run make cross using Python3 when available

[ https://issues.apache.org/jira/browse/THRIFT-3439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105631#comment-15105631 ] ASF GitHub Bot commented on THRIFT-3439: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3562) Removed unused TAsyncProcessor::getAsyncServer()

[ https://issues.apache.org/jira/browse/THRIFT-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105634#comment-15105634 ] ASF GitHub Bot commented on THRIFT-3562: Github user asfgit closed the pull reque

[GitHub] thrift pull request: THRIFT-3562: C++: removed unused TEventServer

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/800 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] thrift pull request: THRIFT-3544 Let cross test fail when server p...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/793 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

[ https://issues.apache.org/jira/browse/THRIFT-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105633#comment-15105633 ] ASF GitHub Bot commented on THRIFT-3561: Github user asfgit closed the pull reque

Build failed in Jenkins: thrift #588

See Changes: [roger] THRIFT-3558 fix typos in c_glib test assertions [roger] THRIFT-3551 Thrift perl library missing package declaration [roger] crossrunner: fix browse url -- [...truncated 166

[jira] [Commented] (THRIFT-3567) object unref errors in cross tests with c_glib server

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105602#comment-15105602 ] ASF GitHub Bot commented on THRIFT-3567: GitHub user cjmay opened a pull request:

[GitHub] thrift pull request: THRIFT-3567 prevent g_object_unref errors in ...

GitHub user cjmay opened a pull request: https://github.com/apache/thrift/pull/806 THRIFT-3567 prevent g_object_unref errors in c_glib cross test server. Add additional object ref in insanity test handler to prevent GLib g_object_unref errors. You can merge this pull request into a

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105549#comment-15105549 ] Peter Butler commented on THRIFT-3555: -- OK I just tried it from scratch with the ver

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105541#comment-15105541 ] Aki Sukegawa commented on THRIFT-3555: -- yes, that is master branch with the patch on

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105533#comment-15105533 ] Peter Butler commented on THRIFT-3555: -- I don't mind doing a git clone - I was merel

[jira] [Comment Edited] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105527#comment-15105527 ] Aki Sukegawa edited comment on THRIFT-3555 at 1/18/16 5:09 PM:

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105527#comment-15105527 ] Aki Sukegawa commented on THRIFT-3555: -- No it's not added recently. I guess it's bei

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105520#comment-15105520 ] Peter Butler commented on THRIFT-3555: -- No bootstrap.sh file even exists in 0.9.3, o

[jira] [Updated] (THRIFT-3567) object unref errors in cross tests with c_glib server

[ https://issues.apache.org/jira/browse/THRIFT-3567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chandler May updated THRIFT-3567: - Summary: object unref errors in cross tests with c_glib server (was: c_glib) > object unref err

[jira] [Created] (THRIFT-3567) c_glib

Chandler May created THRIFT-3567: Summary: c_glib Key: THRIFT-3567 URL: https://issues.apache.org/jira/browse/THRIFT-3567 Project: Thrift Issue Type: Bug Components: C glib - Librar

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105506#comment-15105506 ] Aki Sukegawa commented on THRIFT-3555: -- [~Peter Butler] it's meat for master branch

[jira] [Comment Edited] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105506#comment-15105506 ] Aki Sukegawa edited comment on THRIFT-3555 at 1/18/16 4:46 PM:

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105497#comment-15105497 ] Peter Butler commented on THRIFT-3555: -- I've tried adding your patch *manually* (not

[GitHub] thrift pull request: THRIFT-3555 'configure' script does not honor...

GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/805 THRIFT-3555 'configure' script does not honor --with-openssl= f… …or libcrypto for BN_init You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuk

[jira] [Assigned] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aki Sukegawa reassigned THRIFT-3555: Assignee: Aki Sukegawa > 'configure' script does not honor --with-openssl= for libcrypto f

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105480#comment-15105480 ] ASF GitHub Bot commented on THRIFT-3555: GitHub user nsuke opened a pull request:

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105479#comment-15105479 ] Aki Sukegawa commented on THRIFT-3555: -- THRIFT-2887 should have removed the old chec

[jira] [Commented] (THRIFT-3545) Container type literals do not compile

[ https://issues.apache.org/jira/browse/THRIFT-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105476#comment-15105476 ] ASF GitHub Bot commented on THRIFT-3545: Github user ChristopherRogers commented

[GitHub] thrift pull request: THRIFT-3545 Cocoa: Container type literals do...

Github user ChristopherRogers commented on the pull request: https://github.com/apache/thrift/pull/790#issuecomment-172575020 Also, I just remembered from an old version of Xcode that even the @[]/@{} syntax used autorelease (probably to easily codegen in both ARC and MRC) but that mi

[jira] [Commented] (THRIFT-3545) Container type literals do not compile

[ https://issues.apache.org/jira/browse/THRIFT-3545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105465#comment-15105465 ] ASF GitHub Bot commented on THRIFT-3545: Github user ChristopherRogers commented

[GitHub] thrift pull request: THRIFT-3545 Cocoa: Container type literals do...

Github user ChristopherRogers commented on the pull request: https://github.com/apache/thrift/pull/790#issuecomment-172571012 Ah, my apologies for the extra semicolons. It was missing semicolons in the default init methods where a collection type had a default value. I believe

[jira] [Commented] (THRIFT-3555) 'configure' script does not honor --with-openssl= for libcrypto for BN_init

[ https://issues.apache.org/jira/browse/THRIFT-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15105400#comment-15105400 ] Peter Butler commented on THRIFT-3555: -- No I do not. :-( Indeed I am still stuck o

[jira] [Comment Edited] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104919#comment-15104919 ] Sebastian Zenker edited comment on THRIFT-3560 at 1/18/16 8:53 AM:

[jira] [Comment Edited] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

[ https://issues.apache.org/jira/browse/THRIFT-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104921#comment-15104921 ] Sebastian Zenker edited comment on THRIFT-3561 at 1/18/16 8:52 AM:

[jira] [Commented] (THRIFT-3566) C++/Qt: TQTcpServerTest::test_communicate() is never executed

[ https://issues.apache.org/jira/browse/THRIFT-3566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104957#comment-15104957 ] ASF GitHub Bot commented on THRIFT-3566: GitHub user szenker opened a pull reques

[GitHub] thrift pull request: THRIFT-3566: fixed TQTcpServerTest - it was n...

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/804 THRIFT-3566: fixed TQTcpServerTest - it was never executed and working You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenker/thrift THRIFT-356

[jira] [Created] (THRIFT-3566) C++/Qt: TQTcpServerTest::test_communicate() is never executed

Sebastian Zenker created THRIFT-3566: Summary: C++/Qt: TQTcpServerTest::test_communicate() is never executed Key: THRIFT-3566 URL: https://issues.apache.org/jira/browse/THRIFT-3566 Project: Thrift

[jira] [Commented] (THRIFT-3565) C++: T[Async]Processor::getEventHandler() should be declared as const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104939#comment-15104939 ] ASF GitHub Bot commented on THRIFT-3565: GitHub user szenker opened a pull reques

[GitHub] thrift pull request: THRIFT-3565: C++: declared T{Async}Processor:...

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/803 THRIFT-3565: C++: declared T{Async}Processor::getEventHandler() as const member functions You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenk

[jira] [Created] (THRIFT-3565) C++: T[Async]Processor::getEventHandler() should be declared as const member functions

Sebastian Zenker created THRIFT-3565: Summary: C++: T[Async]Processor::getEventHandler() should be declared as const member functions Key: THRIFT-3565 URL: https://issues.apache.org/jira/browse/THRIFT-3565

[jira] [Commented] (THRIFT-3564) C++/Qt: potential core dump in TQTcpServer in case an exception occurs in TAsyncProcessor::process()

[ https://issues.apache.org/jira/browse/THRIFT-3564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104935#comment-15104935 ] ASF GitHub Bot commented on THRIFT-3564: GitHub user szenker opened a pull reques

[GitHub] thrift pull request: THRIFT-3564: potential core dump in TQTcpServ...

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/802 THRIFT-3564: potential core dump in TQTcpServer TQTcpServer: it's not allowed to delete the sender of a Qt signal (QTcpSocket) while executing one of its slots. This could happen in TQTcpServer::be

[jira] [Created] (THRIFT-3564) C++/Qt: potential core dump in TQTcpServer in case an exception occurs in TAsyncProcessor::process()

Sebastian Zenker created THRIFT-3564: Summary: C++/Qt: potential core dump in TQTcpServer in case an exception occurs in TAsyncProcessor::process() Key: THRIFT-3564 URL: https://issues.apache.org/jira/browse/T

[jira] [Commented] (THRIFT-3563) C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE as it isn't consequently used for all references to Qt types.

[ https://issues.apache.org/jira/browse/THRIFT-3563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104927#comment-15104927 ] ASF GitHub Bot commented on THRIFT-3563: GitHub user szenker opened a pull reques

[GitHub] thrift pull request: THRIFT-3563: C++/Qt: removed usage of macro Q...

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/801 THRIFT-3563: C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE() as it wasn't use consequently for all Qt types, e.g. it cannot be combined with shared_ptr<> You can merge this pull request into

[jira] [Created] (THRIFT-3563) C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE as it isn't consequently used for all references to Qt types.

Sebastian Zenker created THRIFT-3563: Summary: C++/Qt: removed usage of macro QT_PREPEND_NAMESPACE as it isn't consequently used for all references to Qt types. Key: THRIFT-3563 URL: https://issues.apache.org/

[jira] [Commented] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104919#comment-15104919 ] Sebastian Zenker commented on THRIFT-3560: -- Please see my merge request on Githu

[jira] [Commented] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

[ https://issues.apache.org/jira/browse/THRIFT-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104921#comment-15104921 ] Sebastian Zenker commented on THRIFT-3561: -- Please see my merge request on Githu

[jira] [Commented] (THRIFT-3562) Removed unused TAsyncProcessor::getAsyncServer()

[ https://issues.apache.org/jira/browse/THRIFT-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104918#comment-15104918 ] ASF GitHub Bot commented on THRIFT-3562: GitHub user szenker opened a pull reques

[GitHub] thrift pull request: THRIFT-3562: C++: removed unused TEventServer

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/800 THRIFT-3562: C++: removed unused TEventServer You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenker/thrift THRIFT-3562 Alternatively you can

[jira] [Updated] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

[ https://issues.apache.org/jira/browse/THRIFT-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Zenker updated THRIFT-3561: - Labels: easyfix (was: ) > C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor a

[jira] [Updated] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

[ https://issues.apache.org/jira/browse/THRIFT-3560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Zenker updated THRIFT-3560: - Labels: easyfix (was: ) > C++ TTransport::isOpen() and TTransport::getOrigin() should be

[jira] [Updated] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

[ https://issues.apache.org/jira/browse/THRIFT-3561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Zenker updated THRIFT-3561: - Component/s: C++ - Library > C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor

[jira] [Updated] (THRIFT-3562) Removed unused TAsyncProcessor::getAsyncServer()

[ https://issues.apache.org/jira/browse/THRIFT-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Zenker updated THRIFT-3562: - Labels: easyfix (was: ) > Removed unused TAsyncProcessor::getAsyncServer() > ---

[jira] [Created] (THRIFT-3562) Removed unused TAsyncProcessor::getAsyncServer()

Sebastian Zenker created THRIFT-3562: Summary: Removed unused TAsyncProcessor::getAsyncServer() Key: THRIFT-3562 URL: https://issues.apache.org/jira/browse/THRIFT-3562 Project: Thrift Iss

[GitHub] thrift pull request: C++/Qt: make use of Q_DISABLE_COPY() to get r...

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/799 C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator … You can merge this pull request into a Git repository by running: $ git pull https://github.com/szenker

[jira] [Created] (THRIFT-3561) C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator

Sebastian Zenker created THRIFT-3561: Summary: C++/Qt: make use of Q_DISABLE_COPY() to get rid of copy ctor and assignment operator Key: THRIFT-3561 URL: https://issues.apache.org/jira/browse/THRIFT-3561

[GitHub] thrift pull request: C++: declared TTransport::isOpen() and TTrans...

GitHub user szenker opened a pull request: https://github.com/apache/thrift/pull/798 C++: declared TTransport::isOpen() and TTransport::getOrigin() as const member functions Also TTransport::peek() should be const in my opinion, but this requires some refactoring. You can merge th

[jira] [Created] (THRIFT-3560) C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions

Sebastian Zenker created THRIFT-3560: Summary: C++ TTransport::isOpen() and TTransport::getOrigin() should be const member functions Key: THRIFT-3560 URL: https://issues.apache.org/jira/browse/THRIFT-3560