[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245004#comment-15245004
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on the pul
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245002#comment-15245002
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59996235
--- Diff: lib/cpp/test/TServerIntegrationTest.cpp ---
@@ -152,7 +155,10 @@ class TServerIntegrationTestFixture {
new TSe
Github user tpcwang commented on the pull request:
https://github.com/apache/thrift/pull/980#issuecomment-211137935
I think this change looks good for the most part, maybe we can get one of
the maintainers to look at it?
---
If your project is set up for it, you can reply to this ema
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245001#comment-15245001
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59996185
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -90,31 +95,69 @@ TThreadedServer::~TThreadedServer() {
}
void TThreadedServer::s
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244995#comment-15244995
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59996087
--- Diff: lib/cpp/src/thrift/server/TThreadedServer.cpp ---
@@ -90,31 +95,71 @@ TThreadedServer::~TThreadedServer() {
}
void TThreadedServer::s
[
https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244992#comment-15244992
]
ASF GitHub Bot commented on THRIFT-3768:
Github user tpcwang commented on a diff
Github user tpcwang commented on a diff in the pull request:
https://github.com/apache/thrift/pull/980#discussion_r59995963
--- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp ---
@@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value) {
{
Syn
[
https://issues.apache.org/jira/browse/THRIFT-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244972#comment-15244972
]
ASF GitHub Bot commented on THRIFT-71:
--
Github user nsuke commented on a diff in the p
Github user nsuke commented on a diff in the pull request:
https://github.com/apache/thrift/pull/988#discussion_r59995093
--- Diff: debian/rules ---
@@ -199,8 +199,8 @@ binary-common:
dh_installexamples
dh_installman
dh_link
- dh_strip -ppython-thrift -
Github user Jens-G commented on a diff in the pull request:
https://github.com/apache/thrift/pull/988#discussion_r59993662
--- Diff: debian/rules ---
@@ -199,8 +199,8 @@ binary-common:
dh_installexamples
dh_installman
dh_link
- dh_strip -ppython-thrift
13 matches
Mail list logo
