[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263540#comment-15263540 ] ASF GitHub Bot commented on THRIFT-3768: Github user tpcwang commented on a diff

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

2016-04-28 Thread tpcwang
Github user tpcwang commented on a diff in the pull request: https://github.com/apache/thrift/pull/980#discussion_r61534321 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -421,7 +416,7 @@ void ThreadManager::Impl::removeWorker(size_t value) { { Syn

[jira] [Commented] (THRIFT-3805) Golang server susceptible to memory spike from malformed message

2016-04-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263252#comment-15263252 ] Jens Geyer commented on THRIFT-3805: Thanks, good catch! If you could [put it into

[jira] [Updated] (THRIFT-3799) Make constants to use iota

2016-04-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-3799: --- Fix Version/s: (was: 0.10.0) > Make constants to use iota > -- > >

[jira] [Commented] (THRIFT-3799) Make constants to use iota

2016-04-28 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15263248#comment-15263248 ] Jens Geyer commented on THRIFT-3799: Sorry, but I'm against this patch. While it cle

[jira] [Created] (THRIFT-3805) Golang server susceptible to memory spike from malformed message

2016-04-28 Thread Michael Scott Leuthaeuser (JIRA)
Michael Scott Leuthaeuser created THRIFT-3805: - Summary: Golang server susceptible to memory spike from malformed message Key: THRIFT-3805 URL: https://issues.apache.org/jira/browse/THRIFT-3805

[jira] [Resolved] (THRIFT-3804) server is stuck in loadshedding mode

2016-04-28 Thread Bo Liu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Liu resolved THRIFT-3804. Resolution: Won't Fix This is an application level code issue. Thanks. > server is stuck in loadshedding m

[jira] [Closed] (THRIFT-3804) server is stuck in loadshedding mode

2016-04-28 Thread Bo Liu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bo Liu closed THRIFT-3804. -- > server is stuck in loadshedding mode > > > Key: THRIFT-3804

[jira] [Commented] (THRIFT-3768) TThreadedServer may crash if it is destroyed immediately after it returns from serve(); TThreadedServer disconnects clients when they connec

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262575#comment-15262575 ] ASF GitHub Bot commented on THRIFT-3768: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-3233: fix accounting of workers in thr...

2016-04-28 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/992#issuecomment-215501943 Looking for an advocate who would consider merging this fix despite the busted Apache Jenkins environment result. --- If your project is set up for it, you can reply to

[jira] [Commented] (THRIFT-3233) Fix C++ ThreadManager::Impl::removeWorker worker join

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262574#comment-15262574 ] ASF GitHub Bot commented on THRIFT-3233: Github user jeking3 commented on the pul

[GitHub] thrift pull request: THRIFT-3768: ensure TThreadedServer guarantee...

2016-04-28 Thread jeking3
Github user jeking3 commented on the pull request: https://github.com/apache/thrift/pull/980#issuecomment-215502049 Looking for an advocate who would consider merging this fix despite the busted Apache Jenkins environment result. --- If your project is set up for it, you can reply to

[jira] [Commented] (THRIFT-3804) server is stuck in loadshedding mode

2016-04-28 Thread Bo Liu (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262423#comment-15262423 ] Bo Liu commented on THRIFT-3804: The returned EXCEPTION from the server has an error mess

[jira] [Created] (THRIFT-3804) server is stuck in loadshedding mode

2016-04-28 Thread Bo Liu (JIRA)
Bo Liu created THRIFT-3804: -- Summary: server is stuck in loadshedding mode Key: THRIFT-3804 URL: https://issues.apache.org/jira/browse/THRIFT-3804 Project: Thrift Issue Type: Bug Reporte

[GitHub] thrift pull request: THRIFT-3803 - Tweak attributes that are expor...

2016-04-28 Thread bgould
GitHub user bgould opened a pull request: https://github.com/apache/thrift/pull/996 THRIFT-3803 - Tweak attributes that are exported from XML generator When I created the XML generator, I added an attribute named "file" to the element that has path information to the included file.

Build failed in Jenkins: Thrift-precommit #444

2016-04-28 Thread Apache Jenkins Server
See -- GitHub pull request #996 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu yahoo-not-h2) in workspace

[jira] [Commented] (THRIFT-3803) Remove "file" attribute from XML generator

2016-04-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262297#comment-15262297 ] ASF GitHub Bot commented on THRIFT-3803: GitHub user bgould opened a pull request

[jira] [Created] (THRIFT-3803) Remove "file" attribute from XML generator

2016-04-28 Thread Benjamin Gould (JIRA)
Benjamin Gould created THRIFT-3803: -- Summary: Remove "file" attribute from XML generator Key: THRIFT-3803 URL: https://issues.apache.org/jira/browse/THRIFT-3803 Project: Thrift Issue Type: I

[jira] [Issue Comment Deleted] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Comment: was deleted (was: Fixed proxy support patch (without proxy auth), this works with HTTP a

[jira] [Issue Comment Deleted] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Comment: was deleted (was: Proxy authorization patch after fixing the previous one.) > CLONE - T

[jira] [Updated] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Attachment: (was: 0002-Python-THttpClient-Support-proxy-authorization.patch) > CLONE - THttp

[jira] [Updated] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Attachment: (was: 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch) > CLONE -

[jira] [Issue Comment Deleted] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Comment: was deleted (was: The second patch also fixes a problem with the first one which was usi

[jira] [Updated] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Attachment: 0002-Python-THttpClient-Support-proxy-authorization.patch Proxy authorization patch a

[jira] [Updated] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Attachment: 0001-python-THttpClient-Add-support-for-system-proxy-sett.patch Fixed proxy support p

[jira] [Commented] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262082#comment-15262082 ] Martin Wilck commented on THRIFT-3798: -- The second patch also fixes a problem with t

[jira] [Updated] (THRIFT-3798) CLONE - THttpClient does not use proxy from http_proxy, https_proxy environment variables

2016-04-28 Thread Martin Wilck (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Wilck updated THRIFT-3798: - Attachment: 0002-Python-THttpClient-Support-proxy-authorization.patch A second patch on top of th

[jira] [Updated] (THRIFT-3799) Make constants to use iota

2016-04-28 Thread Mahendran Kathirvel (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahendran Kathirvel updated THRIFT-3799: Fix Version/s: 0.10.0 > Make constants to use iota > -- > >

[jira] [Updated] (THRIFT-3799) Make constants to use iota

2016-04-28 Thread Mahendran Kathirvel (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahendran Kathirvel updated THRIFT-3799: Labels: easyfix (was: mentor newbie) > Make constants to use iota > --