[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301501#comment-15301501 ] Steve Cohen commented on THRIFT-3834: - I want to be super clear about this patch; unl

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301500#comment-15301500 ] Steve Cohen commented on THRIFT-3834: - [~nsuke] I don't think the tutorial needs the

[jira] [Updated] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Attachment: (was: thrift-3834-erlang_metadata_fixed_tests.patch) > Erlang namespacing and excep

[jira] [Updated] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Attachment: (was: add_namespacing.patch) > Erlang namespacing and exception metadata >

[jira] [Updated] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Attachment: thrift-3834-erlang_metadata_fixed_tests.patch Fixes problems with make cross. > Erlang

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301453#comment-15301453 ] Aki Sukegawa commented on THRIFT-3834: -- [~icecreamcohen] test/erl and tutorial/erl m

Build failed in Jenkins: Thrift-precommit #491

See -- GitHub pull request #1,018 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on H11 (docker Ubuntu ubuntu yahoo-not-h2) in workspace

[jira] [Closed] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson closed THRIFT-3842. - Resolution: Fixed Fix Version/s: 0.10.0 > Dart generates incorrect code for a const struct

[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...

Github user markerickson-wf commented on the pull request: https://github.com/apache/thrift/pull/1017#issuecomment-221762437 @brianshannan-wf Can you close this PR? I did not construct the commit message correctly for it to be closed automatically. --- If your project is set up for

[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1019 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301327#comment-15301327 ] ASF GitHub Bot commented on THRIFT-3842: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301224#comment-15301224 ] Steve Cohen commented on THRIFT-3834: - The change I would have liked to make would be

[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...

Github user tylertreat-wf commented on the pull request: https://github.com/apache/thrift/pull/1019#issuecomment-221731564 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[jira] [Commented] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15301049#comment-15301049 ] ASF GitHub Bot commented on THRIFT-3842: Github user tylertreat-wf commented on t

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300907#comment-15300907 ] Jens Geyer commented on THRIFT-3834: {quote} ThriftTest.thrift has the line `namespac

[jira] [Issue Comment Deleted] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Comment: was deleted (was: Updated tests to handle namespacing.) > Erlang namespacing and exceptio

[jira] [Updated] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Attachment: (was: thrift-3834-erlang_metadata_fixed_tests.patch) > Erlang namespacing and excep

[jira] [Updated] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Attachment: thrift-3834-erlang_metadata_fixed_tests.patch Fixed tests that were broken due to the s

[jira] [Updated] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Steve Cohen updated THRIFT-3834: Attachment: thrift-3834-erlang_metadata_fixed_tests.patch Updated tests to handle namespacing. > E

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300800#comment-15300800 ] Steve Cohen commented on THRIFT-3834: - [~jensg] [~nsuke], sorry for the test failures

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300751#comment-15300751 ] Steve Cohen commented on THRIFT-3834: - So I figured out how to run tests `make check`

[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...

Github user brianshannan-wf commented on the pull request: https://github.com/apache/thrift/pull/1019#issuecomment-221676733 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[jira] [Commented] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300675#comment-15300675 ] ASF GitHub Bot commented on THRIFT-3842: Github user brianshannan-wf commented on

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300598#comment-15300598 ] Steve Cohen commented on THRIFT-3834: - I sure will... Dumb question though, how do I

Build failed in Jenkins: Thrift-precommit #490

See -- [...truncated 81 lines...] at org.eclipse.jgit.internal.storage.pack.PackWriter.writeObjects(PackWriter.java:1465) at org.eclipse.jgit.internal.storage.pack.PackWriter.writePack(P

[GitHub] thrift pull request: THRIFT-3842 Fix Dart generator for const stru...

GitHub user markerickson-wf opened a pull request: https://github.com/apache/thrift/pull/1019 THRIFT-3842 Fix Dart generator for const structs @tylertreat-wf @stevenosborne-wf @brianshannan-wf ref: https://issues.apache.org/jira/browse/THRIFT-3842 You can merge th

[jira] [Commented] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300582#comment-15300582 ] ASF GitHub Bot commented on THRIFT-3842: GitHub user markerickson-wf opened a pul

[jira] [Updated] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3842: -- Component/s: Dart - Compiler > Dart generates incorrect code for a const struct > -

[jira] [Updated] (THRIFT-3842) Dart generates incorrect code for a const struct

[ https://issues.apache.org/jira/browse/THRIFT-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson updated THRIFT-3842: -- Description: This snippet: {code} struct Operator { 1:string displayName 2:string field

[jira] [Closed] (THRIFT-3841) dart compact protocol incorrectly serializes/deserialized doubles

[ https://issues.apache.org/jira/browse/THRIFT-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson closed THRIFT-3841. - Assignee: Mark Erickson > dart compact protocol incorrectly serializes/deserialized doubles > ---

[jira] [Resolved] (THRIFT-3841) dart compact protocol incorrectly serializes/deserialized doubles

[ https://issues.apache.org/jira/browse/THRIFT-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Erickson resolved THRIFT-3841. --- Resolution: Fixed Fix Version/s: 0.10.0 Fixed in https://github.com/apache/thrift/pull

Build failed in Jenkins: Thrift-precommit #489

See -- GitHub pull request #1,018 to apache/thrift [EnvInject] - Loading node environment variables. Building remotely on ubuntu-1 (docker Ubuntu ubuntu yahoo-not-h2 ubuntu1) in workspace

[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...

Github user markerickson-wf commented on the pull request: https://github.com/apache/thrift/pull/1017#issuecomment-221589481 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...

Github user stevenosborne-wf commented on the pull request: https://github.com/apache/thrift/pull/1017#issuecomment-221568808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[jira] [Commented] (THRIFT-3457) thrift client codegen fails due to problematic names

[ https://issues.apache.org/jira/browse/THRIFT-3457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299783#comment-15299783 ] Fabrice Trillaud commented on THRIFT-3457: -- There's a similar problem I think if

[jira] [Reopened] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reopened THRIFT-3834: > Erlang namespacing and exception metadata > - > >

[jira] [Commented] (THRIFT-3834) Erlang namespacing and exception metadata

[ https://issues.apache.org/jira/browse/THRIFT-3834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299694#comment-15299694 ] Jens Geyer commented on THRIFT-3834: [~icecreamcohen], could you please look at it an