[
https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831160#comment-15831160
]
ASF GitHub Bot commented on THRIFT-2561:
Github user jfarrell closed the pull req
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/325
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831159#comment-15831159
]
Jake Farrell commented on THRIFT-2504:
--
mockito is MIT licensed so no issues, just n
[
https://issues.apache.org/jira/browse/THRIFT-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831156#comment-15831156
]
ASF GitHub Bot commented on THRIFT-2898:
Github user jfarrell closed the pull req
[
https://issues.apache.org/jira/browse/THRIFT-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15831155#comment-15831155
]
ASF GitHub Bot commented on THRIFT-2882:
Github user jfarrell closed the pull req
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/327
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
Github user jfarrell closed the pull request at:
https://github.com/apache/thrift/pull/311
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is en
[
https://issues.apache.org/jira/browse/THRIFT-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-2899.
Resolution: Duplicate
Assignee: James E. King, III
Fix Version/s: 0.
[
https://issues.apache.org/jira/browse/THRIFT-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-2898.
Resolution: Duplicate
Assignee: James E. King, III
Fix Version/s: 0.
[
https://issues.apache.org/jira/browse/THRIFT-2898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830613#comment-15830613
]
James E. King, III commented on THRIFT-2898:
I believe this was implemented a
[
https://issues.apache.org/jira/browse/THRIFT-2896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830607#comment-15830607
]
ASF GitHub Bot commented on THRIFT-2896:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/326
This needs to be rebased against the current master and squashed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830601#comment-15830601
]
ASF GitHub Bot commented on THRIFT-2561:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830602#comment-15830602
]
Phil Eaton commented on THRIFT-2561:
Hello,
Unfortunately you have reached me while I
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/325
@jfarrell this pull request is not necessary as the work was done in a
duplicate item.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
[
https://issues.apache.org/jira/browse/THRIFT-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III resolved THRIFT-2561.
Resolution: Duplicate
Assignee: James E. King, III
Fix Version/s: 0.
[
https://issues.apache.org/jira/browse/THRIFT-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830597#comment-15830597
]
ASF GitHub Bot commented on THRIFT-2882:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/311
@jfarrell this pull request can be closed - I verified the code was merged
into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
[
https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830587#comment-15830587
]
ASF GitHub Bot commented on THRIFT-2721:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/226
This would need to be rebased and corrected, pass CI builds and code review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
[
https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830584#comment-15830584
]
James E. King, III commented on THRIFT-2721:
You mentioned you felt like it c
[
https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830581#comment-15830581
]
James E. King, III commented on THRIFT-2668:
Based on a look through wwhat co
[
https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-2721:
---
Fix Version/s: (was: 1.0)
> generate more idiomatic erlang code
> ---
[
https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830567#comment-15830567
]
James E. King, III commented on THRIFT-2668:
This issue has a pull request th
[
https://issues.apache.org/jira/browse/THRIFT-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830564#comment-15830564
]
James E. King, III commented on THRIFT-2504:
[~jfarrell] please command on wh
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4033:
---
Summary: Default build WITH_PLUGIN=ON for all builds results in packaging
errors (wa
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James E. King, III updated THRIFT-4033:
---
Assignee: James E. King, III
Environment: Ubuntu 14.04.4 LTS is where I reprodu
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830442#comment-15830442
]
ASF GitHub Bot commented on THRIFT-4033:
Github user jfarrell commented on the is
Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/1157
sure, or modify the ticket description to 'disable compiler plug-ins by
default for all builds'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830343#comment-15830343
]
ASF GitHub Bot commented on THRIFT-4033:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1157
I'm okay making the default for plug-in support "OFF", and you have to
enable it specifically. Would it be okay to merge this as it fixes the ticket
as described, and open a new one to change the g
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830337#comment-15830337
]
ASF GitHub Bot commented on THRIFT-4033:
Github user jfarrell commented on the is
Github user jfarrell commented on the issue:
https://github.com/apache/thrift/pull/1157
We have had issues with plugin support being on by default in a couple
build instances now, and this does not fix when we pull out autoconf that it
wont reappear with cmake. I'd like to see us chan
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1157
@jfarrell I'd like one review of this before I merge it. It did fix the
issue I had with the stock 0.10.0 debian package for the compiler not working.
---
If your project is set up for it, you can
[
https://issues.apache.org/jira/browse/THRIFT-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830227#comment-15830227
]
ASF GitHub Bot commented on THRIFT-4033:
Github user jeking3 commented on the iss
[
https://issues.apache.org/jira/browse/THRIFT-3242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830203#comment-15830203
]
James E. King, III commented on THRIFT-3242:
Could someone take a look at SM-
[
https://issues.apache.org/jira/browse/THRIFT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830197#comment-15830197
]
James E. King, III commented on THRIFT-184:
---
Please see SM-3224 and see if our 0
[
https://issues.apache.org/jira/browse/THRIFT-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830193#comment-15830193
]
James E. King, III commented on THRIFT-184:
---
Does this mean we do not need an Ap
[
https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830073#comment-15830073
]
ASF GitHub Bot commented on THRIFT-3926:
Github user jeking3 commented on the iss
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1086
As-is the patch would require string parsing to get the statusCode which is
brittle. I like the overall direction of handling unexpected status code with
an exception; consider using a derived exce
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830069#comment-15830069
]
ASF GitHub Bot commented on THRIFT-4034:
Github user jeking3 commented on a diff
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876704
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -101,9 +102,6 @@ THRIFT_ADD_COMPILER(xml "Enable compiler for XML"
ON)
# we also add the current binary
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876857
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -16,30 +16,30 @@
# specific language governing permissions and limitations
# under the License.
#
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1161#discussion_r96876685
--- Diff: compiler/cpp/CMakeLists.txt ---
@@ -53,6 +53,7 @@ set(compiler_core
set(thrift-compiler_SOURCES
src/thrift/main.cc
src/thrift
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830068#comment-15830068
]
ASF GitHub Bot commented on THRIFT-4034:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15830067#comment-15830067
]
ASF GitHub Bot commented on THRIFT-4034:
Github user jeking3 commented on a diff
[
https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829786#comment-15829786
]
ASF GitHub Bot commented on THRIFT-3926:
Github user lifei commented on the issue
Github user lifei commented on the issue:
https://github.com/apache/thrift/pull/1086
> I think that putting the statusCode into the text description would be
useful here
added
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
[
https://issues.apache.org/jira/browse/THRIFT-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829576#comment-15829576
]
ASF GitHub Bot commented on THRIFT-3926:
Github user RobberPhex commented on the
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1086
status code not equal 200 doesn't means it's a `TApplicationException`.
* When status code is 301/3xx, should thrift client follow the redirect?
* In some server implements, server ret
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15829562#comment-15829562
]
ASF GitHub Bot commented on THRIFT-4034:
Github user RobberPhex commented on the
Github user RobberPhex commented on the issue:
https://github.com/apache/thrift/pull/1161
https://issues.apache.org/jira/browse/THRIFT-4034
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
[
https://issues.apache.org/jira/browse/THRIFT-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Lu updated THRIFT-4034:
--
External issue URL: https://github.com/apache/thrift/pull/1161
> CMake doesn't work to build compiler
>
GitHub user RobberPhex opened a pull request:
https://github.com/apache/thrift/pull/1161
Thrift-4034 CMake doesn't work to build compiler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RobberPhex/thrift THRIFT-4034
Alternativel
Robert Lu created THRIFT-4034:
-
Summary: CMake doesn't work to build compiler
Key: THRIFT-4034
URL: https://issues.apache.org/jira/browse/THRIFT-4034
Project: Thrift
Issue Type: Bug
Com
55 matches
Mail list logo