[jira] [Commented] (THRIFT-2668) TestSuite: detailed result on passed tests by feature

[ https://issues.apache.org/jira/browse/THRIFT-2668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952546#comment-15952546 ] ASF GitHub Bot commented on THRIFT-2668: Github user jeking3 commented on the iss

[GitHub] thrift issue #194: THRIFT-2668 TestSuite: detailed result on passed tests by...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/194 @jfarrell this is marked closed/fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (THRIFT-2721) generate more idiomatic erlang code

[ https://issues.apache.org/jira/browse/THRIFT-2721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952545#comment-15952545 ] ASF GitHub Bot commented on THRIFT-2721: Github user jeking3 commented on the iss

[GitHub] thrift issue #226: THRIFT-2721: reduce complexity of generated erlang code a...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/226 @jfarrell this can be closed; the Jira ticket is resolved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] thrift issue #278: THRIFT-2796: Added testcase for THRIFT-2793. Needs testin...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/278 @jfarrell this can be closed. It was resolved incomplete/later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[jira] [Commented] (THRIFT-2796) Testcase for THRIFT-2793

[ https://issues.apache.org/jira/browse/THRIFT-2796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952544#comment-15952544 ] ASF GitHub Bot commented on THRIFT-2796: Github user jeking3 commented on the iss

[GitHub] thrift issue #328: THRIFT-2899: Prefix enum values with the Cocoa namespace.

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/328 @jfarrell this was resolved as a duplicate. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[jira] [Commented] (THRIFT-2899) Enum values should be prefixed with the Cocoa namespace

[ https://issues.apache.org/jira/browse/THRIFT-2899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952543#comment-15952543 ] ASF GitHub Bot commented on THRIFT-2899: Github user jeking3 commented on the iss

[GitHub] thrift issue #354: THRIFT-2940: Package json

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/354 @jfarrell this was closed fixed a while back. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[jira] [Commented] (THRIFT-2940) Allow installing Thrift from git as NPM module by providing package.json in top level directory

[ https://issues.apache.org/jira/browse/THRIFT-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952542#comment-15952542 ] ASF GitHub Bot commented on THRIFT-2940: Github user jeking3 commented on the iss

[GitHub] thrift issue #356: THRIFT-2941

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/356 @jfarrell this was closed incomplete a while back. The PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (THRIFT-2941) Convert processor to use switch instead of map

[ https://issues.apache.org/jira/browse/THRIFT-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952541#comment-15952541 ] ASF GitHub Bot commented on THRIFT-2941: Github user jeking3 commented on the iss

[jira] [Commented] (THRIFT-2983) Replace use of deprecated -[NSData getBytes:] in -[TNSFileHandleTransport readAll:offset:length:]

[ https://issues.apache.org/jira/browse/THRIFT-2983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952540#comment-15952540 ] ASF GitHub Bot commented on THRIFT-2983: Github user jeking3 commented on the iss

[GitHub] thrift issue #386: THRIFT-2983: replaces deprecated -[NSData getBytes:] with...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/386 @jfarrell this was resolved invalid - please close PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (THRIFT-3088) TThreadPoolServer with Sasl auth may leak CLOSE_WAIT socket

[ https://issues.apache.org/jira/browse/THRIFT-3088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952539#comment-15952539 ] ASF GitHub Bot commented on THRIFT-3088: Github user jeking3 commented on the iss

[GitHub] thrift issue #432: [THRIFT-3088] TThreadPoolServer with Sasl auth may leak C...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/432 @jfarrell this can be closed - it was fixed a while back. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (THRIFT-3121) Librt does not exist on OS X

[ https://issues.apache.org/jira/browse/THRIFT-3121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952538#comment-15952538 ] ASF GitHub Bot commented on THRIFT-3121: Github user jeking3 commented on the iss

[GitHub] thrift issue #475: THRIFT-3121 Librt does not exist on OSX

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/475 @jfarrell this can be closed - it was fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] thrift issue #500: THRIFT-3112: Typed AsyncMethodCallback with return type

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/500 @jfarrell this is closed/fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (THRIFT-3112) [Java] AsyncMethodCallback should be typed in generated AsyncIface

[ https://issues.apache.org/jira/browse/THRIFT-3112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952537#comment-15952537 ] ASF GitHub Bot commented on THRIFT-3112: Github user jeking3 commented on the iss

[GitHub] thrift issue #529: [THRIFT-3204] SimpleServer processRequests method nerver ...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/529 @jfarrell Recommend we close this as won't fix. It never passed and the original author's github repository isn't around any more. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (THRIFT-3154) tutorial/py.tornado throw EOF exception

[ https://issues.apache.org/jira/browse/THRIFT-3154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952536#comment-15952536 ] ASF GitHub Bot commented on THRIFT-3154: Github user jeking3 commented on the iss

[GitHub] thrift issue #501: THRIFT-3154: tornado tutorial fail to work

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/501 @jfarrell this is closed fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[jira] [Commented] (THRIFT-3204) SimpleServer process loop missed handle some error

[ https://issues.apache.org/jira/browse/THRIFT-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952535#comment-15952535 ] ASF GitHub Bot commented on THRIFT-3204: Github user jeking3 commented on the iss

[GitHub] thrift issue #577: THRIFT-3288 c glib build unit tests with all warnings ena...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/577 @jfarrell this is marked closed fixed in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (THRIFT-3288) c_glib: Build unit tests with all warnings enabled, no warnings generated

[ https://issues.apache.org/jira/browse/THRIFT-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952533#comment-15952533 ] ASF GitHub Bot commented on THRIFT-3288: Github user jeking3 commented on the iss

[jira] [Commented] (THRIFT-3357) Additional java compiler option to generate EnumSet/EnumMap where elements/keys are enums

[ https://issues.apache.org/jira/browse/THRIFT-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952532#comment-15952532 ] James E. King, III commented on THRIFT-3357: Any interest in reviving this /

[jira] [Commented] (THRIFT-3380) nodejs: 0.9.2 -> 0.9.3 upgrade breaks Protocol and Transport requires

[ https://issues.apache.org/jira/browse/THRIFT-3380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952531#comment-15952531 ] ASF GitHub Bot commented on THRIFT-3380: Github user jeking3 commented on the iss

[GitHub] thrift issue #639: Implements ssl sockets on c_glib

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/639 @jfarrell this was done in another set of PRs so this can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] thrift issue #651: THRIFT-3380 nodejs Fix broken transport and protocol requ...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/651 @jfarrell this was marked Won't Fix in Jira. This PR can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[jira] [Commented] (THRIFT-3385) warning: format ‘%lu’ expects ‘long unsigned int’, but has type ‘std::basic_string::size_type {aka unsigned int}

[ https://issues.apache.org/jira/browse/THRIFT-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952515#comment-15952515 ] ASF GitHub Bot commented on THRIFT-3385: Github user jeking3 commented on the iss

[GitHub] thrift issue #688: THRIFT-3385 warning: format ‘%lu’ expects ‘long uns...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/688 @jfarrell this issue has been closed/fixed and the pull request can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (THRIFT-2457) fbthrift float

[ https://issues.apache.org/jira/browse/THRIFT-2457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952514#comment-15952514 ] James E. King, III commented on THRIFT-2457: This issue stalled; there's an o

[jira] [Commented] (THRIFT-3474) Docker: thrift-compiler

[ https://issues.apache.org/jira/browse/THRIFT-3474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952509#comment-15952509 ] ASF GitHub Bot commented on THRIFT-3474: Github user jeking3 commented on the iss

[GitHub] thrift issue #733: THRIFT-3474 Docker: thrift-compiler

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/733 @jfarrell this is marked Closed/Fixed in jira; this pull request can be closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (THRIFT-3627) Missing basic code style consistency of JavaScript.

[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952508#comment-15952508 ] James E. King, III commented on THRIFT-3627: This pull request probably needs

[jira] [Commented] (THRIFT-3657) D TFileWriterTransport close should use non-priority send

[ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952507#comment-15952507 ] James E. King, III commented on THRIFT-3657: This issue needs a refresh on th

[GitHub] thrift issue #991: dependency version constraints for haskell

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/991 @jfarrell I checked the current haskell build file and we've already modified it to work the dependencies. This item doesn't have a Jira ticket I can comment on, so this can be closed. --- If your

[GitHub] thrift issue #995: THRIFT-3799 Make constants to use iota

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/995 @jfarrell please close this pull request as it was rejected last year. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[jira] [Commented] (THRIFT-3799) Make constants to use iota

[ https://issues.apache.org/jira/browse/THRIFT-3799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952506#comment-15952506 ] ASF GitHub Bot commented on THRIFT-3799: Github user jeking3 commented on the iss

[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket

[ https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952505#comment-15952505 ] ASF GitHub Bot commented on THRIFT-4154: Github user asfgit closed the pull reque

[GitHub] thrift pull request #1011: Fix bug for php close socket

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1011 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Resolved] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket

[ https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4154. Resolution: Fixed Fix Version/s: 0.11.0 > PHP close() of a TSocket needs to

[GitHub] thrift pull request #1233: THRIFT-4154: properly close socket whether it is ...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket

[ https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952504#comment-15952504 ] ASF GitHub Bot commented on THRIFT-4154: Github user jeking3 commented on the iss

[GitHub] thrift issue #1233: THRIFT-4154: properly close socket whether it is persist...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1233 I logged the build failure as THRIFT-4155 as it appears to be an intermittent test failure. I've seen it twice this week. --- If your project is set up for it, you can reply to this email and have

[jira] [Created] (THRIFT-4155) Unstable D language test has caused some CI build failures

James E. King, III created THRIFT-4155: -- Summary: Unstable D language test has caused some CI build failures Key: THRIFT-4155 URL: https://issues.apache.org/jira/browse/THRIFT-4155 Project: Thrift

[GitHub] thrift issue #1011: Fix bug for php close socket

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1011 Superceded by #1233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] thrift pull request #1233: THRIFT-4154: properly close socket whether it is ...

GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1233 THRIFT-4154: properly close socket whether it is persistent or not on close() Replaces PR #1011. Resubmitting to get a CI build that passes. You can merge this pull request into a Git repository

[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket

[ https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952372#comment-15952372 ] ASF GitHub Bot commented on THRIFT-4154: GitHub user jeking3 opened a pull reques

[jira] [Commented] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket

[ https://issues.apache.org/jira/browse/THRIFT-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952370#comment-15952370 ] ASF GitHub Bot commented on THRIFT-4154: Github user jeking3 commented on the iss

[GitHub] thrift issue #1011: Fix bug for php close socket

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1011 I opened THRIFT-4154 and I am going to submit a second PR for this. If it passes CI builds I can merge it. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Created] (THRIFT-4154) PHP close() of a TSocket needs to close any type of socket

James E. King, III created THRIFT-4154: -- Summary: PHP close() of a TSocket needs to close any type of socket Key: THRIFT-4154 URL: https://issues.apache.org/jira/browse/THRIFT-4154 Project: Thrift

[jira] [Commented] (THRIFT-3828) cmake fails when Boost_INCLUDE_DIRS (and other variables passed to include_directories()) is empty

[ https://issues.apache.org/jira/browse/THRIFT-3828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952368#comment-15952368 ] ASF GitHub Bot commented on THRIFT-3828: Github user jeking3 commented on the iss

[GitHub] thrift issue #1082: THRIFT-3828 In cmake avoid use of both quoted paths and ...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1082 @jfarrell the Jira ticket was resolved as "Won't Fix" here; can you close this PR? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Updated] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4134: --- Fix Version/s: 0.11.0 > Fix remaining undefined behavior invalid vptr casts > ---

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952286#comment-15952286 ] Jens Geyer commented on THRIFT-4134: Thanks Jim! > Fix remaining undefined behavior

[jira] [Commented] (THRIFT-3676) Cocoa server does not emit exceptions

[ https://issues.apache.org/jira/browse/THRIFT-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952276#comment-15952276 ] ASF GitHub Bot commented on THRIFT-3676: Github user jeking3 commented on the iss

[GitHub] thrift issue #896: THRIFT-3676

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/896 I think this should be closed and resubmitted, the history got messed up. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[jira] [Commented] (THRIFT-3686) Java processor should report internal error on uncaught exception

[ https://issues.apache.org/jira/browse/THRIFT-3686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952275#comment-15952275 ] James E. King, III commented on THRIFT-3686: This needs to be refreshed so it

[jira] [Commented] (THRIFT-3730) server log error twice

[ https://issues.apache.org/jira/browse/THRIFT-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952274#comment-15952274 ] ASF GitHub Bot commented on THRIFT-3730: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-3730) server log error twice

[ https://issues.apache.org/jira/browse/THRIFT-3730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3730. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0

[GitHub] thrift pull request #940: THRIFT-3730 server log error twice

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/940 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs

[ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952268#comment-15952268 ] ASF GitHub Bot commented on THRIFT-3784: Github user asfgit closed the pull reque

[GitHub] thrift pull request #984: THRIFT-3784: fix and tests

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/984 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Resolved] (THRIFT-3784) thrift-maven-plugin generates invalid include directories for IDL in dependency JARs

[ https://issues.apache.org/jira/browse/THRIFT-3784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3784. Resolution: Fixed Assignee: James E. King, III Fix Version/s: 0.11.0

[jira] [Commented] (THRIFT-3978) Thrift C++ runtime uses assert to prevent overflows, checks sanity only in debug builds

[ https://issues.apache.org/jira/browse/THRIFT-3978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952261#comment-15952261 ] ASF GitHub Bot commented on THRIFT-3978: Github user jeking3 commented on the iss

[GitHub] thrift issue #1228: THRIFT-3978: tighten up pthread mutex implementation, re...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1228 For anybody interested in reviewing this pull request, I pretty much followed the logic that boost::mutex is using with one exception. In cases where boost ignores an error condition to avoid throw

[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs

[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952260#comment-15952260 ] James E. King, III commented on THRIFT-4152: I merged the open pull request,

[GitHub] thrift pull request #1230: Make a patch to fix #4152 at least for structs

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1230 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Resolved] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jim Apple resolved THRIFT-4134. --- Resolution: Fixed See subtasks for commits that fixed this > Fix remaining undefined behavior invali

[jira] [Commented] (THRIFT-4134) Fix remaining undefined behavior invalid vptr casts

[ https://issues.apache.org/jira/browse/THRIFT-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952258#comment-15952258 ] James E. King, III commented on THRIFT-4134: I merged the third and final sub

[GitHub] thrift pull request #1232: THRIFT-4138: Remove undefined behavior imported f...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1232 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Resolved] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4138. Resolution: Fixed Fix Version/s: 0.11.0 Committed - thanks! > Fix remaining

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952257#comment-15952257 ] ASF GitHub Bot commented on THRIFT-4138: Github user asfgit closed the pull reque

[jira] [Commented] (THRIFT-4140) Use of non-thread-safe function gmtime()

[ https://issues.apache.org/jira/browse/THRIFT-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952253#comment-15952253 ] ASF GitHub Bot commented on THRIFT-4140: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-4140) Use of non-thread-safe function gmtime()

[ https://issues.apache.org/jira/browse/THRIFT-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4140. Resolution: Fixed Fix Version/s: 0.11.0 > Use of non-thread-safe function gm

[GitHub] thrift pull request #1231: THRIFT-4140: fix unsafe call to gmtime

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] thrift issue #1029: THRIFT-3823: Use 'pre' HTML tag when generating non esca...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1029 @jfarrell or @hush-hush could you please close this? There were two pull requests for this Jira ticket and I only put one of them into the "This closes" part of the comment. --- If your project i

[jira] [Commented] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952250#comment-15952250 ] ASF GitHub Bot commented on THRIFT-3823: Github user jeking3 commented on the iss

[jira] [Resolved] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3823. Resolution: Fixed Fix Version/s: 0.11.0 > Escape documentation while generat

[jira] [Updated] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-3823: --- Priority: Minor (was: Major) > Escape documentation while generating non escaped doc

[jira] [Assigned] (THRIFT-3823) Escape documentation while generating non escaped documetation

[ https://issues.apache.org/jira/browse/THRIFT-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-3823: -- Assignee: James E. King, III > Escape documentation while generating non escap

[jira] [Commented] (THRIFT-3859) Unix Domain Socket Support in Objective-C

[ https://issues.apache.org/jira/browse/THRIFT-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952248#comment-15952248 ] ASF GitHub Bot commented on THRIFT-3859: Github user jeking3 commented on the iss

[GitHub] thrift issue #1031: THRIFT-3859: Unix Domain Socket Support in Objective-C

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1031 Have you used this in a project and know that it works? Given this is an improvement I'd like to get it in, but if you don't have time right now to add make cross support, I can add a story in Jira

[jira] [Commented] (THRIFT-3857) thrift js:node complier support an object as parameter not an instance of struct

[ https://issues.apache.org/jira/browse/THRIFT-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952247#comment-15952247 ] James E. King, III commented on THRIFT-3857: Any node.js folks want to commen

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952243#comment-15952243 ] ASF GitHub Bot commented on THRIFT-4138: Github user jbapple-cloudera commented o

[GitHub] thrift issue #1232: THRIFT-4138: Remove undefined behavior imported from Boo...

Github user jbapple-cloudera commented on the issue: https://github.com/apache/thrift/pull/1232 UBSan refuses to report an error more than once, and unfortunately it does not have a way to override this behavior. So, once you've seen one UBSan error at a particular line in a particula

[jira] [Commented] (THRIFT-3944) TSSLSocket has dead code in checkHandshake

[ https://issues.apache.org/jira/browse/THRIFT-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952241#comment-15952241 ] ASF GitHub Bot commented on THRIFT-3944: Github user asfgit closed the pull reque

[jira] [Resolved] (THRIFT-3944) TSSLSocket has dead code in checkHandshake

[ https://issues.apache.org/jira/browse/THRIFT-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-3944. Resolution: Fixed Fix Version/s: 0.11.0 > TSSLSocket has dead code in checkH

[GitHub] thrift pull request #1110: THRIFT-3944 TSSLSocket has dead code in checkHand...

Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs

[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952237#comment-15952237 ] James E. King, III commented on THRIFT-4152: Sorry I thought this was in gene

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952236#comment-15952236 ] ASF GitHub Bot commented on THRIFT-4138: Github user jeking3 commented on the iss

[GitHub] thrift issue #1232: THRIFT-4138: Remove undefined behavior imported from Boo...

Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1232 I'm curious - did every case where lexical_cast was used report this error running in ubsan or was it perhaps just one of them? The original boost defect says, "Undefined behaviour in lexical cast

[jira] [Assigned] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer reassigned THRIFT-4138: -- Assignee: Jim Apple > Fix remaining undefined behavior invalid vptr casts in C++ library > ---

[jira] [Commented] (THRIFT-4138) Fix remaining undefined behavior invalid vptr casts in C++ library

[ https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952207#comment-15952207 ] ASF GitHub Bot commented on THRIFT-4138: GitHub user jbapple-cloudera opened a pu

[GitHub] thrift pull request #1232: THRIFT-4138: Remove undefined behavior imported f...

GitHub user jbapple-cloudera opened a pull request: https://github.com/apache/thrift/pull/1232 THRIFT-4138: Remove undefined behavior imported from Boost Client: C++ There is undefined behavior in boost::lexical_cast that was fixed in https://github.com/boostorg/lexical_

[jira] [Comment Edited] (THRIFT-4152) HTML Documentation doesn't link correctly structs

[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952142#comment-15952142 ] Jens Geyer edited comment on THRIFT-4152 at 4/1/17 9:38 AM: >

[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs

[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952147#comment-15952147 ] Jens Geyer commented on THRIFT-4152: GitHub user gadLinux opened a pull request:

[jira] [Commented] (THRIFT-4152) HTML Documentation doesn't link correctly structs

[ https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952144#comment-15952144 ] ASF GitHub Bot commented on THRIFT-4152: Github user Jens-G commented on the issu

  1   2   >