[GitHub] thrift issue #1254: THRIFT-4177 fix java deep copy

2017-04-18 Thread afds
Github user afds commented on the issue: https://github.com/apache/thrift/pull/1254 Are you sure? I don't really understand what should I update there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15974162#comment-15974162 ] ASF GitHub Bot commented on THRIFT-4177: Github user afds commented on the issue:

[jira] [Closed] (THRIFT-3674) Java generated deep copy is shallow

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-3674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III closed THRIFT-3674. -- Resolution: Duplicate Assignee: James E. King, III Closing as a duplicate of anot

[jira] [Updated] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-4177: --- Affects Version/s: 0.9.2 > Java compiler produces deep copy constructor that could ma

[jira] [Comment Edited] (THRIFT-4176) Implement a threaded and threadpool server type for Rust

2017-04-18 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973260#comment-15973260 ] Allen George edited comment on THRIFT-4176 at 4/18/17 6:44 PM:

[jira] [Commented] (THRIFT-4176) Implement a threaded and threadpool server type for Rust

2017-04-18 Thread Allen George (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973260#comment-15973260 ] Allen George commented on THRIFT-4176: -- [~codesf] That's a very fair point. For some

[jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread Deniss Afonin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973206#comment-15973206 ] Deniss Afonin commented on THRIFT-4177: --- Yes, this issue is definitely a duplicate

[jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973067#comment-15973067 ] James E. King, III commented on THRIFT-4177: Hi, I misread the meaning of the

[jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973063#comment-15973063 ] James E. King, III commented on THRIFT-4177: I just linked a number of issues

[jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973016#comment-15973016 ] ASF GitHub Bot commented on THRIFT-4177: GitHub user afds opened a pull request:

[GitHub] thrift pull request #1254: THRIFT-4177 fix java deep copy

2017-04-18 Thread afds
GitHub user afds opened a pull request: https://github.com/apache/thrift/pull/1254 THRIFT-4177 fix java deep copy Java compiler produces deep copy constructor that could make shallow copy instead. You can merge this pull request into a Git repository by running: $ git pull htt

[jira] [Updated] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2221: --- Issue Type: Improvement (was: Task) > Generate c++ code with std::shared_ptr instead

[jira] [Updated] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III updated THRIFT-2221: --- Priority: Major (was: Minor) > Generate c++ code with std::shared_ptr instead of boo

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972998#comment-15972998 ] James E. King, III commented on THRIFT-2221: It should be fairly easy to to.

[jira] [Assigned] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III reassigned THRIFT-2221: -- Assignee: James E. King, III > Generate c++ code with std::shared_ptr instead

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972900#comment-15972900 ] Mario Emmenlauer commented on THRIFT-2221: -- This looks like a very suitable solu

[GitHub] thrift issue #1247: MSYS-appveyor-install.bat: use mingw-w64-xxx variants

2017-04-18 Thread emmenlau
Github user emmenlau commented on the issue: https://github.com/apache/thrift/pull/1247 Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[jira] [Commented] (THRIFT-4176) Implement a threaded and threadpool server type for Rust

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972819#comment-15972819 ] James E. King, III commented on THRIFT-4176: Sounds like THRIFT-3096. :) > I

[jira] [Commented] (THRIFT-4176) Implement a threaded and threadpool server type for Rust

2017-04-18 Thread Randy Abernethy (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972684#comment-15972684 ] Randy Abernethy commented on THRIFT-4176: - I would argue for a single great rust

[jira] [Commented] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread Deniss Afonin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972648#comment-15972648 ] Deniss Afonin commented on THRIFT-4177: --- Will provide a patch soon. > Java compile

[GitHub] thrift pull request #1247: MSYS-appveyor-install.bat: use mingw-w64-xxx vari...

2017-04-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[jira] [Created] (THRIFT-4177) Java compiler produces deep copy constructor that could make shallow copy instead

2017-04-18 Thread Deniss Afonin (JIRA)
Deniss Afonin created THRIFT-4177: - Summary: Java compiler produces deep copy constructor that could make shallow copy instead Key: THRIFT-4177 URL: https://issues.apache.org/jira/browse/THRIFT-4177 P

[jira] [Resolved] (THRIFT-4158) minor issue in README-MSYS2.md

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James E. King, III resolved THRIFT-4158. Resolution: Fixed Fix Version/s: 0.11.0 > minor issue in README-MSYS2.md > -

[GitHub] thrift issue #1252: [Ruby] Logging server-side exception message on Applicat...

2017-04-18 Thread jeking3
Github user jeking3 commented on the issue: https://github.com/apache/thrift/pull/1252 This looks okay to me, but I don't have any ruby experience; hopefully someone else who does can review it. --- If your project is set up for it, you can reply to this email and have your reply app

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread James E. King, III (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972558#comment-15972558 ] James E. King, III commented on THRIFT-2221: I think it would be better to us

[jira] [Created] (THRIFT-4176) Implement a threaded and threadpool server type for Rust

2017-04-18 Thread Allen George (JIRA)
Allen George created THRIFT-4176: Summary: Implement a threaded and threadpool server type for Rust Key: THRIFT-4176 URL: https://issues.apache.org/jira/browse/THRIFT-4176 Project: Thrift Iss

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-04-18 Thread Mario Emmenlauer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972322#comment-15972322 ] Mario Emmenlauer commented on THRIFT-2221: -- Maybe its possible to have both opti

[GitHub] thrift issue #1247: MSYS-appveyor-install.bat: use mingw-w64-xxx variants

2017-04-18 Thread emmenlau
Github user emmenlau commented on the issue: https://github.com/apache/thrift/pull/1247 Should be working now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes