[jira] [Commented] (THRIFT-4279) Wrong path in include directive in generated Thrift sources

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119236#comment-16119236 ] ASF GitHub Bot commented on THRIFT-4279: Github user dhull commented on the issue

[GitHub] thrift issue #1329: THRIFT-4279: Fix include path in generated Erlang Thrift...

2017-08-08 Thread dhull
Github user dhull commented on the issue: https://github.com/apache/thrift/pull/1329 It appears to me that the AppVeyor build failure is due it a problem with the build machine: ``` CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.8/Modules/FindPackageHandleStandardAr

[jira] [Commented] (THRIFT-4279) Wrong path in include directive in generated Thrift sources

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119145#comment-16119145 ] ASF GitHub Bot commented on THRIFT-4279: Github user djnym commented on the issue

[GitHub] thrift issue #1329: THRIFT-4279: Fix include path in generated Erlang Thrift...

2017-08-08 Thread djnym
Github user djnym commented on the issue: https://github.com/apache/thrift/pull/1329 @Jens-G this probably needs to be merged assuming it passes the checks as we don't want to generate bad code. --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (THRIFT-4279) Wrong path in include directive in generated Thrift sources

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16119008#comment-16119008 ] ASF GitHub Bot commented on THRIFT-4279: GitHub user dhull opened a pull request:

[GitHub] thrift pull request #1329: THRIFT-4279: Fix include path in generated Erlang...

2017-08-08 Thread dhull
GitHub user dhull opened a pull request: https://github.com/apache/thrift/pull/1329 THRIFT-4279: Fix include path in generated Erlang Thrift sources. The change in THRIFT-4270 inadvertantly modified the include directives in the generated Erlang sources to include the gen-erl direct

[jira] [Updated] (THRIFT-4279) Wrong path in include directive in generated Thrift sources

2017-08-08 Thread David Hull (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Hull updated THRIFT-4279: --- Description: My code change in THRIFT-4270 introduced a bug in the path to the generated header file

[jira] [Created] (THRIFT-4280) Add async nonblocking ssl support in java client

2017-08-08 Thread Randy Abernethy (JIRA)
Randy Abernethy created THRIFT-4280: --- Summary: Add async nonblocking ssl support in java client Key: THRIFT-4280 URL: https://issues.apache.org/jira/browse/THRIFT-4280 Project: Thrift Issue

[jira] [Updated] (THRIFT-4277) Cannot get any data value using node.js

2017-08-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4277: --- Description: When using Thift to generate js code, all property value are `undefined`, because of an

[jira] [Commented] (THRIFT-4277) Cannot get any data value using node.js

2017-08-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118949#comment-16118949 ] Jens Geyer commented on THRIFT-4277: Are you able to [provide a patch or pull reques

[jira] [Updated] (THRIFT-4278) Thrift Node.js library crashes app

2017-08-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4278: --- Description: Create TBufferedTransport by using its receiver funciton. and using TCompactProtocol to

[jira] [Updated] (THRIFT-4278) Thrift Node.js library crashes app

2017-08-08 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-4278: --- Description: Create TBufferedTransport by using its receiver funciton. and using TCompactProtocol to

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118943#comment-16118943 ] ASF GitHub Bot commented on THRIFT-2221: Github user jeking3 commented on a diff

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132017398 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118931#comment-16118931 ] ASF GitHub Bot commented on THRIFT-2221: Github user jeking3 commented on a diff

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118932#comment-16118932 ] ASF GitHub Bot commented on THRIFT-2221: Github user jeking3 commented on a diff

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132013921 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118928#comment-16118928 ] ASF GitHub Bot commented on THRIFT-2221: Github user jeking3 commented on a diff

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132013793 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread jeking3
Github user jeking3 commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r132013676 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118758#comment-16118758 ] ASF GitHub Bot commented on THRIFT-2221: Github user octopus-prime commented on a

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread octopus-prime
Github user octopus-prime commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131985807 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118751#comment-16118751 ] ASF GitHub Bot commented on THRIFT-2221: Github user octopus-prime commented on a

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread octopus-prime
Github user octopus-prime commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131985042 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[jira] [Created] (THRIFT-4279) Wrong path in include directive in generated Thrift sources

2017-08-08 Thread David Hull (JIRA)
David Hull created THRIFT-4279: -- Summary: Wrong path in include directive in generated Thrift sources Key: THRIFT-4279 URL: https://issues.apache.org/jira/browse/THRIFT-4279 Project: Thrift Iss

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118619#comment-16118619 ] ASF GitHub Bot commented on THRIFT-2221: Github user hcorg commented on a diff in

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131968863 --- Diff: lib/cpp/src/thrift/stdcxx.h --- @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contribu

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118614#comment-16118614 ] ASF GitHub Bot commented on THRIFT-2221: Github user hcorg commented on a diff in

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131968203 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared p

[jira] [Commented] (THRIFT-2221) Generate c++ code with std::shared_ptr instead of boost::shared_ptr.

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118603#comment-16118603 ] ASF GitHub Bot commented on THRIFT-2221: Github user hcorg commented on a diff in

[GitHub] thrift pull request #1328: THRIFT-2221: detect C++11 and use std namespace f...

2017-08-08 Thread hcorg
Github user hcorg commented on a diff in the pull request: https://github.com/apache/thrift/pull/1328#discussion_r131966861 --- Diff: lib/cpp/README.md --- @@ -55,15 +54,22 @@ you are using libthriftnb you will also need libevent. ## Dependencies -boost shared p

[jira] [Commented] (THRIFT-4233) Make THsHaServer.invoker available (get method only) in inherited classes

2017-08-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118577#comment-16118577 ] ASF GitHub Bot commented on THRIFT-4233: Github user dmvolod commented on the iss

[GitHub] thrift issue #1294: THRIFT-4233 Make THsHaServer.invoker available (get meth...

2017-08-08 Thread dmvolod
Github user dmvolod commented on the issue: https://github.com/apache/thrift/pull/1294 Is there any chance to review this changes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature