Re: What to do when CI tests fail for reasons (manifestly) unrelated to PR?

2017-12-18 Thread Chet Murthy
Gracias! I'll run it locally, and only then do as you suggest. Cheers, --chet-- On Mon, Dec 18, 2017 at 3:41 PM, James E. King, III wrote: > There are many reasons, and it's a constant battle. Either the tests are > flaky or the environment may have changed. > If you do a "commit --amend --n

Re: What to do when CI tests fail for reasons (manifestly) unrelated to PR?

2017-12-18 Thread James E. King, III
There are many reasons, and it's a constant battle. Either the tests are flaky or the environment may have changed. If you do a "commit --amend --no-edit" and then force push, it will kick a new build. - Jim On Mon, Dec 18, 2017 at 4:30 PM, Chet Murthy wrote: > I've had a couple instances wher

What to do when CI tests fail for reasons (manifestly) unrelated to PR?

2017-12-18 Thread Chet Murthy
I've had a couple instances where a Travis CI test will fail for reasons that clearly aren't related to the PR I've submitted. In today's case, the "cross-test" failed while building dart-related code, and my PR was *only* in the C++ "compiler plugin" area. Almost all the other Travis tests have

[jira] [Commented] (THRIFT-4230) Thrift server connection may hang forever

2017-12-18 Thread Jeremy Egenberger (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295464#comment-16295464 ] Jeremy Egenberger commented on THRIFT-4230: --- Thanks [~chet...@gmail.com] and [~

[jira] [Updated] (THRIFT-4429) Make TThreadPoolServer.executorService_ available in inherited classes and refactor methods to be able customization

2017-12-18 Thread Dmitry Volodin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Volodin updated THRIFT-4429: --- Summary: Make TThreadPoolServer.executorService_ available in inherited classes and refactor

[jira] [Commented] (THRIFT-4250) 0.11.0 release candidate (was: Please release 0.10.1 with fix for THRIFT-4062)

2017-12-18 Thread Christopher Tubbs (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294980#comment-16294980 ] Christopher Tubbs commented on THRIFT-4250: --- [~jensg]. I'm finding it difficult

[jira] [Commented] (THRIFT-4429) Make TThreadPoolServer.invoker available in inherited classes and refactor methods to be able customization

2017-12-18 Thread Dmitry Volodin (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294823#comment-16294823 ] Dmitry Volodin commented on THRIFT-4429: I'm ready to add code as PR. > Make TTh

[jira] [Created] (THRIFT-4429) Make TThreadPoolServer.invoker available in inherited classes and refactor methods to be able customization

2017-12-18 Thread Dmitry Volodin (JIRA)
Dmitry Volodin created THRIFT-4429: -- Summary: Make TThreadPoolServer.invoker available in inherited classes and refactor methods to be able customization Key: THRIFT-4429 URL: https://issues.apache.org/jira/brows

[GitHub] thrift pull request #1446: Insert files related to eclipse project to gitign...

2017-12-18 Thread dmvolod
GitHub user dmvolod opened a pull request: https://github.com/apache/thrift/pull/1446 Insert files related to eclipse project to gitignore You can merge this pull request into a Git repository by running: $ git pull https://github.com/dmvolod/thrift gitignore-add Alternativel

[jira] [Created] (THRIFT-4428) Release 0.10.1 with fix for THRIFT-4062

2017-12-18 Thread Jens Geyer (JIRA)
Jens Geyer created THRIFT-4428: -- Summary: Release 0.10.1 with fix for THRIFT-4062 Key: THRIFT-4428 URL: https://issues.apache.org/jira/browse/THRIFT-4428 Project: Thrift Issue Type: Task

[jira] [Commented] (THRIFT-4250) 0.11.0 release candidate (was: Please release 0.10.1 with fix for THRIFT-4062)

2017-12-18 Thread Jens Geyer (JIRA)
[ https://issues.apache.org/jira/browse/THRIFT-4250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294627#comment-16294627 ] Jens Geyer commented on THRIFT-4250: [~ctubbsii], what are these breaking changes th