[jira] [Resolved] (THRIFT-5178) THttpClient should work without specifying host

2020-04-21 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5178. Fix Version/s: 0.14.0 Resolution: Fixed > THttpClient should work without specifying host >

[GitHub] [thrift] Jens-G commented on issue #2094: THRIFT-5109: Misc CMake build improvements

2020-04-21 Thread GitBox
Jens-G commented on issue #2094: URL: https://github.com/apache/thrift/pull/2094#issuecomment-617425716 @janosvitok comments from your side? This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Resolved] (THRIFT-5168) Useless generated code when .thrift file only has service type

2020-04-21 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer resolved THRIFT-5168. Fix Version/s: 0.14.0 Resolution: Fixed > Useless generated code when .thrift file only has

[GitHub] [thrift] emmenlau opened a new pull request #2106: Added isOpen() to TServerTransport

2020-04-21 Thread GitBox
emmenlau opened a new pull request #2106: URL: https://github.com/apache/thrift/pull/2106 This PR adds a new method isOpen() to the TServerTransport and implementations TServerSocket and TPipeServer. I've added tests for TServerSocket and tested on a number of platforms. The change is rath

[jira] [Created] (THRIFT-5181) Add tests for TPipe based implementation

2020-04-21 Thread Mario Emmenlauer (Jira)
Mario Emmenlauer created THRIFT-5181: Summary: Add tests for TPipe based implementation Key: THRIFT-5181 URL: https://issues.apache.org/jira/browse/THRIFT-5181 Project: Thrift Issue Type:

[jira] [Commented] (THRIFT-3238) Fix TNamedPipeServer can be interrupted by faulty client

2020-04-21 Thread Mario Emmenlauer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-3238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088762#comment-17088762 ] Mario Emmenlauer commented on THRIFT-3238: -- What is required to proceed with th

[GitHub] [thrift] emmenlau commented on issue #2105: THRIFT-5178: Added constructor with default host localhost

2020-04-21 Thread GitBox
emmenlau commented on issue #2105: URL: https://github.com/apache/thrift/pull/2105#issuecomment-617121615 This may require a bit of review and discussion. Are the proposed changes good? This is an automated message from the

[GitHub] [thrift] emmenlau commented on issue #2094: THRIFT-5109: Misc CMake build improvements

2020-04-21 Thread GitBox
emmenlau commented on issue #2094: URL: https://github.com/apache/thrift/pull/2094#issuecomment-617121345 Ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [thrift] zeshuai007 commented on issue #2095: THRIFT-5168: Useless generated code when .thrift file only has service type

2020-04-21 Thread GitBox
zeshuai007 commented on issue #2095: URL: https://github.com/apache/thrift/pull/2095#issuecomment-617109330 @Jens-G , done. This is an automated message from the Apache Git Service. To respond to the message, please log on to