Re: Spammy gitbox

2020-04-28 Thread Christopher
A notifications@ list would be nice for JIRA automated notices, too... there's a lot of spam from JIRA on the thrift dev list, but it's currently a lot less than what GitHub/GitBox has been doing lately. IMO, the dev@ list should really promote human-to-human conversations about development activit

Re: Spammy gitbox

2020-04-28 Thread Christopher
I think it'd be better to create a separate list. commits@ should really be reserved for auditing code changes, and not other activity. It's an easy ticket for INFRA to satisfy to create a new notifications@ list. Such a list could also be used for Jenkins builds or other integrations that cause au

Re: Spammy gitbox

2020-04-28 Thread Jens Geyer
What's wrong with using commits? Sometimes ... -Ursprüngliche Nachricht- From: Christopher Sent: Tuesday, April 28, 2020 2:34 AM To: dev@thrift.apache.org Cc: Jens Geyer ; Daniel Gruno ; Users Subject: Re: Spammy gitbox It doesn't look like Thrift has a separate notifications list. I r

[GitHub] [thrift] dugenkui03 opened a new pull request #2125: StringUtils haven't take into account

2020-04-28 Thread GitBox
dugenkui03 opened a new pull request #2125: URL: https://github.com/apache/thrift/pull/2125 1. StringUtils haven't take `(offset + length)` > bytes.length'; 2. `if ((offset | length | (offset + length) | (size - (offset + length))) < 0)` will faster than `>`

[jira] [Created] (THRIFT-5190) StringUtils haven't take `(offset + length) > bytes.length` into account

2020-04-28 Thread dugenkui (Jira)
dugenkui created THRIFT-5190: Summary: StringUtils haven't take `(offset + length) > bytes.length` into account Key: THRIFT-5190 URL: https://issues.apache.org/jira/browse/THRIFT-5190 Project: Thrift

Re: [DISCUSS] AS3 anyone?

2020-04-28 Thread Randy Abernethy
I would +1 retiring it. Perhaps deprecate it in the next release and then remove in the one after that. On Tue, Apr 28, 2020 at 12:10 AM Jens Geyer wrote: > Hi all, > > we had have long time no commits or contributions for the AS3 support in > Thrift. > > Therefore, I’d like to ask the question

[GitHub] [thrift] ulidtko commented on pull request #2124: THRIFT-5186: Don't pass AI_ADDRCONFIG to getaddrinfo()

2020-04-28 Thread GitBox
ulidtko commented on pull request #2124: URL: https://github.com/apache/thrift/pull/2124#issuecomment-620614059 Oh well, Travis fell down this time. The only indication of whats wrong in the logs: > make[4]: *** [all-local] Segmentation fault (core dumped) That's kind of int

[jira] [Updated] (THRIFT-5189) C++: Improve the namespace format of the code which generated by the thrift compiler

2020-04-28 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zezeng Wang updated THRIFT-5189: Description: test.thrift as below: namespace cpp AA.BB.CC.DD.EE.FF st

[jira] [Updated] (THRIFT-5189) C++: Improve the namespace format of the code which generated by the thrift compiler

2020-04-28 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zezeng Wang updated THRIFT-5189: Description: test.thrift as below: namespace cpp AA.BB.CC.DD.EE.FF st

[jira] [Assigned] (THRIFT-5189) C++: Improve the namespace format of the code which generated by the thrift compiler

2020-04-28 Thread Zezeng Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zezeng Wang reassigned THRIFT-5189: --- Assignee: Zezeng Wang > C++: Improve the namespace format of the code which generated by th

[jira] [Created] (THRIFT-5189) C++: Improve the namespace format of the code which generated by the thrift compiler

2020-04-28 Thread Zezeng Wang (Jira)
Zezeng Wang created THRIFT-5189: --- Summary: C++: Improve the namespace format of the code which generated by the thrift compiler Key: THRIFT-5189 URL: https://issues.apache.org/jira/browse/THRIFT-5189 Pr

[GitHub] [thrift] stale[bot] commented on pull request #2007: THRIFT-5093: TMemoryBuffer constructor initializes wpos incorrectly

2020-04-28 Thread GitBox
stale[bot] commented on pull request #2007: URL: https://github.com/apache/thrift/pull/2007#issuecomment-620540372 This issue is no longer stale. Thank you for your contributions. This is an automated message from the Apa

[GitHub] [thrift] cfriedt commented on pull request #2007: THRIFT-5093: TMemoryBuffer constructor initializes wpos incorrectly

2020-04-28 Thread GitBox
cfriedt commented on pull request #2007: URL: https://github.com/apache/thrift/pull/2007#issuecomment-620540339 pushing back again, sorry This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [thrift] ulidtko commented on pull request #2124: THRIFT-5186: Don't pass AI_ADDRCONFIG to getaddrinfo()

2020-04-28 Thread GitBox
ulidtko commented on pull request #2124: URL: https://github.com/apache/thrift/pull/2124#issuecomment-620479569 Yea, indeed. Thanks! I've amended the patch. This is an automated message from the Apache Git Service. To respond

[DISCUSS] AS3 anyone?

2020-04-28 Thread Jens Geyer
Hi all, we had have long time no commits or contributions for the AS3 support in Thrift. Therefore, I’d like to ask the question what the community thinks about this particular piece of the code base. a) Is anyone out there who is still using Action Script? b) What would be the consensus if I