[GitHub] [thrift] fishy opened a new pull request #2309: THRIFT-5338: Raise minimal supported go version to 1.14.13

2021-01-19 Thread GitBox
fishy opened a new pull request #2309: URL: https://github.com/apache/thrift/pull/2309 Client: go - Update Dockerfiles used by travis - Add go.mod file - Modify error handling code to take advantage of errors package updates in go1.13 -

[GitHub] [thrift] fishy merged pull request #2308: THRIFT-5326: Make PrependError more unwrap-able

2021-01-19 Thread GitBox
fishy merged pull request #2308: URL: https://github.com/apache/thrift/pull/2308 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Comment Edited] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268065#comment-17268065 ] Duru Can Celasun edited comment on THRIFT-5338 at 1/19/21, 5:35 PM: --

[jira] [Updated] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxuan Wang updated THRIFT-5338: Description: Currently (as of 0.13.0), the minimal supported Go version is 1.10.8, which is the l

[jira] [Commented] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Duru Can Celasun (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268065#comment-17268065 ] Duru Can Celasun commented on THRIFT-5338: -- I'm happy to go for 1.14x. It has b

[GitHub] [thrift] fishy opened a new pull request #2308: THRIFT-5326: Make PrependError more unwrap-able

2021-01-19 Thread GitBox
fishy opened a new pull request #2308: URL: https://github.com/apache/thrift/pull/2308 Client: go As a follow up to https://github.com/apache/thrift/pull/2298, make the error returned by PrependError unwrap-able in certain cases. --

[jira] [Commented] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17268046#comment-17268046 ] Yuxuan Wang commented on THRIFT-5338: - [~dcelasun] [~jensg] what are your thoughts o

[jira] [Created] (THRIFT-5338) Proposal: Raise minimal supported Go version with upcoming 0.14.0 release

2021-01-19 Thread Yuxuan Wang (Jira)
Yuxuan Wang created THRIFT-5338: --- Summary: Proposal: Raise minimal supported Go version with upcoming 0.14.0 release Key: THRIFT-5338 URL: https://issues.apache.org/jira/browse/THRIFT-5338 Project: Thri

[GitHub] [thrift] BytedanceRPC opened a new pull request #2307: THRIFT-5337 Go set fields write improvement

2021-01-19 Thread GitBox
BytedanceRPC opened a new pull request #2307: URL: https://github.com/apache/thrift/pull/2307 There is a duplicate elements check for set in `writeFields*` function, and it compares elements using `reflect.DeepEqual` which is expensive. It's much faster that generates a "DeepE

[jira] [Created] (THRIFT-5337) Go set fields write improvement

2021-01-19 Thread BytedanceRPC (Jira)
BytedanceRPC created THRIFT-5337: Summary: Go set fields write improvement Key: THRIFT-5337 URL: https://issues.apache.org/jira/browse/THRIFT-5337 Project: Thrift Issue Type: Improvement

[GitHub] [thrift] sveneld opened a new pull request #2306: THRIFT-5336 Add possibility to setup connection timeout in TCurlClient

2021-01-19 Thread GitBox
sveneld opened a new pull request #2306: URL: https://github.com/apache/thrift/pull/2306 Add possibility to setup connection timeout in TCurlClient In TCurlClient we can set only total timeout, it will be great to have opportunity to set connection timeout - [+] Did

[jira] [Created] (THRIFT-5336) Add possibility to setup connection timeout in TCurlClient

2021-01-19 Thread Volodymyr Panivko (Jira)
Volodymyr Panivko created THRIFT-5336: - Summary: Add possibility to setup connection timeout in TCurlClient Key: THRIFT-5336 URL: https://issues.apache.org/jira/browse/THRIFT-5336 Project: Thrift