Jens-G closed pull request #2370:
URL: https://github.com/apache/thrift/pull/2370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/THRIFT-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317723#comment-17317723
]
Jens Geyer commented on THRIFT-5394:
@all: Would it be safe to simply upgrade the sc
Jens Geyer created THRIFT-5394:
--
Summary: AppVeyor CI tries to download outdated cmake
Key: THRIFT-5394
URL: https://issues.apache.org/jira/browse/THRIFT-5394
Project: Thrift
Issue Type: Bug
Jens-G opened a new pull request #2370:
URL: https://github.com/apache/thrift/pull/2370
Client: hx
Patch: Jens Geyer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/THRIFT-5393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5393:
---
Attachment: (was: BugTwo.thrift)
> Incorrect namespaces for included types
> ---
[
https://issues.apache.org/jira/browse/THRIFT-5393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5393:
---
Attachment: BugTwo.thrift
BugOne.thrift
> Incorrect namespaces for included types
>
[
https://issues.apache.org/jira/browse/THRIFT-5393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5393:
---
Attachment: (was: BugOne.thrift)
> Incorrect namespaces for included types
> ---
[
https://issues.apache.org/jira/browse/THRIFT-5393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Geyer updated THRIFT-5393:
---
Attachment: BugTwo.thrift
BugOne.thrift
> Incorrect namespaces for included types
>
Jens Geyer created THRIFT-5393:
--
Summary: Incorrect namespaces for included types
Key: THRIFT-5393
URL: https://issues.apache.org/jira/browse/THRIFT-5393
Project: Thrift
Issue Type: Bug
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuele Maci updated THRIFT-5392:
-
Description:
I'm starting using thrift interfaces in rust and I've been surprised to
discover t
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317119#comment-17317119
]
Samuele Maci edited comment on THRIFT-5392 at 4/8/21, 2:29 PM:
---
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317234#comment-17317234
]
Samuele Maci commented on THRIFT-5392:
--
{quote}I avoided doing this because names i
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317119#comment-17317119
]
Samuele Maci edited comment on THRIFT-5392 at 4/8/21, 2:27 PM:
---
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317119#comment-17317119
]
Samuele Maci commented on THRIFT-5392:
--
I was writing specifically about the commen
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317112#comment-17317112
]
Allen George edited comment on THRIFT-5392 at 4/8/21, 11:38 AM:
--
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317114#comment-17317114
]
Allen George commented on THRIFT-5392:
--
This is a separate concern for a separate t
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317114#comment-17317114
]
Allen George edited comment on THRIFT-5392 at 4/8/21, 11:37 AM:
--
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317112#comment-17317112
]
Allen George commented on THRIFT-5392:
--
Also note that your concern:
{noformat}
//
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317108#comment-17317108
]
Allen George commented on THRIFT-5392:
--
Link to the comment where I considered it:
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317107#comment-17317107
]
Allen George edited comment on THRIFT-5392 at 4/8/21, 11:28 AM:
--
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317107#comment-17317107
]
Allen George commented on THRIFT-5392:
--
I considered using a sentinel value, but no
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuele Maci updated THRIFT-5392:
-
Summary: Thrift Enums should generate forward compatible enum like code
(was: Thrift Enums shou
[
https://issues.apache.org/jira/browse/THRIFT-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Samuele Maci updated THRIFT-5392:
-
Component/s: Rust - Library
> Thrift Enums should generate enum like code
>
Samuele Maci created THRIFT-5392:
Summary: Thrift Enums should generate enum like code
Key: THRIFT-5392
URL: https://issues.apache.org/jira/browse/THRIFT-5392
Project: Thrift
Issue Type: Impr
unfetteredwind opened a new pull request #2369:
URL: https://github.com/apache/thrift/pull/2369
- [ ] Did you create an [Apache
Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not
required for trivial changes)
- [ ] If a ticket exists: Does
25 matches
Mail list logo
