[jira] [Updated] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5448: --- Labels: typescript (was: Breaking-Change typescript) > Wrong type mapping of thrift binary type > -

[jira] [Comment Edited] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392663#comment-17392663 ] 刘正元 edited comment on THRIFT-5448 at 8/4/21, 2:46 AM: -- It is actual

[jira] [Comment Edited] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392663#comment-17392663 ] 刘正元 edited comment on THRIFT-5448 at 8/4/21, 2:46 AM: -- It is actual

[jira] [Comment Edited] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392663#comment-17392663 ] 刘正元 edited comment on THRIFT-5448 at 8/4/21, 2:46 AM: -- It is actual

[jira] [Commented] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392663#comment-17392663 ] 刘正元 commented on THRIFT-5448: - It is actually accepting and returning {{Buffer}}s, only the

Re: partial deserialization of Thrift

2021-08-03 Thread Bhalchandra Pandit
I have added basic set of files at the location below. Currently they are unchanged from their Pinterest version. I would like to get some guidance on the type of changes I should make. All of them have many tests though they are not included in this initial skeleton for now. https://github.com/bh

[jira] [Commented] (THRIFT-5443) add support for partial deserialization of Thrift

2021-08-03 Thread Bhalchandra Pandit (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392624#comment-17392624 ] Bhalchandra Pandit commented on THRIFT-5443: I have added basic set of files

Re: Branch for 0.15.0 ahead

2021-08-03 Thread Jens Geyer
Hi all, branch for 0.15.0 has been made. I’m going to prepare the release packages and send out the vote emails at some point in the next weeks, when some sort of consensus emerged that we are finally ready and did not overlook something important. Have fun, JensG From: Jens Geyer Sent: F

[jira] [Commented] (THRIFT-5447) Update supported Go versions before 0.15.0 release

2021-08-03 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392516#comment-17392516 ] Yuxuan Wang commented on THRIFT-5447: - [~jensg] we'll certainly check the travis res

[jira] [Comment Edited] (THRIFT-5401) MaxMessageSize reached exception thrown in TEndpointTransport

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392509#comment-17392509 ] Jens Geyer edited comment on THRIFT-5401 at 8/3/21, 8:08 PM: -

[jira] [Commented] (THRIFT-5401) MaxMessageSize reached exception thrown in TEndpointTransport

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392509#comment-17392509 ] Jens Geyer commented on THRIFT-5401: May I ask for a reproducible testcase and/opr t

[jira] [Comment Edited] (THRIFT-5401) MaxMessageSize reached exception thrown in TEndpointTransport

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392509#comment-17392509 ] Jens Geyer edited comment on THRIFT-5401 at 8/3/21, 8:07 PM: -

[jira] [Updated] (THRIFT-5401) MaxMessageSize reached exception thrown in TEndpointTransport

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5401: --- Fix Version/s: (was: 0.14.1) > MaxMessageSize reached exception thrown in TEndpointTransport > -

[jira] [Commented] (THRIFT-5427) Thrift v0.14.1 contains dependecy to vulnerable `ws` module

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392507#comment-17392507 ] Jens Geyer commented on THRIFT-5427: Since you left very few information besides the

[jira] [Updated] (THRIFT-5427) Thrift v0.14.1 contains dependecy to vulnerable `ws` module

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5427: --- Component/s: Node.js - Library > Thrift v0.14.1 contains dependecy to vulnerable `ws` module > -

[jira] [Updated] (THRIFT-5418) C++ to_string and ostream operator not generated always generated

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5418: --- Summary: C++ to_string and ostream operator not generated always generated (was: C++: to_string and

[jira] [Updated] (THRIFT-5418) C++ to_string and ostream operator not generated always generated

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Geyer updated THRIFT-5418: --- Component/s: C++ - Compiler > C++ to_string and ostream operator not generated always generated > --

[jira] [Commented] (THRIFT-5447) Update supported Go versions before 0.15.0 release

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392503#comment-17392503 ] Jens Geyer commented on THRIFT-5447: PS: I read "right before the release " as "we w

[jira] [Commented] (THRIFT-5447) Update supported Go versions before 0.15.0 release

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392496#comment-17392496 ] Jens Geyer commented on THRIFT-5447: {quote} This task is to be done right before th

[jira] [Commented] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jens Geyer (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392491#comment-17392491 ] Jens Geyer commented on THRIFT-5448: As a suggestion, the breaking change could be m

[jira] [Updated] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 刘正元 updated THRIFT-5448: Labels: Breaking-Change typescript (was: typescript) > Wrong type mapping of thrift binary type > ---

[GitHub] [thrift] OpportunityLiu opened a new pull request #2428: THRIFT-5448: map binary to typescript Buffer

2021-08-03 Thread GitBox
OpportunityLiu opened a new pull request #2428: URL: https://github.com/apache/thrift/pull/2428 Client: js Author: OpportunityLiu - [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial

[jira] [Updated] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 刘正元 updated THRIFT-5448: Description: thrift binary type should be mapped to {{Buffer}} in type definition. Currently, it is mapped to stri

[jira] [Updated] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
[ https://issues.apache.org/jira/browse/THRIFT-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 刘正元 updated THRIFT-5448: Description: thrift binary type should be mapped to `Buffer` in type definition. Currently, it is mapped to string

[jira] [Created] (THRIFT-5448) Wrong type mapping of thrift binary type

2021-08-03 Thread Jira
刘正元 created THRIFT-5448: --- Summary: Wrong type mapping of thrift binary type Key: THRIFT-5448 URL: https://issues.apache.org/jira/browse/THRIFT-5448 Project: Thrift Issue Type: Bug Components: