dcelasun merged pull request #2427:
URL: https://github.com/apache/thrift/pull/2427
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr..
[
https://issues.apache.org/jira/browse/THRIFT-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang updated THRIFT-5453:
Component/s: Go - Library
> go: NewTSocketConf should not call net.ResolveTCPAddr
> --
[
https://issues.apache.org/jira/browse/THRIFT-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang updated THRIFT-5453:
Affects Version/s: 0.14.2
> go: NewTSocketConf should not call net.ResolveTCPAddr
> --
[
https://issues.apache.org/jira/browse/THRIFT-5453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yuxuan Wang reassigned THRIFT-5453:
---
Assignee: Yuxuan Wang
> go: NewTSocketConf should not call net.ResolveTCPAddr
> ---
fishy opened a new pull request #2435:
URL: https://github.com/apache/thrift/pull/2435
Client: go
We used to do DNS lookups in NewTSocketConf, without any timeout checks.
Stop doing that and do DNS lookups in TSocket.Open instead, which
already checks for ConnectTimeout set in T
Yuxuan Wang created THRIFT-5453:
---
Summary: go: NewTSocketConf should not call net.ResolveTCPAddr
Key: THRIFT-5453
URL: https://issues.apache.org/jira/browse/THRIFT-5453
Project: Thrift
Issue Ty
[
https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395887#comment-17395887
]
Mario Emmenlauer commented on THRIFT-5451:
--
Or anyone else jumping in?
> Thrif
[
https://issues.apache.org/jira/browse/THRIFT-5451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395886#comment-17395886
]
Mario Emmenlauer commented on THRIFT-5451:
--
{quote}This can easily be solved by
