[jira] [Commented] (THRIFT-5457) Travis fails consistently on a Rust dependency

2021-09-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412308#comment-17412308 ] Allen George commented on THRIFT-5457: -- >From reading [this|https://issuehunt.io/r/

[GitHub] [thrift] allengeorge opened a new pull request #2454: THRIFT-5457 Pin bitflags to 1.2 to maintain MSRV

2021-09-08 Thread GitBox
allengeorge opened a new pull request #2454: URL: https://github.com/apache/thrift/pull/2454 Client: rs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Commented] (THRIFT-5457) Travis fails consistently on a Rust dependency

2021-09-08 Thread Allen George (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412301#comment-17412301 ] Allen George commented on THRIFT-5457: -- Really puzzled what's going on here, and wh

[GitHub] [thrift] allengeorge merged pull request #2443: Remove redundant `format!(..)` macro calls

2021-09-08 Thread GitBox
allengeorge merged pull request #2443: URL: https://github.com/apache/thrift/pull/2443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubsc

[jira] [Commented] (THRIFT-5461) Invalid golang code generated for optional set with a default value

2021-09-08 Thread Yuri Melnikov (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412235#comment-17412235 ] Yuri Melnikov commented on THRIFT-5461: --- [~fishywang] My issue is a bit different.

[jira] [Commented] (THRIFT-5461) Invalid golang code generated for optional set with a default value

2021-09-08 Thread Yuri Melnikov (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412233#comment-17412233 ] Yuri Melnikov commented on THRIFT-5461: --- Created PR: https://github.com/apache/thr

[GitHub] [thrift] vernor1 opened a new pull request #2453: THRIFT-4868: Golang: Fix compilation for optional set with default values

2021-09-08 Thread GitBox
vernor1 opened a new pull request #2453: URL: https://github.com/apache/thrift/pull/2453 - [X] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes) - [X] If a ticket exists: Does your pu

[jira] [Commented] (THRIFT-5461) Invalid golang code generated for optional set with a default value

2021-09-08 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412214#comment-17412214 ] Yuxuan Wang commented on THRIFT-5461: - While trying to fix this I discovered another

[jira] [Updated] (THRIFT-5461) Invalid golang code generated for optional set with a default value

2021-09-08 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxuan Wang updated THRIFT-5461: Affects Version/s: 0.15.0 > Invalid golang code generated for optional set with a default value >

Re: [VOTE] Apache Thrift 0.15.0-rc0 release candidate

2021-09-08 Thread Yuxuan Wang
Nevermind my previous email. The fix is not as straightforward as I thought, so it's better to fix it properly in 0.16.0 instead. Still +1. On Wed, Sep 8, 2021 at 2:50 PM Yuxuan Wang wrote: > Unless someone feels strongly, I'd change my vote to -1 and fix > https://issues.apache.org/jira/browse

[jira] [Commented] (THRIFT-5461) Invalid golang code generated for optional set with a default value

2021-09-08 Thread Yuxuan Wang (Jira)
[ https://issues.apache.org/jira/browse/THRIFT-5461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17412201#comment-17412201 ] Yuxuan Wang commented on THRIFT-5461: - Thanks for the report. Verified that this sti

Re: [VOTE] Apache Thrift 0.15.0-rc0 release candidate

2021-09-08 Thread Yuxuan Wang
Unless someone feels strongly, I'd change my vote to -1 and fix https://issues.apache.org/jira/browse/THRIFT-5461 first (which should be a few days). On Wed, Sep 8, 2021 at 1:28 PM Allen George wrote: > +1 > --- > > Terminal Musings: http://www.allengeorge.com/ > Twitter: https://twitter.com/all

[jira] [Created] (THRIFT-5461) Invalid golang code generated for optional set with a default value

2021-09-08 Thread Yuri Melnikov (Jira)
Yuri Melnikov created THRIFT-5461: - Summary: Invalid golang code generated for optional set with a default value Key: THRIFT-5461 URL: https://issues.apache.org/jira/browse/THRIFT-5461 Project: Thrift

Re: [VOTE] Apache Thrift 0.15.0-rc0 release candidate

2021-09-08 Thread Allen George
+1 --- Terminal Musings: http://www.allengeorge.com/ Twitter: https://twitter.com/allenageorge/ Raft in Java: https://github.com/allengeorge/libraft/ Thrift Rust Bindings: https://thrift.apache.org On Wed, Sep 8, 2021 at 9:48 AM Randy Abernethy wrote: > +1 > > On Tue, Sep 7, 2021 at 9:18 PM Du

Re: [VOTE] Apache Thrift 0.15.0-rc0 release candidate

2021-09-08 Thread Randy Abernethy
+1 On Tue, Sep 7, 2021 at 9:18 PM Duru Can Celasun wrote: > +1 > > > > On Wed, 8 Sep 2021, at 01:31, Yuxuan Wang wrote: > > +1 > > > > On Sat, Sep 4, 2021 at 1:01 PM Jens Geyer wrote: > > > > > All, > > > > > > I propose that we accept the following release candidate as the > official > > > Apa