[GitHub] [thrift] bhalchandrap opened a new pull request #2484: THRIFT-5486 : fix issues found by spotbugs

2021-12-02 Thread GitBox
bhalchandrap opened a new pull request #2484: URL: https://github.com/apache/thrift/pull/2484 Fixes the following issues found by spotbugs: 1. Private method org.apache.thrift.partial.ThriftMetadata$ThriftPrimitive.getParentStruct() is never called 2. Private method org.apache.t

[GitHub] [thrift] bhalchandrap closed pull request #2481: address spotbugs warnings (remove unused methods, use more efficient …

2021-12-02 Thread GitBox
bhalchandrap closed pull request #2481: URL: https://github.com/apache/thrift/pull/2481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubs

[jira] [Created] (THRIFT-5486) fix issues found by spotbugs

2021-12-02 Thread Bhalchandra Pandit (Jira)
Bhalchandra Pandit created THRIFT-5486: -- Summary: fix issues found by spotbugs Key: THRIFT-5486 URL: https://issues.apache.org/jira/browse/THRIFT-5486 Project: Thrift Issue Type: Techni

error[E0658]: use of unstable library feature 'matches_macro' breakss Rust CI

2021-12-02 Thread Jens Geyer
Checking clap v2.34.0 error[E0658]: use of unstable library feature 'matches_macro' --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/clap-2.34.0/src/errors.rs:392:10 | 392 | !matches!( | ^^^ | = note: for more information, see https://github.co

Gradle vs CI - help needed

2021-12-02 Thread Jens Geyer
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/5.6.4/userguide/gradle_daemon.html. Daemon will be stopped at the end of the build stopping after processing FAILURE: Build failed with an exception. * Where: Script

[jira] [Created] (THRIFT-5485) @SuppressWarnings is placed above Javadoc

2021-12-02 Thread Marcono1234 (Jira)
Marcono1234 created THRIFT-5485: --- Summary: @SuppressWarnings is placed above Javadoc Key: THRIFT-5485 URL: https://issues.apache.org/jira/browse/THRIFT-5485 Project: Thrift Issue Type: Bug

[GitHub] [thrift] wujjpp opened a new pull request #2483: Buffer.concat has performance issue

2021-12-02 Thread GitBox
wujjpp opened a new pull request #2483: URL: https://github.com/apache/thrift/pull/2483 `Array.push` is more more effective `Array.concat` ```javascript const Benchmark = require('benchmark'); const buffer = Buffer.alloc(1024) buffer.fill('A') const loop = 1024;